alpha/4964: PR#4936 incorrect fix

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

alpha/4964: PR#4936 incorrect fix

Takashi-4
>Number:         4964
>Category:       alpha
>Synopsis:       PR#4936 incorrect fix
>Confidential:   yes
>Severity:       serious
>Priority:       high
>Responsible:    bugs
>State:          open
>Quarter:        
>Keywords:      
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 04 05:00:01 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     KUDO Takashi
>Release:        3.8-current
>Organization:
net
>Environment:
        System      : OpenBSD 3.8-current
        Architecture: OpenBSD.alpha
        Machine     : alpha
>Description:
This commit is wrong. number of zero is not enough.
http://archives.neohapsis.com/archives/openbsd/cvs/2005-12/0445.html
Please apply attached patch.

I forgot to mention two points.
1) for starting X on XP1000, need to set securelevel to -1 due to
   aperture driver limitation. it should be allow accessing 0x800.0000.0000 -
   0x800.ffff.ffff pci memory region on tsunami based platforms.
2) when shutdown X, console messed up.

>How-To-Repeat:
above
>Fix:
--- ./sys/arch/alpha/pci/tsreg.h.orig Wed Jan  4 13:19:46 2006
+++ ./sys/arch/alpha/pci/tsreg.h Wed Jan  4 13:20:06 2006
@@ -176,7 +176,7 @@
  */
 
 #define P_CSRBASE 0x001##8000##0000UL
-#define P_PCI_MEM 0x8000000000UL
+#define P_PCI_MEM 0x800##0000##0000UL
 #define P_PCI_IO 0x001##fc00##0000UL
 #define P_PCI_CONFIG 0x001##fe00##0000UL


>Release-Note:
>Audit-Trail:
>Unformatted: