add Winchiphead CH382 PCIe-UART to pcidevs

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

add Winchiphead CH382 PCIe-UART to pcidevs

SASANO Takayoshi
Hello,

Here is Nanjing QinHeng Electronics (Winchiphead)'s CH382
PCIe-UART controller's PCI vendor/device ID.

Chinese Datasheet can be obtained from
http://www.wch.cn/downloads/downfile.php?id=140

Can I commit?

Regards,

--
SASANO Takayoshi <[hidden email]>

Index: pcidevs
===================================================================
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.1741
diff -u -p -r1.1741 pcidevs
--- pcidevs 13 Sep 2014 05:11:27 -0000 1.1741
+++ pcidevs 21 Sep 2014 06:53:14 -0000
@@ -327,6 +327,7 @@ vendor REDHAT 0x1b36 Red Hat
 vendor MARVELL2 0x1b4b Marvell
 vendor ETRON 0x1b6f Etron
 vendor FRESCO 0x1b73 Fresco Logic
+vendor WCH2 0x1c00 Nanjing QinHeng Electronics
 vendor SYMPHONY2 0x1c1c Symphony Labs
 vendor TEKRAM2 0x1de1 Tekram
 vendor TEHUTI 0x1fc9 Tehuti Networks
@@ -4765,6 +4766,8 @@ product MUTECH MV1000 0x0001 MV1000
 
 /* Nanjing QinHeng Electronics products */
 product WCH CH352 0x3253 CH352
+product WCH2 CH382_1 0x3253 CH382
+product WCH2 CH382_2 0x3250 CH382
 
 /* National Datacomm Corp products */
 product NDC NCP130 0x0130 NCP130

Reply | Threaded
Open this post in threaded view
|

Re: add Winchiphead CH382 PCIe-UART to pcidevs

Jonathan Gray-11
On Sun, Sep 21, 2014 at 04:01:41PM +0900, SASANO Takayoshi wrote:
> Hello,
>
> Here is Nanjing QinHeng Electronics (Winchiphead)'s CH382
> PCIe-UART controller's PCI vendor/device ID.
>
> Chinese Datasheet can be obtained from
> http://www.wch.cn/downloads/downfile.php?id=140
>
> Can I commit?

The pcisig vendor search
https://www.pcisig.com/membership/vid_search/
lists 0x1c00 as "Jiangsu Qinheng Co., Ltd." though Nanjing is the
capital city of the Jiangsu province so it seems find to refer to
both vids with the same name.

You should sort the pcidevs so 0x3250 comes before 0x3253,
and I suspect you missed including the pucdata.c part of the diff?

>
> Regards,
>
> --
> SASANO Takayoshi <[hidden email]>
>
> Index: pcidevs
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/pcidevs,v
> retrieving revision 1.1741
> diff -u -p -r1.1741 pcidevs
> --- pcidevs 13 Sep 2014 05:11:27 -0000 1.1741
> +++ pcidevs 21 Sep 2014 06:53:14 -0000
> @@ -327,6 +327,7 @@ vendor REDHAT 0x1b36 Red Hat
>  vendor MARVELL2 0x1b4b Marvell
>  vendor ETRON 0x1b6f Etron
>  vendor FRESCO 0x1b73 Fresco Logic
> +vendor WCH2 0x1c00 Nanjing QinHeng Electronics
>  vendor SYMPHONY2 0x1c1c Symphony Labs
>  vendor TEKRAM2 0x1de1 Tekram
>  vendor TEHUTI 0x1fc9 Tehuti Networks
> @@ -4765,6 +4766,8 @@ product MUTECH MV1000 0x0001 MV1000
>  
>  /* Nanjing QinHeng Electronics products */
>  product WCH CH352 0x3253 CH352
> +product WCH2 CH382_1 0x3253 CH382
> +product WCH2 CH382_2 0x3250 CH382
>  
>  /* National Datacomm Corp products */
>  product NDC NCP130 0x0130 NCP130