WANTLIB, HOMEPAGE: graphics/inkscape

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

WANTLIB, HOMEPAGE: graphics/inkscape

Rafael Sadowski
Hi ports@,

fix/update WANTLIB and update https ready HOMEPAGE for inkscape.
I like inkscape but I fight with lot of crashes. I use inkscape from
packages and not from ports on my clean work machine.

So I think, the inkscape port needs more love ;)

Best regards,

Rafael

Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/inkscape/Makefile,v
retrieving revision 1.47
diff -u -p -u -p -r1.47 Makefile
--- Makefile 29 Nov 2015 10:45:22 -0000 1.47
+++ Makefile 28 Jan 2016 22:03:57 -0000
@@ -7,26 +7,24 @@ COMMENT= SVG vector drawing application
 
 DISTNAME= inkscape-0.91
 CATEGORIES= graphics
-REVISION= 5
+REVISION= 6
 
 MASTER_SITES = https://inkscape.org/en/gallery/item/3854/
-HOMEPAGE= http://www.inkscape.org/
+HOMEPAGE= https://inkscape.org/
 
 # GPLv2 and LGPLv2.1
 PERMIT_PACKAGE_CDROM= Yes
 
-WANTLIB += ICE Magick++-6.Q16 MagickCore-6.Q16 MagickWand-6.Q16
-WANTLIB += SM X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama
-WANTLIB += Xrandr Xrender Xt aspell atk-1.0 atkmm-1.6 bz2 c cairo
-WANTLIB += cairomm-1.0 djvulibre enchant exif expat ffi fftw3
-WANTLIB += fontconfig freetype gc gdk-x11-2.0 gdk_pixbuf-2.0 gdkmm-2.4
-WANTLIB += gio-2.0 giomm-2.4 glib-2.0 glibmm-2.4 gmodule-2.0 gobject-2.0
-WANTLIB += graphite2 gsl gslcblas gthread-2.0 gtk-x11-2.0 gtkmm-2.4
-WANTLIB += gtkspell harfbuzz jbig jpeg lcms2 lzma m openjp2 openjpeg
-WANTLIB += pango-1.0 pangocairo-1.0 pangoft2-1.0 pangomm-1.4 pcre
-WANTLIB += pixman-1 png poppler poppler-glib popt pthread pthread-stubs
-WANTLIB += sigc-2.0 stdc++ tiff webp xcb xcb-render xcb-shm xml2
-WANTLIB += xslt z
+WANTLIB += X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama
+WANTLIB += Xrandr Xrender aspell atk-1.0 atkmm-1.6 c cairo cairomm-1.0
+WANTLIB += enchant exif expat ffi fontconfig freetype gc gdk-x11-2.0
+WANTLIB += gdk_pixbuf-2.0 gdkmm-2.4 gio-2.0 giomm-2.4 glib-2.0
+WANTLIB += glibmm-2.4 gmodule-2.0 gobject-2.0 graphite2 gsl gslcblas
+WANTLIB += gthread-2.0 gtk-x11-2.0 gtkmm-2.4 gtkspell harfbuzz
+WANTLIB += jpeg lcms2 lzma m openjpeg pango-1.0 pangocairo-1.0
+WANTLIB += pangoft2-1.0 pangomm-1.4 pcre pixman-1 png poppler
+WANTLIB += poppler-glib popt pthread pthread-stubs sigc-2.0 stdc++
+WANTLIB += tiff xcb xcb-render xcb-shm xml2 xslt z
 
 MODULES= devel/gettext \
  textproc/intltool \

Reply | Threaded
Open this post in threaded view
|

Re: WANTLIB, HOMEPAGE: graphics/inkscape

Stuart Henderson-6
On 2016/01/28 23:12, Rafael Sadowski wrote:
> Hi ports@,
>
> fix/update WANTLIB and update https ready HOMEPAGE for inkscape.

NAK - WANTLIB is already correct for -current. We could change
HOMEPAGE but I don't see much point in changing just that since
the existing one is not invalid..

> I like inkscape but I fight with lot of crashes. I use inkscape from
> packages and not from ports on my clean work machine.
>
> So I think, the inkscape port needs more love ;)

Yes, I suspect it may be suffering from memory problems made more
obvious when malloc changed to junking the start of freed pages by
default.

I bet some of these will show on an ASAN build on Linux too.

Reply | Threaded
Open this post in threaded view
|

Re: WANTLIB, HOMEPAGE: graphics/inkscape

Nigel Taylor-2
In reply to this post by Rafael Sadowski
The WANTLIB shouldn't require changes

$ check-lib-depends -d . inkscape-0.91p5.tgz
Scanning: ok

$ ls -lrt ink*
-rw-r--r--  3 30013396 Jan 28 22:05 inkscape-0.91p5.tgz

That was built today with current.

It suggests there is something wrong with your building methods. You
seems to have lost ImageMagick

From dpb log file....

Configuration:

        Source code location:     .
        Destination path prefix:  /usr/local
        Compiler:                 c++
        CPPFLAGS:                 -DG_DISABLE_DEPRECATED
-DGLIBMM_DISABLE_DEPRECATED -DGDKMM_DISABLE_DEPRECATED
-DGTK_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_DEPRECATED
-DGTKMM_DISABLE_DEPRECATED -Werror=format-security -Wswitch
-Werror=return-type -DGSEAL_ENABLE -DG_DISABLE_SINGLE_INCLUDES -Wall
-Wformat -Wformat-security -W -D_FORTIFY_SOURCE=2
-I/usr/local/include/ImageMagick  -I/usr/local/include -I/usr/X11R6/include
        CXXFLAGS:                 -Wpointer-arith -Wcast-align
-Wsign-compare -Woverloaded-virtual -Wswitch -Wno-unused-parameter -O2
-pipe -std=c++11
        CFLAGS:                   -Wno-pointer-sign -O2 -pipe
        LDFLAGS:                  -Wl,-z,relro -L/usr/local/lib
-L/usr/X11R6/lib

        Use gnome-vfs:            no
        Use openoffice files:     yes
        Use relocation support:   no
        Enable LittleCms:         yes
        Enable DBUS:              no
        Enable Poppler-Cairo:     yes
        ImageMagick Magick++:     yes
        Libwpg:                   no
        Libvisio:                 no
        Libcdr:                   no
        Doing Local Install:      no
.......
-lfreetype -lz -lsigc-2.0 -lz -lpopt -laspell -L/usr/local/lib -lexif
-L/usr/X11R6/lib -lfreetype -lz         -L/usr/local/lib
-L/usr/X11R6/lib -lMagick++-6.Q16 -lMagickWand-6.Q16 -lMagickCore-6.Q16
-L/usr/X11R6/lib -lX11 -ljpeg  -L/usr/loca
l/lib -llcms2 -L/usr/local/lib -lpoppler -L/usr/local/lib
-Wl,-rpath-link,/usr/X11R6/lib -lpoppler-glib -lgio-2.0 -lgobject-2.0
-lglib-2.0 -lintl -lcairo
......


If for any reason pkg_delete ImageMagick is run the autoconfig will
(should) not detect it and your see a no in the above.

If building without ImageMagick you would have to change the LIB_DEPENDS
also and CONFIGURE_....

You would also have to find a means of disabling ImageMagick, if it is
built when ImageMagick was present, there might be an appropriate config
argument.

Either way this has to be wrong apart from the home page change which I
haven't checked.



On 01/28/16 22:12, Rafael Sadowski wrote:

> Hi ports@,
>
> fix/update WANTLIB and update https ready HOMEPAGE for inkscape.
> I like inkscape but I fight with lot of crashes. I use inkscape from
> packages and not from ports on my clean work machine.
>
> So I think, the inkscape port needs more love ;)
>
> Best regards,
>
> Rafael
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/graphics/inkscape/Makefile,v
> retrieving revision 1.47
> diff -u -p -u -p -r1.47 Makefile
> --- Makefile 29 Nov 2015 10:45:22 -0000 1.47
> +++ Makefile 28 Jan 2016 22:03:57 -0000
> @@ -7,26 +7,24 @@ COMMENT= SVG vector drawing application
>  
>  DISTNAME= inkscape-0.91
>  CATEGORIES= graphics
> -REVISION= 5
> +REVISION= 6
>  
>  MASTER_SITES = https://inkscape.org/en/gallery/item/3854/
> -HOMEPAGE= http://www.inkscape.org/
> +HOMEPAGE= https://inkscape.org/
>  
>  # GPLv2 and LGPLv2.1
>  PERMIT_PACKAGE_CDROM= Yes
>  
> -WANTLIB += ICE Magick++-6.Q16 MagickCore-6.Q16 MagickWand-6.Q16
> -WANTLIB += SM X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama
> -WANTLIB += Xrandr Xrender Xt aspell atk-1.0 atkmm-1.6 bz2 c cairo
> -WANTLIB += cairomm-1.0 djvulibre enchant exif expat ffi fftw3
> -WANTLIB += fontconfig freetype gc gdk-x11-2.0 gdk_pixbuf-2.0 gdkmm-2.4
> -WANTLIB += gio-2.0 giomm-2.4 glib-2.0 glibmm-2.4 gmodule-2.0 gobject-2.0
> -WANTLIB += graphite2 gsl gslcblas gthread-2.0 gtk-x11-2.0 gtkmm-2.4
> -WANTLIB += gtkspell harfbuzz jbig jpeg lcms2 lzma m openjp2 openjpeg
> -WANTLIB += pango-1.0 pangocairo-1.0 pangoft2-1.0 pangomm-1.4 pcre
> -WANTLIB += pixman-1 png poppler poppler-glib popt pthread pthread-stubs
> -WANTLIB += sigc-2.0 stdc++ tiff webp xcb xcb-render xcb-shm xml2
> -WANTLIB += xslt z
> +WANTLIB += X11 Xcomposite Xcursor Xdamage Xext Xfixes Xi Xinerama
> +WANTLIB += Xrandr Xrender aspell atk-1.0 atkmm-1.6 c cairo cairomm-1.0
> +WANTLIB += enchant exif expat ffi fontconfig freetype gc gdk-x11-2.0
> +WANTLIB += gdk_pixbuf-2.0 gdkmm-2.4 gio-2.0 giomm-2.4 glib-2.0
> +WANTLIB += glibmm-2.4 gmodule-2.0 gobject-2.0 graphite2 gsl gslcblas
> +WANTLIB += gthread-2.0 gtk-x11-2.0 gtkmm-2.4 gtkspell harfbuzz
> +WANTLIB += jpeg lcms2 lzma m openjpeg pango-1.0 pangocairo-1.0
> +WANTLIB += pangoft2-1.0 pangomm-1.4 pcre pixman-1 png poppler
> +WANTLIB += poppler-glib popt pthread pthread-stubs sigc-2.0 stdc++
> +WANTLIB += tiff xcb xcb-render xcb-shm xml2 xslt z
>  
>  MODULES= devel/gettext \
>   textproc/intltool \
>
>