Update: www/py-beautifulsoup4 4.6.3 -> 4.7.1

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Update: www/py-beautifulsoup4 4.6.3 -> 4.7.1

Kurt Mosiejczuk-9
Here is an update for www/py-beautifulsoup4 to the latest, 4.7.1.

It requires the new www/py-soupsieve port I sent out earlier tonight.
It converts over to using MODPY_PI so discards the MASTER_SITES line.
I also convert it to using standard MODPY-PYTEST rather than the
custom do-test target.

Of its TEST_DEPENDS consumers (which seems to be all its RUN_DEPENDS
consumers except x11/nagstamon), all the ports that have working
tests have all tests pass. The following ports tests didn't work:
audio/beets(tries to pull down responses over the net, I'm running
PORTS_PRIVSEP), net/py-siphon(missing dedepencies), www/buku (missing
dependencies), math/py-pandas(broken with pytest which complains about
calling fixtures directly), and security/wapiti (No tests to run).

I filled in missing dependencies for www/py-webtest to run its tests and
they all pass. Also passing on amd64 are net/toot, textproc/py-ofxparse,
and security/theharvester(the one test it has passes).

Originally I just set out to figure out why bs4's tests wouldn't run
directly via "make test". I had to run "make fake" first. If this update
isn't wanted at this point, I do have a separate diff for 4.6.3 that
irons out the weirdness with testing.

cc maintainer

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/www/py-beautifulsoup4/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- Makefile 28 Apr 2019 20:51:58 -0000 1.10
+++ Makefile 30 Jun 2019 02:30:47 -0000
@@ -2,32 +2,30 @@
 
 COMMENT = HTML/XML parser that supports invalid markup
 
-MODPY_EGG_VERSION = 4.6.3
+MODPY_EGG_VERSION = 4.7.1
 DISTNAME = beautifulsoup4-${MODPY_EGG_VERSION}
 PKGNAME = py-${DISTNAME}
-REVISION = 0
 
 CATEGORIES = www
 
-HOMEPAGE = http://www.crummy.com/software/BeautifulSoup/
+HOMEPAGE = https://www.crummy.com/software/BeautifulSoup/
 MAINTAINER = frantisek holop <[hidden email]>
 
 # MIT
-PERMIT_PACKAGE_CDROM = Yes
-
-MASTER_SITES = ${HOMEPAGE}bs4/download/4.6/
+PERMIT_PACKAGE = Yes
 
 MODULES = lang/python
 
-TEST_DEPENDS = devel/py-html5lib${MODPY_FLAVOR} \
- textproc/py-lxml${MODPY_FLAVOR}
-
 FLAVORS = python3
 FLAVOR ?=
 
 MODPY_SETUPTOOLS = Yes
+MODPY_PI = Yes
+MODPY_PYTEST = Yes
+MODPY_PYTEST_ARGS = lib/bs4
 
-do-test: fake
- cd ${WRKINST}${MODPY_SITEPKG} && ${MODPY_BIN} -m unittest discover -s bs4
+RUN_DEPENDS = www/py-soupsieve${MODPY_FLAVOR}
+TEST_DEPENDS = devel/py-html5lib${MODPY_FLAVOR} \
+ textproc/py-lxml${MODPY_FLAVOR}
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/py-beautifulsoup4/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo 1 Jan 2019 09:02:17 -0000 1.7
+++ distinfo 30 Jun 2019 02:30:47 -0000
@@ -1,2 +1,2 @@
-SHA256 (beautifulsoup4-4.6.3.tar.gz) = kPjmESHWrlg2LOO+2M2ZfvsAyRTq4P89Njwy+amCLRA=
-SIZE (beautifulsoup4-4.6.3.tar.gz) = 167469
+SHA256 (beautifulsoup4-4.7.1.tar.gz) = lFBll5+4Up3S8327WPALZhvby+v5VPk7Mv31Jj7zU0g=
+SIZE (beautifulsoup4-4.7.1.tar.gz) = 167065

Reply | Threaded
Open this post in threaded view
|

Re: Update: www/py-beautifulsoup4 4.6.3 -> 4.7.1

Kurt Mosiejczuk-9
On Sun, Jun 30, 2019 at 10:10:59PM -0400, Kurt Mosiejczuk wrote:
> Here is an update for www/py-beautifulsoup4 to the latest, 4.7.1.

> It requires the new www/py-soupsieve port I sent out earlier tonight.
> It converts over to using MODPY_PI so discards the MASTER_SITES line.
> I also convert it to using standard MODPY-PYTEST rather than the
> custom do-test target.

> Of its TEST_DEPENDS consumers (which seems to be all its RUN_DEPENDS
> consumers except x11/nagstamon), all the ports that have working
> tests have all tests pass. The following ports tests didn't work:
> audio/beets(tries to pull down responses over the net, I'm running
> PORTS_PRIVSEP), net/py-siphon(missing dedepencies), www/buku (missing
> dependencies), math/py-pandas(broken with pytest which complains about
> calling fixtures directly), and security/wapiti (No tests to run).

> I filled in missing dependencies for www/py-webtest to run its tests and
> they all pass. Also passing on amd64 are net/toot, textproc/py-ofxparse,
> and security/theharvester(the one test it has passes).

> Originally I just set out to figure out why bs4's tests wouldn't run
> directly via "make test". I had to run "make fake" first. If this update
> isn't wanted at this point, I do have a separate diff for 4.6.3 that
> irons out the weirdness with testing.

> cc maintainer

Ping

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/www/py-beautifulsoup4/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- Makefile 28 Apr 2019 20:51:58 -0000 1.10
+++ Makefile 30 Jun 2019 02:30:47 -0000
@@ -2,32 +2,30 @@
 
 COMMENT = HTML/XML parser that supports invalid markup
 
-MODPY_EGG_VERSION = 4.6.3
+MODPY_EGG_VERSION = 4.7.1
 DISTNAME = beautifulsoup4-${MODPY_EGG_VERSION}
 PKGNAME = py-${DISTNAME}
-REVISION = 0
 
 CATEGORIES = www
 
-HOMEPAGE = http://www.crummy.com/software/BeautifulSoup/
+HOMEPAGE = https://www.crummy.com/software/BeautifulSoup/
 MAINTAINER = frantisek holop <[hidden email]>
 
 # MIT
-PERMIT_PACKAGE_CDROM = Yes
-
-MASTER_SITES = ${HOMEPAGE}bs4/download/4.6/
+PERMIT_PACKAGE = Yes
 
 MODULES = lang/python
 
-TEST_DEPENDS = devel/py-html5lib${MODPY_FLAVOR} \
- textproc/py-lxml${MODPY_FLAVOR}
-
 FLAVORS = python3
 FLAVOR ?=
 
 MODPY_SETUPTOOLS = Yes
+MODPY_PI = Yes
+MODPY_PYTEST = Yes
+MODPY_PYTEST_ARGS = lib/bs4
 
-do-test: fake
- cd ${WRKINST}${MODPY_SITEPKG} && ${MODPY_BIN} -m unittest discover -s bs4
+RUN_DEPENDS = www/py-soupsieve${MODPY_FLAVOR}
+TEST_DEPENDS = devel/py-html5lib${MODPY_FLAVOR} \
+ textproc/py-lxml${MODPY_FLAVOR}
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/py-beautifulsoup4/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo 1 Jan 2019 09:02:17 -0000 1.7
+++ distinfo 30 Jun 2019 02:30:47 -0000
@@ -1,2 +1,2 @@
-SHA256 (beautifulsoup4-4.6.3.tar.gz) = kPjmESHWrlg2LOO+2M2ZfvsAyRTq4P89Njwy+amCLRA=
-SIZE (beautifulsoup4-4.6.3.tar.gz) = 167469
+SHA256 (beautifulsoup4-4.7.1.tar.gz) = lFBll5+4Up3S8327WPALZhvby+v5VPk7Mv31Jj7zU0g=
+SIZE (beautifulsoup4-4.7.1.tar.gz) = 167065

Reply | Threaded
Open this post in threaded view
|

Re: Update: www/py-beautifulsoup4 4.6.3 -> 4.7.1

Kurt Mosiejczuk-9
On Mon, Jul 15, 2019 at 09:01:59PM -0400, Kurt Mosiejczuk wrote:
> On Sun, Jun 30, 2019 at 10:10:59PM -0400, Kurt Mosiejczuk wrote:
> > Here is an update for www/py-beautifulsoup4 to the latest, 4.7.1.

> > It requires the new www/py-soupsieve port I sent out earlier tonight.
> > It converts over to using MODPY_PI so discards the MASTER_SITES line.
> > I also convert it to using standard MODPY-PYTEST rather than the
> > custom do-test target.

> > Of its TEST_DEPENDS consumers (which seems to be all its RUN_DEPENDS
> > consumers except x11/nagstamon), all the ports that have working
> > tests have all tests pass. The following ports tests didn't work:
> > audio/beets(tries to pull down responses over the net, I'm running
> > PORTS_PRIVSEP), net/py-siphon(missing dedepencies), www/buku (missing
> > dependencies), math/py-pandas(broken with pytest which complains about
> > calling fixtures directly), and security/wapiti (No tests to run).

> > I filled in missing dependencies for www/py-webtest to run its tests and
> > they all pass. Also passing on amd64 are net/toot, textproc/py-ofxparse,
> > and security/theharvester(the one test it has passes).

> > Originally I just set out to figure out why bs4's tests wouldn't run
> > directly via "make test". I had to run "make fake" first. If this update
> > isn't wanted at this point, I do have a separate diff for 4.6.3 that
> > irons out the weirdness with testing.

> > cc maintainer

> Ping

Ping.

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/www/py-beautifulsoup4/Makefile,v
retrieving revision 1.11
diff -u -p -r1.11 Makefile
--- Makefile 12 Jul 2019 20:51:00 -0000 1.11
+++ Makefile 2 Aug 2019 03:34:32 -0000
@@ -2,32 +2,30 @@
 
 COMMENT = HTML/XML parser that supports invalid markup
 
-MODPY_EGG_VERSION = 4.6.3
+MODPY_EGG_VERSION = 4.7.1
 DISTNAME = beautifulsoup4-${MODPY_EGG_VERSION}
 PKGNAME = py-${DISTNAME}
-REVISION = 0
 
 CATEGORIES = www
 
-HOMEPAGE = http://www.crummy.com/software/BeautifulSoup/
+HOMEPAGE = https://www.crummy.com/software/BeautifulSoup/
 MAINTAINER = frantisek holop <[hidden email]>
 
 # MIT
 PERMIT_PACKAGE = Yes
 
-MASTER_SITES = ${HOMEPAGE}bs4/download/4.6/
-
 MODULES = lang/python
 
-TEST_DEPENDS = devel/py-html5lib${MODPY_FLAVOR} \
- textproc/py-lxml${MODPY_FLAVOR}
-
 FLAVORS = python3
 FLAVOR ?=
 
 MODPY_SETUPTOOLS = Yes
+MODPY_PI = Yes
+MODPY_PYTEST = Yes
+MODPY_PYTEST_ARGS = lib/bs4
 
-do-test: fake
- cd ${WRKINST}${MODPY_SITEPKG} && ${MODPY_BIN} -m unittest discover -s bs4
+RUN_DEPENDS = www/py-soupsieve${MODPY_FLAVOR}
+TEST_DEPENDS = devel/py-html5lib${MODPY_FLAVOR} \
+ textproc/py-lxml${MODPY_FLAVOR}
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/www/py-beautifulsoup4/distinfo,v
retrieving revision 1.7
diff -u -p -r1.7 distinfo
--- distinfo 1 Jan 2019 09:02:17 -0000 1.7
+++ distinfo 2 Aug 2019 03:34:32 -0000
@@ -1,2 +1,2 @@
-SHA256 (beautifulsoup4-4.6.3.tar.gz) = kPjmESHWrlg2LOO+2M2ZfvsAyRTq4P89Njwy+amCLRA=
-SIZE (beautifulsoup4-4.6.3.tar.gz) = 167469
+SHA256 (beautifulsoup4-4.7.1.tar.gz) = lFBll5+4Up3S8327WPALZhvby+v5VPk7Mv31Jj7zU0g=
+SIZE (beautifulsoup4-4.7.1.tar.gz) = 167065

Reply | Threaded
Open this post in threaded view
|

Re: Update: www/py-beautifulsoup4 4.6.3 -> 4.7.1

Daniel Jakots-6
On Thu, 1 Aug 2019 23:35:11 -0400, Kurt Mosiejczuk <[hidden email]>
wrote:

> Here is an update for www/py-beautifulsoup4 to the latest, 4.7.1.  

tl;dr: Please remove maintainer (wait a few days in case he wants to
argue otherwise) and ok danj@ for the update (don't forget soupsieve
first ;)).


Regarding maintainer, he doesn't maintain his ports (look at portroach
if you doubt it) and whenever someone cares to update his ports and send
a diff on ports@ he barely never answers (look at ports archive
history for confirmation, if this thread is not enough).

When I sent my maintainer ping back in May, he replied 16 days later
(while it was written he had two weeks, which was already quite much)
saying "i havent been very active lately" which I think no one is going
to disagree with :)
Since he admitted he wasn't active I asked him to reconsider keeping
maintainership and he simply stopped answering.


I think this kind of behaviour is actually hurtful toward people who
actually try to maintain the ports so yeah, please remove him.

Cheers,
Daniel