Update: net/openfire 3.9.1 -> 3.9.2; advise needed

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Update: net/openfire 3.9.1 -> 3.9.2; advise needed

Marc Peters-3
Hi,

this update needs a new file in /usr/local/openfire/conf and a new patch
for this new file. It is /usr/local/openfire/conf/security.xml and i
wanted to clear the value for <property>, so that any user can define
him-/herself, what will be encrypted by openfire at the next start.

I would like to know, how to include this new file in PLIST and add a
patches directory with a new file, so that openfire will start without
any further user intevention after upgrade.

Marc

Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.2; advise needed

Joachim Schipper-2
On Sat, May 03, 2014 at 04:52:29PM +0200, Marc Peters wrote:

> Hi,
>
> this update needs a new file in /usr/local/openfire/conf and a new patch
> for this new file. It is /usr/local/openfire/conf/security.xml and i
> wanted to clear the value for <property>, so that any user can define
> him-/herself, what will be encrypted by openfire at the next start.
>
> I would like to know, how to include this new file in PLIST and add a
> patches directory with a new file, so that openfire will start without
> any further user intevention after upgrade.

Just:
 + add the file to do-install (look at the existing openfire.xml?)
 + make update-plist, and ensure security.xml is added
 + copy the security.xml under the source directory to security.xml.orig
 + make the changes you want
 + make update-patches

That said, all else being equal, it's better for ports to behave as the
author intended/as they work elsewhere.

                Joachim

Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.2; advise needed

Marc Peters-3
On 05/04/14 10:36, Joachim Schipper wrote:

> On Sat, May 03, 2014 at 04:52:29PM +0200, Marc Peters wrote:
>> Hi,
>>
>> this update needs a new file in /usr/local/openfire/conf and a new patch
>> for this new file. It is /usr/local/openfire/conf/security.xml and i
>> wanted to clear the value for <property>, so that any user can define
>> him-/herself, what will be encrypted by openfire at the next start.
>>
>> I would like to know, how to include this new file in PLIST and add a
>> patches directory with a new file, so that openfire will start without
>> any further user intevention after upgrade.
>
> Just:
>  + add the file to do-install (look at the existing openfire.xml?)
>  + make update-plist, and ensure security.xml is added
>  + copy the security.xml under the source directory to security.xml.orig
>  + make the changes you want
>  + make update-patches
>
> That said, all else being equal, it's better for ports to behave as the
> author intended/as they work elsewhere.
>
> Joachim
The new file security.xml, can be used to encrypt properties in the
openfire.xml. The downside is, that openfire won't start without it, and
i was not able to found any documentation about it. Just one post in the
communityforum, where it broke authenticatin of another user, because of
the default listing in it.

http://community.igniterealtime.org/message/238720

Therefore i patch the initial list out (list can be edited at runtime
via the "System Properties" page in the Openfire console) and add the
file to the correct directory for a smoother upgrade than i initially
had ;).

Should this issue be mentioned in the README? I rearranged the examples
section a bit.

Patch is attached. Comments, OKs?

openfire-3.9.2.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.2; advise needed

Stuart Henderson
I don't see any advantage to moving the 2 config files into share/examples/openfire/conf rather than just keeping them in share/examples/openfire as they are now.

On 5 May 2014 09:52:09 BST, Marc Peters <[hidden email]> wrote:

>On 05/04/14 10:36, Joachim Schipper wrote:
>> On Sat, May 03, 2014 at 04:52:29PM +0200, Marc Peters wrote:
>>> Hi,
>>>
>>> this update needs a new file in /usr/local/openfire/conf and a new
>patch
>>> for this new file. It is /usr/local/openfire/conf/security.xml and i
>>> wanted to clear the value for <property>, so that any user can
>define
>>> him-/herself, what will be encrypted by openfire at the next start.
>>>
>>> I would like to know, how to include this new file in PLIST and add
>a
>>> patches directory with a new file, so that openfire will start
>without
>>> any further user intevention after upgrade.
>>
>> Just:
>>  + add the file to do-install (look at the existing openfire.xml?)
>>  + make update-plist, and ensure security.xml is added
>>  + copy the security.xml under the source directory to
>security.xml.orig
>>  + make the changes you want
>>  + make update-patches
>>
>> That said, all else being equal, it's better for ports to behave as
>the
>> author intended/as they work elsewhere.
>>
>> Joachim
>
>The new file security.xml, can be used to encrypt properties in the
>openfire.xml. The downside is, that openfire won't start without it,
>and
>i was not able to found any documentation about it. Just one post in
>the
>communityforum, where it broke authenticatin of another user, because
>of
>the default listing in it.
>
>http://community.igniterealtime.org/message/238720
>
>Therefore i patch the initial list out (list can be edited at runtime
>via the "System Properties" page in the Openfire console) and add the
>file to the correct directory for a smoother upgrade than i initially
>had ;).
>
>Should this issue be mentioned in the README? I rearranged the examples
>section a bit.
>
>Patch is attached. Comments, OKs?
Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.2; advise needed

Marc Peters-3
On 05/11/14 10:44, Stuart Henderson wrote:
> I don't see any advantage to moving the 2 config files into share/examples/openfire/conf rather than just keeping them in share/examples/openfire as they are now.

The second file wasn't copied to examples, so i decided a new
subdirectory would make sense, but i will change that.

Openfire 3.9.3 is already out, i will send a new diff in the next couple
of days with the latest version.

Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.3

Marc Peters-3
In reply to this post by Stuart Henderson
On 05/11/14 10:44, Stuart Henderson wrote:
> I don't see any advantage to moving the 2 config files into share/examples/openfire/conf rather than just keeping them in share/examples/openfire as they are now.
>

Patch attached to update Openfire to the latest version 3.9.3.

openfire-3.9.3.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.3

Stuart Henderson-6
On 2014/05/28 11:10, Marc Peters wrote:
> On 05/11/14 10:44, Stuart Henderson wrote:
> > I don't see any advantage to moving the 2 config files into share/examples/openfire/conf rather than just keeping them in share/examples/openfire as they are now.
> >
>
> Patch attached to update Openfire to the latest version 3.9.3.

> diff -u -p -u -p -r1.6 PLIST
> --- pkg/PLIST 16 Mar 2014 01:34:31 -0000 1.6
> +++ pkg/PLIST 28 May 2014 09:06:13 -0000
> @@ -417,6 +417,7 @@ share/examples/openfire/security/
>  @mode
>  @owner
>  @group
> +share/examples/openfire/security.xml

Does this file not want an "@sample openfire/conf/security.xml" or similar?

>  share/examples/openfire/security/client.truststore
>  @mode 660
>  @owner root

Reply | Threaded
Open this post in threaded view
|

Re: Update: net/openfire 3.9.1 -> 3.9.3

Marc Peters-3
On 05/28/14 12:03, Stuart Henderson wrote:

>> diff -u -p -u -p -r1.6 PLIST
>> --- pkg/PLIST 16 Mar 2014 01:34:31 -0000 1.6
>> +++ pkg/PLIST 28 May 2014 09:06:13 -0000
>> @@ -417,6 +417,7 @@ share/examples/openfire/security/
>>  @mode
>>  @owner
>>  @group
>> +share/examples/openfire/security.xml
>
> Does this file not want an "@sample openfire/conf/security.xml" or similar?
>
Of course it does, missed that one. Thanks, Stuart. Updated diff attached.


openfire-3.9.3.patch (2K) Download Attachment