[Update] devel/p5-Object-Signature : Update to 1.08

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[Update] devel/p5-Object-Signature : Update to 1.08

wen heping
Hi, ports@ :

   Here is a patch to update devel/p5-Object-Signature to 1.08.
   It build well and passed all tests on my amd64-head system.

   Three ports depends on devel/p5-Object-Signature:
    www/p5-Dancer-Plugin-Thumbnail and www/p5-Catalyst-Plugin-Session-PerUser
build well and passed all tests.
    www/p5-Catalyst-Plugin-Session: build well , 1 tests failed but it was not
caused by the update of devel/p5-Object-Signature.

Comments? OK?

wen

p5-Object-Signature-1.08.diff.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Update] devel/p5-Object-Signature : Update to 1.08

Charlene Wendling
On Wed, 17 Jul 2019 08:56:06 +0000
wen heping wrote:

> Hi, ports@ :
>
>    Here is a patch to update devel/p5-Object-Signature to 1.08.
>    It build well and passed all tests on my amd64-head system.
>
>    Three ports depends on devel/p5-Object-Signature:
>     www/p5-Dancer-Plugin-Thumbnail and
> www/p5-Catalyst-Plugin-Session-PerUser build well and passed all
> tests.

> www/p5-Catalyst-Plugin-Session: build well , 1 tests failed
> but it was not caused by the update of devel/p5-Object-Signature.

It's known to upstream [0], but they are doing nothing about it, and
it's not trivial to fix as the bug report implies.

> Comments? OK?

As usual with ETHER's modules, it does not work when PORTS_PRIVSEP is
enabled:

drwx------  5 _pbuild  _pbuild   512B Jul 20 13:03 /usr/ports/pobj/p5-Object-Signature-1.08/Object-Signature-1.08

It requires:

FIX_EXTRACT_PERMISSIONS = Yes

I also removed the mixed use of space/tabs in the Makefile

Charlène.


[0] https://rt.cpan.org/Public/Bug/Display.html?id=71142


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Object-Signature/Makefile,v
retrieving revision 1.14
diff -u -p -u -p -r1.14 Makefile
--- Makefile 12 Jul 2019 21:02:17 -0000 1.14
+++ Makefile 20 Jul 2019 11:08:56 -0000
@@ -1,11 +1,12 @@
 # $OpenBSD: Makefile,v 1.14 2019/07/12 21:02:17 sthen Exp $
 
-COMMENT=        cryptographic signatures for objects
+COMMENT= cryptographic signatures for objects
 
 MODULES= cpan
 PKG_ARCH= *
-DISTNAME= Object-Signature-1.07
-CATEGORIES=     devel
+DISTNAME= Object-Signature-1.08
+CATEGORIES= devel
+FIX_EXTRACT_PERMISSIONS= Yes
 
 # perl
 PERMIT_PACKAGE= Yes
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Object-Signature/distinfo,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 distinfo
--- distinfo 18 Nov 2015 13:16:47 -0000 1.4
+++ distinfo 20 Jul 2019 11:08:56 -0000
@@ -1,2 +1,2 @@
-SHA256 (Object-Signature-1.07.tar.gz) = xhHWRGgzxqGKaP1EiPAX0p/Hd7ftzfrNBn3LVVI4FDE=
-SIZE (Object-Signature-1.07.tar.gz) = 29588
+SHA256 (Object-Signature-1.08.tar.gz) = hCFTyU2pPiucs7VN7lcrUGS79JmjanPDiiN5mgIDaYo=
+SIZE (Object-Signature-1.08.tar.gz) = 25746

Reply | Threaded
Open this post in threaded view
|

回复: [Update] devel/p5-Object-Signature : Update to 1.08

wen heping
Revised patch.
Thank cwen@ !

wen
________________________________
发件人: Charlene Wendling <[hidden email]>
发送时间: 2019年7月20日 19:25
收件人: wen heping <[hidden email]>
抄送: [hidden email] <[hidden email]>
主题: Re: [Update] devel/p5-Object-Signature : Update to 1.08

On Wed, 17 Jul 2019 08:56:06 +0000
wen heping wrote:

> Hi, ports@ :
>
>    Here is a patch to update devel/p5-Object-Signature to 1.08.
>    It build well and passed all tests on my amd64-head system.
>
>    Three ports depends on devel/p5-Object-Signature:
>     www/p5-Dancer-Plugin-Thumbnail and
> www/p5-Catalyst-Plugin-Session-PerUser build well and passed all
> tests.

> www/p5-Catalyst-Plugin-Session: build well , 1 tests failed
> but it was not caused by the update of devel/p5-Object-Signature.

It's known to upstream [0], but they are doing nothing about it, and
it's not trivial to fix as the bug report implies.

> Comments? OK?

As usual with ETHER's modules, it does not work when PORTS_PRIVSEP is
enabled:

drwx------  5 _pbuild  _pbuild   512B Jul 20 13:03 /usr/ports/pobj/p5-Object-Signature-1.08/Object-Signature-1.08

It requires:

FIX_EXTRACT_PERMISSIONS =       Yes

I also removed the mixed use of space/tabs in the Makefile

Charlène.


[0] https://rt.cpan.org/Public/Bug/Display.html?id=71142


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Object-Signature/Makefile,v
retrieving revision 1.14
diff -u -p -u -p -r1.14 Makefile
--- Makefile    12 Jul 2019 21:02:17 -0000      1.14
+++ Makefile    20 Jul 2019 11:08:56 -0000
@@ -1,11 +1,12 @@
 # $OpenBSD: Makefile,v 1.14 2019/07/12 21:02:17 sthen Exp $

-COMMENT=        cryptographic signatures for objects
+COMMENT=       cryptographic signatures for objects

 MODULES=        cpan
 PKG_ARCH=       *
-DISTNAME=      Object-Signature-1.07
-CATEGORIES=     devel
+DISTNAME=      Object-Signature-1.08
+CATEGORIES=    devel
+FIX_EXTRACT_PERMISSIONS=       Yes

 # perl
 PERMIT_PACKAGE= Yes
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Object-Signature/distinfo,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 distinfo
--- distinfo    18 Nov 2015 13:16:47 -0000      1.4
+++ distinfo    20 Jul 2019 11:08:56 -0000
@@ -1,2 +1,2 @@
-SHA256 (Object-Signature-1.07.tar.gz) = xhHWRGgzxqGKaP1EiPAX0p/Hd7ftzfrNBn3LVVI4FDE=
-SIZE (Object-Signature-1.07.tar.gz) = 29588
+SHA256 (Object-Signature-1.08.tar.gz) = hCFTyU2pPiucs7VN7lcrUGS79JmjanPDiiN5mgIDaYo=
+SIZE (Object-Signature-1.08.tar.gz) = 25746

p5-Object-Signature-1.08-p0.diff.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Update] devel/p5-Object-Signature : Update to 1.08

Stuart Henderson
In reply to this post by wen heping
On 2019/07/17 08:56, wen heping wrote:

> Hi, ports@ :
>
>    Here is a patch to update devel/p5-Object-Signature to 1.08.
>    It build well and passed all tests on my amd64-head system.
>
>    Three ports depends on devel/p5-Object-Signature:
>     www/p5-Dancer-Plugin-Thumbnail and www/p5-Catalyst-Plugin-Session-PerUser
> build well and passed all tests.
>     www/p5-Catalyst-Plugin-Session: build well , 1 tests failed but it was not
> caused by the update of devel/p5-Object-Signature.
>
> Comments? OK?

committed with tweaks (fix whitespace, add FIX_EXTRACT_PERMISSIONS).

> wen

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/p5-Object-Signature/Makefile,v
> retrieving revision 1.14
> diff -u -p -r1.14 Makefile
> --- Makefile 12 Jul 2019 21:02:17 -0000 1.14
> +++ Makefile 17 Jul 2019 08:44:38 -0000
> @@ -4,7 +4,7 @@ COMMENT=        cryptographic signatures
>  
>  MODULES= cpan
>  PKG_ARCH= *
> -DISTNAME= Object-Signature-1.07
> +DISTNAME= Object-Signature-1.08
>  CATEGORIES=     devel
>  
>  # perl
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/p5-Object-Signature/distinfo,v
> retrieving revision 1.4
> diff -u -p -r1.4 distinfo
> --- distinfo 18 Nov 2015 13:16:47 -0000 1.4
> +++ distinfo 17 Jul 2019 08:44:38 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (Object-Signature-1.07.tar.gz) = xhHWRGgzxqGKaP1EiPAX0p/Hd7ftzfrNBn3LVVI4FDE=
> -SIZE (Object-Signature-1.07.tar.gz) = 29588
> +SHA256 (Object-Signature-1.08.tar.gz) = hCFTyU2pPiucs7VN7lcrUGS79JmjanPDiiN5mgIDaYo=
> +SIZE (Object-Signature-1.08.tar.gz) = 25746