Update: archivers/innoextract - fixes extraction of GOG.com Windows archives

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Update: archivers/innoextract - fixes extraction of GOG.com Windows archives

Thomas Frohwein-2
Hi,

When trying to download and extract Ultimate Doom to test the gzdoom
update, I couldn't extract the GOG.com file with our innoextract. Turns
out that GOG.com has moved forward to creating those with a snapshot
version of Inno Setup that is not supported by the last release of
innoextract.

This diff updates the port to the latest snapshot of innoextract that
specifically addresses the issues with GOG. Of note, this proposed
update switches from the distfiles of the Homepage to the GitHub
commit. I am usually against this where possible because of GH's track
record of changing their on-the-fly tarball creation without notice. I
looked at the relevant patch history since release to see if we could
stay with 1.7 and add a patch, but the changes are too complex and
would make next updates potentially confusing. Therefore, I propose to
temporarily switch to GH_COMMIT. I placed a comment to switch back when
possible.

I think this is justified by GOG.com downloads being the main use case
which is broken in the current state. This update fixes the extraction
of the Ultimate Doom file.

Is 1.7.20190228 acceptable as the update version number? Feb 28, 2019
is the date of the GH commit, and the next release will likely be 1.8.

I would like to take MAINTAINER of innoextract while here.

ok?

Index: Makefile
===================================================================
RCS file: /cvs/ports/archivers/innoextract/Makefile,v
retrieving revision 1.12
diff -u -p -r1.12 Makefile
--- Makefile 16 Apr 2019 20:19:01 -0000 1.12
+++ Makefile 25 May 2019 18:22:50 -0000
@@ -2,19 +2,22 @@
 
 COMMENT= unpack Inno Setup installers
 
-DISTNAME= innoextract-1.7
-REVISION= 2
+DISTNAME= innoextract-1.7.20190228
+
+# revert to MASTER_SITES=${HOMEPAGE}files/ when releases have caught up
+GH_ACCOUNT= dscharrer
+GH_PROJECT= innoextract
+GH_COMMIT= 38ae68f393b2f3ed1862ec7f24b1d99bbbaacb19
 
 CATEGORIES= archivers
 HOMEPAGE= https://constexpr.org/innoextract/
-
-MASTER_SITES= ${HOMEPAGE}files/
+MAINTAINER= Thomas Frohwein <[hidden email]>
 
 # zlib/libpng
 PERMIT_PACKAGE_CDROM= Yes
 
 WANTLIB= boost_filesystem-mt boost_iostreams-mt boost_program_options-mt
-WANTLIB+= c iconv lzma m pthread ${COMPILER_LIBCXX}
+WANTLIB+= boost_system-mt c iconv lzma m pthread ${COMPILER_LIBCXX}
 
 COMPILER= base-clang ports-gcc
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/archivers/innoextract/distinfo,v
retrieving revision 1.4
diff -u -p -r1.4 distinfo
--- distinfo 24 Jun 2018 08:56:16 -0000 1.4
+++ distinfo 25 May 2019 18:22:50 -0000
@@ -1,2 +1,2 @@
-SHA256 (innoextract-1.7.tar.gz) = we+3MvK8OoAGXF9RoNTqYCeuv1KMYJ0/M2rqIFXS8KQ=
-SIZE (innoextract-1.7.tar.gz) = 195123
+SHA256 (innoextract-1.7.20190228-38ae68f3.tar.gz) = /qGU0dwlvZ/Wyau1lx/sf2C0Cp7QnJ75TWnI0vFR5sA=
+SIZE (innoextract-1.7.20190228-38ae68f3.tar.gz) = 194606

Reply | Threaded
Open this post in threaded view
|

Re: Update: archivers/innoextract - fixes extraction of GOG.com Windows archives

Jeremie Courreges-Anglas-2
On Sat, May 25 2019, Thomas Frohwein <[hidden email]> wrote:

> Hi,
>
> When trying to download and extract Ultimate Doom to test the gzdoom
> update, I couldn't extract the GOG.com file with our innoextract. Turns
> out that GOG.com has moved forward to creating those with a snapshot
> version of Inno Setup that is not supported by the last release of
> innoextract.
>
> This diff updates the port to the latest snapshot of innoextract that
> specifically addresses the issues with GOG. Of note, this proposed
> update switches from the distfiles of the Homepage to the GitHub
> commit. I am usually against this where possible because of GH's track
> record of changing their on-the-fly tarball creation without notice. I
> looked at the relevant patch history since release to see if we could
> stay with 1.7 and add a patch, but the changes are too complex and
> would make next updates potentially confusing. Therefore, I propose to
> temporarily switch to GH_COMMIT. I placed a comment to switch back when
> possible.
>
> I think this is justified by GOG.com downloads being the main use case
> which is broken in the current state. This update fixes the extraction
> of the Ultimate Doom file.
>
> Is 1.7.20190228 acceptable as the update version number? Feb 28, 2019
> is the date of the GH commit, and the next release will likely be 1.8.
>
> I would like to take MAINTAINER of innoextract while here.
>
> ok?

yep, ok jca@

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE