[UPDATE] textproc/py-podcastparser for net/gpodder update

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[UPDATE] textproc/py-podcastparser for net/gpodder update

trondd-2
Small update to py-podcastparser used by gPodder.  Also convert to python3
and pull the release from git.

gPodder is the only user of py-podcastparser so instead of flavoring it,
I'm going python3 only as the new gPodder is also python3 only.  Correct
me if it's prefered to flavor this port instead.

Also with this update will be net/mygpoclient and net/gpodder.

Tim,


Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ Makefile 12 Jan 2018 01:32:20 -0000
@@ -2,26 +2,28 @@
 
 COMMENT= simple, fast and efficient podcast parser
 
-MODPY_EGG_VERSION= 0.6.1
+MODPY_EGG_VERSION= 0.6.2
 DISTNAME= podcastparser-${MODPY_EGG_VERSION}
 PKGNAME= py-${DISTNAME}
 CATEGORIES= textproc
 
-HOMEPAGE= http://gpodder.org/podcastparser/
+GH_ACCOUNT=             gpodder
+GH_PROJECT=             podcastparser
+GH_TAGNAME=             ${MODPY_EGG_VERSION}
 
 MAINTAINER= Tim Meunier <[hidden email]>
 
 # ISC
 PERMIT_PACKAGE_CDROM= Yes
 
-MASTER_SITES= ${HOMEPAGE}
-
 MODULES= lang/python
 
-BUILD_DEPENDS= textproc/py-sphinx
+MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
+
+BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
 
-TEST_DEPENDS= devel/py-nose \
- devel/py-coverage
+TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
+ devel/py-coverage${MODPY_FLAVOR}
 
 MAKE_FILE= makefile
 MAKE_ENV= PYTHON=${MODPY_BIN}
Index: distinfo
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ distinfo 12 Jan 2018 01:32:20 -0000
@@ -1,2 +1,2 @@
-SHA256 (podcastparser-0.6.1.tar.gz) = o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
-SIZE (podcastparser-0.6.1.tar.gz) = 18006
+SHA256 (podcastparser-0.6.2.tar.gz) = jmsz2I14v0yoCF4TX2xzYDkWmRZYC5wla4C2r1Ns55s=
+SIZE (podcastparser-0.6.2.tar.gz) = 22450
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 PLIST
--- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ pkg/PLIST 12 Jan 2018 01:32:20 -0000
@@ -1,5 +1,6 @@
 @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
+lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
 lib/python${MODPY_VERSION}/site-packages/podcastparser.py
-lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
 @man man/man1/podcastparser.1

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

trondd-2
On Fri, January 12, 2018 6:08 pm, trondd wrote:

> Small update to py-podcastparser used by gPodder.  Also convert to python3
> and pull the release from git.
>
> gPodder is the only user of py-podcastparser so instead of flavoring it,
> I'm going python3 only as the new gPodder is also python3 only.  Correct
> me if it's prefered to flavor this port instead.
>
> Also with this update will be net/mygpoclient and net/gpodder.
>
> Tim,
>

Bumping for feedback on these.  It's a few ports upgrading together.

Tim.

>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ Makefile 12 Jan 2018 01:32:20 -0000
> @@ -2,26 +2,28 @@
>
>  COMMENT= simple, fast and efficient podcast parser
>
> -MODPY_EGG_VERSION= 0.6.1
> +MODPY_EGG_VERSION= 0.6.2
>  DISTNAME= podcastparser-${MODPY_EGG_VERSION}
>  PKGNAME= py-${DISTNAME}
>  CATEGORIES= textproc
>
> -HOMEPAGE= http://gpodder.org/podcastparser/
> +GH_ACCOUNT=             gpodder
> +GH_PROJECT=             podcastparser
> +GH_TAGNAME=             ${MODPY_EGG_VERSION}
>
>  MAINTAINER= Tim Meunier <[hidden email]>
>
>  # ISC
>  PERMIT_PACKAGE_CDROM= Yes
>
> -MASTER_SITES= ${HOMEPAGE}
> -
>  MODULES= lang/python
>
> -BUILD_DEPENDS= textproc/py-sphinx
> +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
> +
> +BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
>
> -TEST_DEPENDS= devel/py-nose \
> - devel/py-coverage
> +TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
> + devel/py-coverage${MODPY_FLAVOR}
>
>  MAKE_FILE= makefile
>  MAKE_ENV= PYTHON=${MODPY_BIN}
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ distinfo 12 Jan 2018 01:32:20 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (podcastparser-0.6.1.tar.gz) =
> o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
> -SIZE (podcastparser-0.6.1.tar.gz) = 18006
> +SHA256 (podcastparser-0.6.2.tar.gz) =
> jmsz2I14v0yoCF4TX2xzYDkWmRZYC5wla4C2r1Ns55s=
> +SIZE (podcastparser-0.6.2.tar.gz) = 22450
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ pkg/PLIST 12 Jan 2018 01:32:20 -0000
> @@ -1,5 +1,6 @@
>  @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
> +lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
> +lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
>  lib/python${MODPY_VERSION}/site-packages/podcastparser.py
> -lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
>  @man man/man1/podcastparser.1
>


Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

trondd-2
"trondd" <[hidden email]> wrote:

> On Fri, January 12, 2018 6:08 pm, trondd wrote:
> > Small update to py-podcastparser used by gPodder.  Also convert to python3
> > and pull the release from git.
> >
> > gPodder is the only user of py-podcastparser so instead of flavoring it,
> > I'm going python3 only as the new gPodder is also python3 only.  Correct
> > me if it's prefered to flavor this port instead.
> >
> > Also with this update will be net/mygpoclient and net/gpodder.
> >
> > Tim,
> >
>

Reposting using MODPY_PI to pull the package from PyPi instead of GitHub.

Tim.


Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ Makefile 26 Jan 2018 00:58:16 -0000
@@ -2,32 +2,32 @@
 
 COMMENT= simple, fast and efficient podcast parser
 
-MODPY_EGG_VERSION= 0.6.1
+MODPY_EGG_VERSION= 0.6.2
 DISTNAME= podcastparser-${MODPY_EGG_VERSION}
 PKGNAME= py-${DISTNAME}
 CATEGORIES= textproc
 
-HOMEPAGE= http://gpodder.org/podcastparser/
-
 MAINTAINER= Tim Meunier <[hidden email]>
 
 # ISC
 PERMIT_PACKAGE_CDROM= Yes
 
-MASTER_SITES= ${HOMEPAGE}
-
 MODULES= lang/python
 
-BUILD_DEPENDS= textproc/py-sphinx
+MODPY_PI= Yes
+MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
+
+BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
 
-TEST_DEPENDS= devel/py-nose \
- devel/py-coverage
+TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
+ devel/py-coverage${MODPY_FLAVOR}
 
 MAKE_FILE= makefile
 MAKE_ENV= PYTHON=${MODPY_BIN}
 
 post-build:
- cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
+ cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man \
+ SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
 
 post-install:
  ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
Index: distinfo
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ distinfo 26 Jan 2018 00:58:16 -0000
@@ -1,2 +1,2 @@
-SHA256 (podcastparser-0.6.1.tar.gz) = o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
-SIZE (podcastparser-0.6.1.tar.gz) = 18006
+SHA256 (podcastparser-0.6.2.tar.gz) = i5FSJMAPK/JIETn4C/Nl7SB0KjkH9DdxHJawqGqHiWg=
+SIZE (podcastparser-0.6.2.tar.gz) = 21871
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 PLIST
--- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ pkg/PLIST 26 Jan 2018 00:58:16 -0000
@@ -1,5 +1,6 @@
 @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
+lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
 lib/python${MODPY_VERSION}/site-packages/podcastparser.py
-lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
 @man man/man1/podcastparser.1

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

Daniel Jakots-3
On Thu, 25 Jan 2018 20:06:29 -0500, trondd <[hidden email]>
wrote:

> +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}

As it's a library and the ports name is py- prefixed, we can easily go
with a flavour which is what our policy is :)
Any comment?

Cheers,
Daniel

Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ Makefile 30 Jan 2018 03:33:59 -0000
@@ -2,32 +2,34 @@
 
 COMMENT= simple, fast and efficient podcast parser
 
-MODPY_EGG_VERSION= 0.6.1
+MODPY_EGG_VERSION= 0.6.2
 DISTNAME= podcastparser-${MODPY_EGG_VERSION}
 PKGNAME= py-${DISTNAME}
 CATEGORIES= textproc
 
-HOMEPAGE= http://gpodder.org/podcastparser/
-
 MAINTAINER= Tim Meunier <[hidden email]>
 
 # ISC
 PERMIT_PACKAGE_CDROM= Yes
 
-MASTER_SITES= ${HOMEPAGE}
-
 MODULES= lang/python
 
-BUILD_DEPENDS= textproc/py-sphinx
+MODPY_PI= Yes
+
+BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
+
+TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
+ devel/py-coverage${MODPY_FLAVOR}
 
-TEST_DEPENDS= devel/py-nose \
- devel/py-coverage
+FLAVORS= python3
+FLAVOR?=
 
 MAKE_FILE= makefile
 MAKE_ENV= PYTHON=${MODPY_BIN}
 
 post-build:
- cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
+ cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man \
+ SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
 
 post-install:
  ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
Index: distinfo
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ distinfo 30 Jan 2018 03:33:59 -0000
@@ -1,2 +1,2 @@
-SHA256 (podcastparser-0.6.1.tar.gz) = o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
-SIZE (podcastparser-0.6.1.tar.gz) = 18006
+SHA256 (podcastparser-0.6.2.tar.gz) = i5FSJMAPK/JIETn4C/Nl7SB0KjkH9DdxHJawqGqHiWg=
+SIZE (podcastparser-0.6.2.tar.gz) = 21871
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 PLIST
--- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ pkg/PLIST 30 Jan 2018 03:33:59 -0000
@@ -1,5 +1,6 @@
 @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
 lib/python${MODPY_VERSION}/site-packages/podcastparser.py
-lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
 @man man/man1/podcastparser.1

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

trondd-2
Daniel Jakots <[hidden email]> wrote:

> On Thu, 25 Jan 2018 20:06:29 -0500, trondd <[hidden email]>
> wrote:
>
> > +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
>
> As it's a library and the ports name is py- prefixed, we can easily go
> with a flavour which is what our policy is :)
> Any comment?

Thanks.  That was one of my questions.  This is good, except for
disambiguating the man page filename.

Tim.

Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ Makefile 30 Jan 2018 23:28:59 -0000
@@ -2,34 +2,37 @@
 
 COMMENT= simple, fast and efficient podcast parser
 
-MODPY_EGG_VERSION= 0.6.1
+MODPY_EGG_VERSION= 0.6.2
 DISTNAME= podcastparser-${MODPY_EGG_VERSION}
 PKGNAME= py-${DISTNAME}
 CATEGORIES= textproc
 
-HOMEPAGE= http://gpodder.org/podcastparser/
-
 MAINTAINER= Tim Meunier <[hidden email]>
 
 # ISC
 PERMIT_PACKAGE_CDROM= Yes
 
-MASTER_SITES= ${HOMEPAGE}
-
 MODULES= lang/python
 
-BUILD_DEPENDS= textproc/py-sphinx
+MODPY_PI= Yes
+
+BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
+
+TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
+ devel/py-coverage${MODPY_FLAVOR}
 
-TEST_DEPENDS= devel/py-nose \
- devel/py-coverage
+FLAVORS= python3
+FLAVOR?=
 
 MAKE_FILE= makefile
 MAKE_ENV= PYTHON=${MODPY_BIN}
 
 post-build:
- cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
+ cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man \
+ SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
 
 post-install:
- ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
+ ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/podcastparser.1 \
+ ${PREFIX}/man/man1/podcastparser${MODPY_BIN_SUFFIX}.1
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ distinfo 30 Jan 2018 23:28:59 -0000
@@ -1,2 +1,2 @@
-SHA256 (podcastparser-0.6.1.tar.gz) = o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
-SIZE (podcastparser-0.6.1.tar.gz) = 18006
+SHA256 (podcastparser-0.6.2.tar.gz) = i5FSJMAPK/JIETn4C/Nl7SB0KjkH9DdxHJawqGqHiWg=
+SIZE (podcastparser-0.6.2.tar.gz) = 21871
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 PLIST
--- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ pkg/PLIST 30 Jan 2018 23:28:59 -0000
@@ -1,5 +1,6 @@
 @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
+lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
 lib/python${MODPY_VERSION}/site-packages/podcastparser.py
-lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
-@man man/man1/podcastparser.1
+@man man/man1/podcastparser${MODPY_BIN_SUFFIX}.1

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

Klemens Nanni
On Tue, Jan 30, 2018 at 06:37:13PM -0500, trondd wrote:

> Daniel Jakots <[hidden email]> wrote:
>
> > On Thu, 25 Jan 2018 20:06:29 -0500, trondd <[hidden email]>
> > wrote:
> >
> > > +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
> >
> > As it's a library and the ports name is py- prefixed, we can easily go
> > with a flavour which is what our policy is :)
> > Any comment?
>
> Thanks.  That was one of my questions.  This is good, except for
> disambiguating the man page filename.
>
> Tim.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ Makefile 30 Jan 2018 23:28:59 -0000
> @@ -2,34 +2,37 @@
>  
>  COMMENT= simple, fast and efficient podcast parser
>  
> -MODPY_EGG_VERSION= 0.6.1
> +MODPY_EGG_VERSION= 0.6.2
>  DISTNAME= podcastparser-${MODPY_EGG_VERSION}
>  PKGNAME= py-${DISTNAME}
>  CATEGORIES= textproc
>  
> -HOMEPAGE= http://gpodder.org/podcastparser/
> -
>  MAINTAINER= Tim Meunier <[hidden email]>
>  
>  # ISC
>  PERMIT_PACKAGE_CDROM= Yes
>  
> -MASTER_SITES= ${HOMEPAGE}
> -
>  MODULES= lang/python
>  
> -BUILD_DEPENDS= textproc/py-sphinx
> +MODPY_PI= Yes
> +
> +BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
> +
> +TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
> + devel/py-coverage${MODPY_FLAVOR}
>  
> -TEST_DEPENDS= devel/py-nose \
> - devel/py-coverage
> +FLAVORS= python3
> +FLAVOR?=
>  
>  MAKE_FILE= makefile
>  MAKE_ENV= PYTHON=${MODPY_BIN}
>  
>  post-build:
> - cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
> + cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man \
> + SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
>  
>  post-install:
> - ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
> + ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/podcastparser.1 \
> + ${PREFIX}/man/man1/podcastparser${MODPY_BIN_SUFFIX}.1
This can be simplified using ALL_TARGET, see below an updated diff for
Makefile only as I haven't tested all of it yet.

Index: Makefile
===================================================================
RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 Makefile
--- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
+++ Makefile 31 Jan 2018 15:05:15 -0000
@@ -2,34 +2,35 @@
 
 COMMENT= simple, fast and efficient podcast parser
 
-MODPY_EGG_VERSION= 0.6.1
+MODPY_EGG_VERSION= 0.6.2
 DISTNAME= podcastparser-${MODPY_EGG_VERSION}
 PKGNAME= py-${DISTNAME}
 CATEGORIES= textproc
 
-HOMEPAGE= http://gpodder.org/podcastparser/
-
 MAINTAINER= Tim Meunier <[hidden email]>
 
 # ISC
 PERMIT_PACKAGE_CDROM= Yes
 
-MASTER_SITES= ${HOMEPAGE}
-
 MODULES= lang/python
 
-BUILD_DEPENDS= textproc/py-sphinx
+MODPY_PI= Yes
+
+BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
+
+TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
+ devel/py-coverage${MODPY_FLAVOR}
 
-TEST_DEPENDS= devel/py-nose \
- devel/py-coverage
+FLAVORS= python3
+FLAVOR?=
 
 MAKE_FILE= makefile
-MAKE_ENV= PYTHON=${MODPY_BIN}
+MAKE_ENV= PYTHON=${MODPY_BIN} \
+ SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
 
-post-build:
- cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
+ALL_TARGET= all man
 
 post-install:
- ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
+ mv ${PREFIX}/man/man1/podcastparser{,${MODPY_BIN_SUFFIX}}.1
 
 .include <bsd.port.mk>

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

Klemens Nanni
In reply to this post by trondd-2
On Tue, Jan 30, 2018 at 06:37:13PM -0500, trondd wrote:

> Daniel Jakots <[hidden email]> wrote:
>
> > On Thu, 25 Jan 2018 20:06:29 -0500, trondd <[hidden email]>
> > wrote:
> >
> > > +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
> >
> > As it's a library and the ports name is py- prefixed, we can easily go
> > with a flavour which is what our policy is :)
> > Any comment?
>
> Thanks.  That was one of my questions.  This is good, except for
> disambiguating the man page filename.
>
> Tim.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ Makefile 30 Jan 2018 23:28:59 -0000
> @@ -2,34 +2,37 @@
>  
>  COMMENT= simple, fast and efficient podcast parser
>  
> -MODPY_EGG_VERSION= 0.6.1
> +MODPY_EGG_VERSION= 0.6.2
>  DISTNAME= podcastparser-${MODPY_EGG_VERSION}
>  PKGNAME= py-${DISTNAME}
>  CATEGORIES= textproc
>  
> -HOMEPAGE= http://gpodder.org/podcastparser/
> -
>  MAINTAINER= Tim Meunier <[hidden email]>
>  
>  # ISC
>  PERMIT_PACKAGE_CDROM= Yes
>  
> -MASTER_SITES= ${HOMEPAGE}
> -
>  MODULES= lang/python
>  
> -BUILD_DEPENDS= textproc/py-sphinx
> +MODPY_PI= Yes
> +
> +BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
> +
> +TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
> + devel/py-coverage${MODPY_FLAVOR}
>  
> -TEST_DEPENDS= devel/py-nose \
> - devel/py-coverage
> +FLAVORS= python3
> +FLAVOR?=
>  
>  MAKE_FILE= makefile
>  MAKE_ENV= PYTHON=${MODPY_BIN}
>  
>  post-build:
> - cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
> + cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man \
> + SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
>  
>  post-install:
> - ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
> + ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/podcastparser.1 \
> + ${PREFIX}/man/man1/podcastparser${MODPY_BIN_SUFFIX}.1
>  
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ distinfo 30 Jan 2018 23:28:59 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (podcastparser-0.6.1.tar.gz) = o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
> -SIZE (podcastparser-0.6.1.tar.gz) = 18006
> +SHA256 (podcastparser-0.6.2.tar.gz) = i5FSJMAPK/JIETn4C/Nl7SB0KjkH9DdxHJawqGqHiWg=
> +SIZE (podcastparser-0.6.2.tar.gz) = 21871
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ pkg/PLIST 30 Jan 2018 23:28:59 -0000
> @@ -1,5 +1,6 @@
>  @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
> +lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
>  lib/python${MODPY_VERSION}/site-packages/podcastparser.py
> -lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
> -@man man/man1/podcastparser.1
> +@man man/man1/podcastparser${MODPY_BIN_SUFFIX}.1
>
Please disregard my diff, yours is completely fine.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

trondd-2
In reply to this post by trondd-2
On Tue, January 30, 2018 6:37 pm, trondd wrote:

> Daniel Jakots <[hidden email]> wrote:
>
>> On Thu, 25 Jan 2018 20:06:29 -0500, trondd <[hidden email]>
>> wrote:
>>
>> > +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
>>
>> As it's a library and the ports name is py- prefixed, we can easily go
>> with a flavour which is what our policy is :)
>> Any comment?
>
> Thanks.  That was one of my questions.  This is good, except for
> disambiguating the man page filename.
>
> Tim.
>

Ping.  Anyone else have feedback?

Tim.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- Makefile 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ Makefile 30 Jan 2018 23:28:59 -0000
> @@ -2,34 +2,37 @@
>
>  COMMENT= simple, fast and efficient podcast parser
>
> -MODPY_EGG_VERSION= 0.6.1
> +MODPY_EGG_VERSION= 0.6.2
>  DISTNAME= podcastparser-${MODPY_EGG_VERSION}
>  PKGNAME= py-${DISTNAME}
>  CATEGORIES= textproc
>
> -HOMEPAGE= http://gpodder.org/podcastparser/
> -
>  MAINTAINER= Tim Meunier <[hidden email]>
>
>  # ISC
>  PERMIT_PACKAGE_CDROM= Yes
>
> -MASTER_SITES= ${HOMEPAGE}
> -
>  MODULES= lang/python
>
> -BUILD_DEPENDS= textproc/py-sphinx
> +MODPY_PI= Yes
> +
> +BUILD_DEPENDS= textproc/py-sphinx${MODPY_FLAVOR}
> +
> +TEST_DEPENDS= devel/py-nose${MODPY_FLAVOR} \
> + devel/py-coverage${MODPY_FLAVOR}
>
> -TEST_DEPENDS= devel/py-nose \
> - devel/py-coverage
> +FLAVORS= python3
> +FLAVOR?=
>
>  MAKE_FILE= makefile
>  MAKE_ENV= PYTHON=${MODPY_BIN}
>
>  post-build:
> - cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man
> + cd ${WRKSRC}/doc && ${MAKE_ENV} ${MAKE_PROGRAM} man \
> + SPHINXBUILD=sphinx-build${MODPY_BIN_SUFFIX}
>
>  post-install:
> - ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/*.1 ${PREFIX}/man/man1/
> + ${INSTALL_DATA} ${WRKSRC}/doc/_build/man/podcastparser.1 \
> + ${PREFIX}/man/man1/podcastparser${MODPY_BIN_SUFFIX}.1
>
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ distinfo 30 Jan 2018 23:28:59 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (podcastparser-0.6.1.tar.gz) =
> o0eQqUC8WC99Y4jEO2mvchRDK6G9fUANGZxjvS2hPRQ=
> -SIZE (podcastparser-0.6.1.tar.gz) = 18006
> +SHA256 (podcastparser-0.6.2.tar.gz) =
> i5FSJMAPK/JIETn4C/Nl7SB0KjkH9DdxHJawqGqHiWg=
> +SIZE (podcastparser-0.6.2.tar.gz) = 21871
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/textproc/py-podcastparser/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 PLIST
> --- pkg/PLIST 18 Apr 2017 02:13:26 -0000 1.1.1.1
> +++ pkg/PLIST 30 Jan 2018 23:28:59 -0000
> @@ -1,5 +1,6 @@
>  @comment $OpenBSD: PLIST,v 1.1.1.1 2017/04/18 02:13:26 danj Exp $
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}/
> +lib/python${MODPY_VERSION}/site-packages/${MODPY_PYCACHE}podcastparser.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/podcastparser-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info
>  lib/python${MODPY_VERSION}/site-packages/podcastparser.py
> -lib/python${MODPY_VERSION}/site-packages/podcastparser.pyc
> -@man man/man1/podcastparser.1
> +@man man/man1/podcastparser${MODPY_BIN_SUFFIX}.1
>


Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] textproc/py-podcastparser for net/gpodder update

Daniel Jakots-3
In reply to this post by trondd-2
On Tue, 30 Jan 2018 18:37:13 -0500, trondd <[hidden email]>
wrote:

> Daniel Jakots <[hidden email]> wrote:
>
> > On Thu, 25 Jan 2018 20:06:29 -0500, trondd <[hidden email]>
> > wrote:
> >  
> > > +MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}  
> >
> > As it's a library and the ports name is py- prefixed, we can easily
> > go with a flavour which is what our policy is :)
> > Any comment?  
>
> Thanks.  That was one of my questions.  This is good, except for
> disambiguating the man page filename.

Indeed nice catch! I've committed your diff, thanks!