[UPDATE] productivity/mcds to version 1.6

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[UPDATE] productivity/mcds to version 1.6

Timothy Brown
Hi all,

I know I submitted version 1.4 not too long ago, terribly sorry
for creating more work. I noticed that diff wasn't applied, so
I'm hoping this update to 1.6 can replace it.

As with any updates I introduced a couple of bugs, hence the jump
to version 1.6.

Diff is attached.

Regards
Tim


mcds.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] productivity/mcds to version 1.6

Stuart Henderson
On 2020/01/16 15:55, Timothy Brown wrote:

> Hi all,
>
> I know I submitted version 1.4 not too long ago, terribly sorry
> for creating more work. I noticed that diff wasn't applied, so
> I'm hoping this update to 1.6 can replace it.
>
> As with any updates I introduced a couple of bugs, hence the jump
> to version 1.6.
>
> Diff is attached.

Adding pledge, especially on something pulling in various libraries,
turns it from a straightforward update to something that needs a lot
more careful review so it's likely to take longer than usual.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/productivity/mcds/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile 12 Jul 2019 20:48:59 -0000 1.3
> +++ Makefile 16 Jan 2020 22:46:26 -0000
> @@ -2,23 +2,24 @@
>  
>  COMMENT = tty-based carddav search tool

Reading through the ports diff it looks OK, one nit though,
since you're changing caps in DESCR, do you want to change it in
COMMENT too?

>  
> -V = 0.9
> +V = 1.6
>  DISTNAME = mcds-${V}
>  CATEGORIES = productivity
> -REVISION = 0
>  
>  MAINTAINER = Timothy Brown <[hidden email]>
>  
>  # GPLv3+
>  PERMIT_PACKAGE = Yes
>  
> -WANTLIB = c curl iconv intl xml2
> +# uses pledge()
> +WANTLIB = assuan c curl gpg-error gpgme iconv intl xml2
>  
>  MASTER_SITES = https://github.com/t-brown/mcds/releases/download/v${V}/
>  
>  LIB_DEPENDS = devel/gettext,-runtime \
>   net/curl \
> - textproc/libxml
> + textproc/libxml \
> + security/gpgme
>  
>  CONFIGURE_STYLE = gnu
>  
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/productivity/mcds/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 distinfo
> --- distinfo 2 May 2019 15:52:58 -0000 1.1.1.1
> +++ distinfo 16 Jan 2020 22:46:26 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (mcds-0.9.tar.gz) = p+H8Q94kiHDDo/pV570uCXZki5YnyC41tUDx8HgARKc=
> -SIZE (mcds-0.9.tar.gz) = 194620
> +SHA256 (mcds-1.6.tar.gz) = HLSkhSxy00Y/Ft5XQ1FVqwZe1UJrJifDok080B1QXEM=
> +SIZE (mcds-1.6.tar.gz) = 203185
> Index: pkg/DESCR
> ===================================================================
> RCS file: /cvs/ports/productivity/mcds/pkg/DESCR,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 DESCR
> --- pkg/DESCR 2 May 2019 15:52:58 -0000 1.1.1.1
> +++ pkg/DESCR 16 Jan 2020 22:46:26 -0000
> @@ -1,2 +1,2 @@
>  Mcds is a command line tool primarily used as a search query plugin for mutt
> -to query a carddav server.
> +to query a CardDav server.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] productivity/mcds to version 1.6

Timothy Brown
On Fri, Jan 17, 2020 at 03:09:20PM +0000, Stuart Henderson wrote:
>
> Adding pledge, especially on something pulling in various libraries,
> turns it from a straightforward update to something that needs a lot
> more careful review so it's likely to take longer than usual.
>

Sure thing. Please let me know if there is anything I can do to help.
I see Landry commit the diff earlier this morning.

>
> Reading through the ports diff it looks OK, one nit though,
> since you're changing caps in DESCR, do you want to change it in
> COMMENT too?
>

Can do. Here's a diff with the change.

Tim

mcds.diff (547 bytes) Download Attachment