[UPDATE] net/gpodder -> 3.10.3

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[UPDATE] net/gpodder -> 3.10.3

trondd-2
Update to gPodder

New features

    #402 extension to run a command on download
    #431 update sonos extension to use soco >= 0.7 API
    #442 gpo command for downloading/deleting a single episode
    #384 YouTube feeds without API key

Bug fixes

    #369 theme-aware shownote color in webview
    #375 send to bluetooth device works again
    #399 download from URL with colon in path (or other allowed characters)
    no exception when no website link in feed
    #340 limit download UI fixes
    #151 unchecked 'download limit' really means 16 download limit
    #458 fix unable to drag and drop from episode list
    #459 fix downloaded filenames based on content-disposition
    #420 don't leak open file descriptors (was preventing rename on download on Windows)

Translations

    Hungarian translation added
    French translation updated

Tim.

Index: Makefile
===================================================================
RCS file: /cvs/ports/net/gpodder/Makefile,v
retrieving revision 1.13
diff -u -p -r1.13 Makefile
--- Makefile 20 Feb 2018 03:44:32 -0000 1.13
+++ Makefile 26 Jun 2018 23:46:39 -0000
@@ -2,7 +2,7 @@
 
 COMMENT= media aggregator and podcast client
 
-MODPY_EGG_VERSION= 3.10.1
+MODPY_EGG_VERSION= 3.10.3
 
 GH_ACCOUNT= gpodder
 GH_PROJECT= gpodder
Index: distinfo
===================================================================
RCS file: /cvs/ports/net/gpodder/distinfo,v
retrieving revision 1.5
diff -u -p -r1.5 distinfo
--- distinfo 20 Feb 2018 03:44:32 -0000 1.5
+++ distinfo 26 Jun 2018 23:46:39 -0000
@@ -1,2 +1,2 @@
-SHA256 (gpodder-3.10.1.tar.gz) = zT9lFG+iAsKGHY8KL6ISMjgwxsQ3onL2+IpeA1gengs=
-SIZE (gpodder-3.10.1.tar.gz) = 883011
+SHA256 (gpodder-3.10.3.tar.gz) = pTsjxgWzqScBrtPjGPBpWuLk3humRpIzfgqPdyU+u7E=
+SIZE (gpodder-3.10.3.tar.gz) = 980333
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/net/gpodder/pkg/PLIST,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST
--- pkg/PLIST 20 Feb 2018 03:44:32 -0000 1.5
+++ pkg/PLIST 26 Jun 2018 23:46:39 -0000
@@ -8,6 +8,8 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}/
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}build_info.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
+lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}build_info.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}common.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}common.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}config.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
@@ -58,10 +60,15 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}unittests.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}util.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}util.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32ctypes.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
+lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32ctypes.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32locale.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
+lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32locale.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}vimeo.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}vimeo.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}youtube.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
 lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}youtube.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/gpodder/build_info.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/common.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/config.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/core.py
@@ -187,6 +194,8 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/gpodder/test/model.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/unittests.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/util.py
+lib/python${MODPY_VERSION}/site-packages/gpodder/utilwin32ctypes.py
+lib/python${MODPY_VERSION}/site-packages/gpodder/utilwin32locale.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/vimeo.py
 lib/python${MODPY_VERSION}/site-packages/gpodder/youtube.py
 @man man/man1/gpo.1
@@ -202,6 +211,7 @@ share/gpodder/examples/hello_world.py
 share/gpodder/extensions/
 share/gpodder/extensions/${MODPY_PYCACHE}/
 share/gpodder/extensions/${MODPY_PYCACHE}audio_converter.${MODPY_PYC_MAGIC_TAG}pyc
+share/gpodder/extensions/${MODPY_PYCACHE}command_on_download.${MODPY_PYC_MAGIC_TAG}pyc
 share/gpodder/extensions/${MODPY_PYCACHE}concatenate_videos.${MODPY_PYC_MAGIC_TAG}pyc
 share/gpodder/extensions/${MODPY_PYCACHE}enqueue_in_mediaplayer.${MODPY_PYC_MAGIC_TAG}pyc
 share/gpodder/extensions/${MODPY_PYCACHE}episode_website_context_menu.${MODPY_PYC_MAGIC_TAG}pyc
@@ -224,6 +234,7 @@ share/gpodder/extensions/${MODPY_PYCACHE
 share/gpodder/extensions/${MODPY_PYCACHE}update_feeds_on_startup.${MODPY_PYC_MAGIC_TAG}pyc
 share/gpodder/extensions/${MODPY_PYCACHE}video_converter.${MODPY_PYC_MAGIC_TAG}pyc
 share/gpodder/extensions/audio_converter.py
+share/gpodder/extensions/command_on_download.py
 share/gpodder/extensions/concatenate_videos.py
 share/gpodder/extensions/enqueue_in_mediaplayer.py
 share/gpodder/extensions/episode_website_context_menu.py
@@ -307,6 +318,7 @@ share/locale/fi/LC_MESSAGES/gpodder.mo
 share/locale/fr/LC_MESSAGES/gpodder.mo
 share/locale/gl/LC_MESSAGES/gpodder.mo
 share/locale/he/LC_MESSAGES/gpodder.mo
+share/locale/hu/LC_MESSAGES/gpodder.mo
 share/locale/id_ID/
 share/locale/id_ID/LC_MESSAGES/
 share/locale/id_ID/LC_MESSAGES/gpodder.mo

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] net/gpodder -> 3.10.3

Klemens Nanni-2
Looks good diff-wise, although it fails to start (presumably because
dbus is not running); I couldn't find information in the port telling
me that it needs to be running.

$ gpodder
1530127951.459232 [gpodder.log] ERROR: Uncaught exception: Traceback (most recent call last):
  File "/usr/local/bin/gpodder", line 158, in <module>
    main()
  File "/usr/local/bin/gpodder", line 125, in main
    session_bus = dbus.SessionBus()
  File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 211, in __new__
    mainloop=mainloop)
  File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 100, in __new__
    bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
  File "/usr/local/lib/python3.6/site-packages/dbus/bus.py", line 122, in __new__
    bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported: Using X11 for dbus-daemon autolaunch was disabled at compile time, set your DBUS_SESSION_BUS_ADDRESS instead

Traceback (most recent call last):
  File "/usr/local/bin/gpodder", line 158, in <module>
    main()
  File "/usr/local/bin/gpodder", line 125, in main
    session_bus = dbus.SessionBus()
  File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 211, in __new__
    mainloop=mainloop)
  File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 100, in __new__
    bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
  File "/usr/local/lib/python3.6/site-packages/dbus/bus.py", line 122, in __new__
    bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported: Using X11 for dbus-daemon autolaunch was disabled at compile time, set your DBUS_SESSION_BUS_ADDRESS instead

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] net/gpodder -> 3.10.3

Landry Breuil-5
On Wed, Jun 27, 2018 at 09:35:56PM +0200, Klemens Nanni wrote:
> Looks good diff-wise, although it fails to start (presumably because
> dbus is not running); I couldn't find information in the port telling
> me that it needs to be running.

The ecosystem is not really ready for not having dbus, as before the
failure was silently hidden behind autolaunching.

Generally, i'd advise anyone not running dbus on purpose for whatever
reason to set DBUS_SESSION_BUS_ADDRESS to a bogus value, and hope that
applications gracefully handle a broken bus. Or run a session dbus.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] net/gpodder -> 3.10.3

Stuart Henderson
In reply to this post by Klemens Nanni-2
On 2018/06/27 21:35, Klemens Nanni wrote:

> Looks good diff-wise, although it fails to start (presumably because
> dbus is not running); I couldn't find information in the port telling
> me that it needs to be running.
>
> $ gpodder
> 1530127951.459232 [gpodder.log] ERROR: Uncaught exception: Traceback (most recent call last):
>   File "/usr/local/bin/gpodder", line 158, in <module>
>     main()
>   File "/usr/local/bin/gpodder", line 125, in main
>     session_bus = dbus.SessionBus()
>   File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 211, in __new__
>     mainloop=mainloop)
>   File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 100, in __new__
>     bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
>   File "/usr/local/lib/python3.6/site-packages/dbus/bus.py", line 122, in __new__
>     bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
> dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported: Using X11 for dbus-daemon autolaunch was disabled at compile time, set your DBUS_SESSION_BUS_ADDRESS instead

This is unlikely to be new with the update - autolaunch was disabled
because firefox.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] net/gpodder -> 3.10.3

trondd-2
On Wed, June 27, 2018 5:25 pm, Stuart Henderson wrote:

> On 2018/06/27 21:35, Klemens Nanni wrote:
>> Looks good diff-wise, although it fails to start (presumably because
>> dbus is not running); I couldn't find information in the port telling
>> me that it needs to be running.
>>
>> $ gpodder
>> 1530127951.459232 [gpodder.log] ERROR: Uncaught exception: Traceback
>> (most recent call last):
>>   File "/usr/local/bin/gpodder", line 158, in <module>
>>     main()
>>   File "/usr/local/bin/gpodder", line 125, in main
>>     session_bus = dbus.SessionBus()
>>   File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 211,
>> in __new__
>>     mainloop=mainloop)
>>   File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 100,
>> in __new__
>>     bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
>>   File "/usr/local/lib/python3.6/site-packages/dbus/bus.py", line 122,
>> in __new__
>>     bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
>> dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported:
>> Using X11 for dbus-daemon autolaunch was disabled at compile time, set
>> your DBUS_SESSION_BUS_ADDRESS instead
>
> This is unlikely to be new with the update - autolaunch was disabled
> because firefox.
>

I feel like I did see this before updating and I think fixed it previously
because firefox.

Are we just adding a pkg-readme for all such ports?

Tim.

Reply | Threaded
Open this post in threaded view
|

dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Stuart Henderson
On 2018/06/27 22:22, Landry Breuil wrote:
> The ecosystem is not really ready for not having dbus, as before the
> failure was silently hidden behind autolaunching.
>
> Generally, i'd advise anyone not running dbus on purpose for whatever
> reason to set DBUS_SESSION_BUS_ADDRESS to a bogus value, and hope that
> applications gracefully handle a broken bus. Or run a session dbus.

it doesn't work in gpodder, I've tried a few bogus values, all fail ..

DBUS_SESSION_BUS_ADDRESS=unix:path=/tmp/daskasdjdkjaskdjask,guid=kasdkasdkasjkdjakdjask gpodder
DBUS_SESSION_BUS_ADDRESS=bogus gpodder
DBUS_SESSION_BUS_ADDRESS=bogus: gpodder
DBUS_SESSION_BUS_ADDRESS=tcp: gpodder
DBUS_SESSION_BUS_ADDRESS=tcp:port=12832 gpodder


On 2018/06/27 17:31, trondd wrote:

> On Wed, June 27, 2018 5:25 pm, Stuart Henderson wrote:
> > On 2018/06/27 21:35, Klemens Nanni wrote:
> >> Looks good diff-wise, although it fails to start (presumably because
> >> dbus is not running); I couldn't find information in the port telling
> >> me that it needs to be running.
> >>
> >> $ gpodder
> >> 1530127951.459232 [gpodder.log] ERROR: Uncaught exception: Traceback
> >> (most recent call last):
> >>   File "/usr/local/bin/gpodder", line 158, in <module>
> >>     main()
> >>   File "/usr/local/bin/gpodder", line 125, in main
> >>     session_bus = dbus.SessionBus()
> >>   File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 211,
> >> in __new__
> >>     mainloop=mainloop)
> >>   File "/usr/local/lib/python3.6/site-packages/dbus/_dbus.py", line 100,
> >> in __new__
> >>     bus = BusConnection.__new__(subclass, bus_type, mainloop=mainloop)
> >>   File "/usr/local/lib/python3.6/site-packages/dbus/bus.py", line 122,
> >> in __new__
> >>     bus = cls._new_for_bus(address_or_type, mainloop=mainloop)
> >> dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported:
> >> Using X11 for dbus-daemon autolaunch was disabled at compile time, set
> >> your DBUS_SESSION_BUS_ADDRESS instead
> >
> > This is unlikely to be new with the update - autolaunch was disabled
> > because firefox.
> >
>
> I feel like I did see this before updating and I think fixed it previously
> because firefox.
>
> Are we just adding a pkg-readme for all such ports?

tracking down all ports that might use dbus and adding a readme (and
keeping on top of this for future ports) seems pretty ridiculous..

the firefox problem is that it's autolaunching dbus from a process which
has pledged that it won't start processes. so people that were relying
on firefox autolaunching dbus (rather than starting it themselves e.g.
from .xsession) were getting crashes.

the workaround that was made was to change dbus to disable autolaunch,
but (as seen here) this causes problems for other ports.

landry, I know you hate wrapper scripts, but adding one for Firefox to
start dbus if needed and moving the dbus port back to autolaunch would
really seem a simple way to unbreak things (and I think probably a bit
more widely acceptable than "change /etc/X11/xenodm/Xsession to launch
dbus if present" would be ...)

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Sebastien Marie-3
On Thu, Jun 28, 2018 at 12:01:12AM +0100, Stuart Henderson wrote:

> On 2018/06/27 22:22, Landry Breuil wrote:
> > >> dbus.exceptions.DBusException: org.freedesktop.DBus.Error.NotSupported:
> > >> Using X11 for dbus-daemon autolaunch was disabled at compile time, set
> > >> your DBUS_SESSION_BUS_ADDRESS instead
> > >
> > > This is unlikely to be new with the update - autolaunch was disabled
> > > because firefox.
> > >
> >
> > I feel like I did see this before updating and I think fixed it previously
> > because firefox.
> >
> > Are we just adding a pkg-readme for all such ports?
>
> tracking down all ports that might use dbus and adding a readme (and
> keeping on top of this for future ports) seems pretty ridiculous..

I agree. But there is a difference between ports: some are *requiring*
dbus (like gpodder, I dunno why, but it will not run without dbus and
have code to check that) ; whereas some others doesn't bother if dbus
session isn't started.

> the firefox problem is that it's autolaunching dbus from a process which
> has pledged that it won't start processes. so people that were relying
> on firefox autolaunching dbus (rather than starting it themselves e.g.
> from .xsession) were getting crashes.
>
> the workaround that was made was to change dbus to disable autolaunch,
> but (as seen here) this causes problems for other ports.

for firefox, the problem was a bit more complex than expected. with
aja@, we look at dbus code, and disable autolaunch code. but several
libraries were involved in the case of firefox: if libddbus.so had code
for fork+exec "dbus-launch", libglib.so has too... so the configure
option on dbus ./configure script was only a partial fix, and glib
hasn't such possibility.

but except the pledge problem with fork+exec, firefox is able to work
well without dbus session.

> landry, I know you hate wrapper scripts, but adding one for Firefox to
> start dbus if needed and moving the dbus port back to autolaunch would
> really seem a simple way to unbreak things (and I think probably a bit
> more widely acceptable than "change /etc/X11/xenodm/Xsession to launch
> dbus if present" would be ...)

I think last patch on firefox workarounded efficiently fork+exec
problem (setting DBUS_SESSION_BUS_ADDRESS if not present). so no wrapper
script should be needed.

So reenabling autolaunch on dbus port is possible and should not impact
firefox.

On the other side, it only hides the underline problem of dbus session.
If I correctly understood have dbus-launch works, When a program starts
it at program level (opposite to Xsession level), the session is only
"local" to the program: only this particular program will speak with
this dbus daemon. And it could result on starting a dbus session per
program that could need it. I have already seen several dbus deamon
running because starting several firefox -no-remote.

The proper fix would be changing /etc/X11/xenodm/Xsession. But it should
be done in proper way. Personally I would be in favor of generic code to
load (shell sourcing) files in /etc/X11/xenodm/Xsession.d directory,
with mecanism a-la "rcctl enable" to know which files are explicitly
asked for inclusion.

So dbus port would provide a /etc/X11/xenodm/Xsession/dbus.script file,
and administrator would have to enable the inclusion of the file for
make it sourced by /etc/X11/xenodm/Xsession.d

thanks.
--
Sebastien Marie

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Antoine Jacoutot-7
In reply to this post by Stuart Henderson
On Thu, Jun 28, 2018 at 12:01:12AM +0100, Stuart Henderson wrote:

> On 2018/06/27 22:22, Landry Breuil wrote:
> > The ecosystem is not really ready for not having dbus, as before the
> > failure was silently hidden behind autolaunching.
> >
> > Generally, i'd advise anyone not running dbus on purpose for whatever
> > reason to set DBUS_SESSION_BUS_ADDRESS to a bogus value, and hope that
> > applications gracefully handle a broken bus. Or run a session dbus.
>
> it doesn't work in gpodder, I've tried a few bogus values, all fail ..
>
> DBUS_SESSION_BUS_ADDRESS=unix:path=/tmp/daskasdjdkjaskdjask,guid=kasdkasdkasjkdjakdjask gpodder
> DBUS_SESSION_BUS_ADDRESS=bogus gpodder
> DBUS_SESSION_BUS_ADDRESS=bogus: gpodder
> DBUS_SESSION_BUS_ADDRESS=tcp: gpodder
> DBUS_SESSION_BUS_ADDRESS=tcp:port=12832 gpodder

Disabling dbus autolaunch was committed early on purpose so that we can see the
implications. If we need to re-enable it for the time being until we have a
proper solution, I am not against it.
Adding pkg-readmes to all ports requiring a user dbus-session does *not* seem
like the right thing to do :-)

--
Antoine

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Stuart Henderson
In reply to this post by Sebastien Marie-3
On 2018/06/28 08:47, Sebastien Marie wrote:

>
> I think last patch on firefox workarounded efficiently fork+exec
> problem (setting DBUS_SESSION_BUS_ADDRESS if not present). so no wrapper
> script should be needed.
>
> So reenabling autolaunch on dbus port is possible and should not impact
> firefox.
>
> On the other side, it only hides the underline problem of dbus session.
> If I correctly understood have dbus-launch works, When a program starts
> it at program level (opposite to Xsession level), the session is only
> "local" to the program: only this particular program will speak with
> this dbus daemon. And it could result on starting a dbus session per
> program that could need it. I have already seen several dbus deamon
> running because starting several firefox -no-remote.

Even if we're going to make changes in Xsession I think we should
reenable autolaunch in dbus for now as there is too much hard-to-debug
breakage.

> The proper fix would be changing /etc/X11/xenodm/Xsession. But it should
> be done in proper way. Personally I would be in favor of generic code to
> load (shell sourcing) files in /etc/X11/xenodm/Xsession.d directory,
> with mecanism a-la "rcctl enable" to know which files are explicitly
> asked for inclusion.
>
> So dbus port would provide a /etc/X11/xenodm/Xsession/dbus.script file,
> and administrator would have to enable the inclusion of the file for
> make it sourced by /etc/X11/xenodm/Xsession.d

Anything that the administrator has to do themselves is going to result
in the same problem. If people were already following dbus' pkg-readme
then we wouldn't have had any problems with disabling autolaunch..

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Matthieu Herrb-7
In reply to this post by Sebastien Marie-3
On Thu, Jun 28, 2018 at 08:47:41AM +0200, Sebastien Marie wrote:
>
> The proper fix would be changing /etc/X11/xenodm/Xsession.

We've been there and have done that, and  we've backed that out.
for xinit see:
http://cvsweb.openbsd.org/cgi-bin/cvsweb/xenocara/app/xinit/xinitrc.cpp
(rev 1.9 and 1.13)
and for xdm see:
http://cvsweb.openbsd.org/cgi-bin/cvsweb/xenocara/app/xdm/config/Attic/Xsession.cpp
(rev 1.11 and 1.14)

> But it should
> be done in proper way. Personally I would be in favor of generic code to
> load (shell sourcing) files in /etc/X11/xenodm/Xsession.d directory,
> with mecanism a-la "rcctl enable" to know which files are explicitly
> asked for inclusion.
>

If the default is NO and the instructions on how to enable it
are specific to OpenBSD, I'm not sure if it will be useful.

--
Matthieu Herrb

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Antoine Jacoutot-7
In reply to this post by Stuart Henderson
On Mon, Jul 02, 2018 at 09:06:50AM +0100, Stuart Henderson wrote:

> On 2018/06/28 08:47, Sebastien Marie wrote:
> >
> > I think last patch on firefox workarounded efficiently fork+exec
> > problem (setting DBUS_SESSION_BUS_ADDRESS if not present). so no wrapper
> > script should be needed.
> >
> > So reenabling autolaunch on dbus port is possible and should not impact
> > firefox.
> >
> > On the other side, it only hides the underline problem of dbus session.
> > If I correctly understood have dbus-launch works, When a program starts
> > it at program level (opposite to Xsession level), the session is only
> > "local" to the program: only this particular program will speak with
> > this dbus daemon. And it could result on starting a dbus session per
> > program that could need it. I have already seen several dbus deamon
> > running because starting several firefox -no-remote.
>
> Even if we're going to make changes in Xsession I think we should
> reenable autolaunch in dbus for now as there is too much hard-to-debug
> breakage.

OK, I'll re-enable it for the time being then.

--
Antoine

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Kenneth R Westerback-2
On Mon, Jul 02, 2018 at 01:19:55PM +0200, Antoine Jacoutot wrote:

> On Mon, Jul 02, 2018 at 09:06:50AM +0100, Stuart Henderson wrote:
> > On 2018/06/28 08:47, Sebastien Marie wrote:
> > >
> > > I think last patch on firefox workarounded efficiently fork+exec
> > > problem (setting DBUS_SESSION_BUS_ADDRESS if not present). so no wrapper
> > > script should be needed.
> > >
> > > So reenabling autolaunch on dbus port is possible and should not impact
> > > firefox.
> > >
> > > On the other side, it only hides the underline problem of dbus session.
> > > If I correctly understood have dbus-launch works, When a program starts
> > > it at program level (opposite to Xsession level), the session is only
> > > "local" to the program: only this particular program will speak with
> > > this dbus daemon. And it could result on starting a dbus session per
> > > program that could need it. I have already seen several dbus deamon
> > > running because starting several firefox -no-remote.
> >
> > Even if we're going to make changes in Xsession I think we should
> > reenable autolaunch in dbus for now as there is too much hard-to-debug
> > breakage.
>
> OK, I'll re-enable it for the time being then.
>
> --
> Antoine
>

I suspect this is also behind 'emacsclient -a "" -c' not doing what I
expected recently. i.e. starting up an emacs daemon if one is not
already running.

.... Ken

Reply | Threaded
Open this post in threaded view
|

Re: dbus autolaunch (was Re: [UPDATE] net/gpodder -> 3.10.3)

Sebastien Marie-3
In reply to this post by Antoine Jacoutot-7
On Mon, Jul 02, 2018 at 01:19:55PM +0200, Antoine Jacoutot wrote:

> On Mon, Jul 02, 2018 at 09:06:50AM +0100, Stuart Henderson wrote:
> > On 2018/06/28 08:47, Sebastien Marie wrote:
> > >
> > > I think last patch on firefox workarounded efficiently fork+exec
> > > problem (setting DBUS_SESSION_BUS_ADDRESS if not present). so no wrapper
> > > script should be needed.
> > >
> > > So reenabling autolaunch on dbus port is possible and should not impact
> > > firefox.
> > >
> > > On the other side, it only hides the underline problem of dbus session.
> > > If I correctly understood have dbus-launch works, When a program starts
> > > it at program level (opposite to Xsession level), the session is only
> > > "local" to the program: only this particular program will speak with
> > > this dbus daemon. And it could result on starting a dbus session per
> > > program that could need it. I have already seen several dbus deamon
> > > running because starting several firefox -no-remote.
> >
> > Even if we're going to make changes in Xsession I think we should
> > reenable autolaunch in dbus for now as there is too much hard-to-debug
> > breakage.
>
> OK, I'll re-enable it for the time being then.

I'm fine with re-enabling it too.
--
Sebastien Marie

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] net/gpodder -> 3.10.3

trondd-2
In reply to this post by trondd-2
Poke.

With dbus autolaunch re-enabled, gpodder works again without any
additional configuration.


On Tue, June 26, 2018 8:10 pm, trondd wrote:

> Update to gPodder
>
> New features
>
>     #402 extension to run a command on download
>     #431 update sonos extension to use soco >= 0.7 API
>     #442 gpo command for downloading/deleting a single episode
>     #384 YouTube feeds without API key
>
> Bug fixes
>
>     #369 theme-aware shownote color in webview
>     #375 send to bluetooth device works again
>     #399 download from URL with colon in path (or other allowed
> characters)
>     no exception when no website link in feed
>     #340 limit download UI fixes
>     #151 unchecked 'download limit' really means 16 download limit
>     #458 fix unable to drag and drop from episode list
>     #459 fix downloaded filenames based on content-disposition
>     #420 don't leak open file descriptors (was preventing rename on
> download on Windows)
>
> Translations
>
>     Hungarian translation added
>     French translation updated
>
> Tim.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/gpodder/Makefile,v
> retrieving revision 1.13
> diff -u -p -r1.13 Makefile
> --- Makefile 20 Feb 2018 03:44:32 -0000 1.13
> +++ Makefile 26 Jun 2018 23:46:39 -0000
> @@ -2,7 +2,7 @@
>
>  COMMENT= media aggregator and podcast client
>
> -MODPY_EGG_VERSION= 3.10.1
> +MODPY_EGG_VERSION= 3.10.3
>
>  GH_ACCOUNT= gpodder
>  GH_PROJECT= gpodder
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/gpodder/distinfo,v
> retrieving revision 1.5
> diff -u -p -r1.5 distinfo
> --- distinfo 20 Feb 2018 03:44:32 -0000 1.5
> +++ distinfo 26 Jun 2018 23:46:39 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (gpodder-3.10.1.tar.gz) =
> zT9lFG+iAsKGHY8KL6ISMjgwxsQ3onL2+IpeA1gengs=
> -SIZE (gpodder-3.10.1.tar.gz) = 883011
> +SHA256 (gpodder-3.10.3.tar.gz) =
> pTsjxgWzqScBrtPjGPBpWuLk3humRpIzfgqPdyU+u7E=
> +SIZE (gpodder-3.10.3.tar.gz) = 980333
> Index: pkg/PLIST
> ===================================================================
> RCS file: /cvs/ports/net/gpodder/pkg/PLIST,v
> retrieving revision 1.5
> diff -u -p -r1.5 PLIST
> --- pkg/PLIST 20 Feb 2018 03:44:32 -0000 1.5
> +++ pkg/PLIST 26 Jun 2018 23:46:39 -0000
> @@ -8,6 +8,8 @@ lib/python${MODPY_VERSION}/site-packages
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}/
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}build_info.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
> +lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}build_info.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}common.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}common.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}config.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
> @@ -58,10 +60,15 @@ lib/python${MODPY_VERSION}/site-packages
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}unittests.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}util.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}util.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32ctypes.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
> +lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32ctypes.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32locale.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
> +lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}utilwin32locale.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}vimeo.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}vimeo.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}youtube.${MODPY_PYC_MAGIC_TAG}${MODPY_PYOEXTENSION}
>  lib/python${MODPY_VERSION}/site-packages/gpodder/${MODPY_PYCACHE}youtube.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/gpodder/build_info.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/common.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/config.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/core.py
> @@ -187,6 +194,8 @@ lib/python${MODPY_VERSION}/site-packages
>  lib/python${MODPY_VERSION}/site-packages/gpodder/test/model.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/unittests.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/util.py
> +lib/python${MODPY_VERSION}/site-packages/gpodder/utilwin32ctypes.py
> +lib/python${MODPY_VERSION}/site-packages/gpodder/utilwin32locale.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/vimeo.py
>  lib/python${MODPY_VERSION}/site-packages/gpodder/youtube.py
>  @man man/man1/gpo.1
> @@ -202,6 +211,7 @@ share/gpodder/examples/hello_world.py
>  share/gpodder/extensions/
>  share/gpodder/extensions/${MODPY_PYCACHE}/
>  share/gpodder/extensions/${MODPY_PYCACHE}audio_converter.${MODPY_PYC_MAGIC_TAG}pyc
> +share/gpodder/extensions/${MODPY_PYCACHE}command_on_download.${MODPY_PYC_MAGIC_TAG}pyc
>  share/gpodder/extensions/${MODPY_PYCACHE}concatenate_videos.${MODPY_PYC_MAGIC_TAG}pyc
>  share/gpodder/extensions/${MODPY_PYCACHE}enqueue_in_mediaplayer.${MODPY_PYC_MAGIC_TAG}pyc
>  share/gpodder/extensions/${MODPY_PYCACHE}episode_website_context_menu.${MODPY_PYC_MAGIC_TAG}pyc
> @@ -224,6 +234,7 @@ share/gpodder/extensions/${MODPY_PYCACHE
>  share/gpodder/extensions/${MODPY_PYCACHE}update_feeds_on_startup.${MODPY_PYC_MAGIC_TAG}pyc
>  share/gpodder/extensions/${MODPY_PYCACHE}video_converter.${MODPY_PYC_MAGIC_TAG}pyc
>  share/gpodder/extensions/audio_converter.py
> +share/gpodder/extensions/command_on_download.py
>  share/gpodder/extensions/concatenate_videos.py
>  share/gpodder/extensions/enqueue_in_mediaplayer.py
>  share/gpodder/extensions/episode_website_context_menu.py
> @@ -307,6 +318,7 @@ share/locale/fi/LC_MESSAGES/gpodder.mo
>  share/locale/fr/LC_MESSAGES/gpodder.mo
>  share/locale/gl/LC_MESSAGES/gpodder.mo
>  share/locale/he/LC_MESSAGES/gpodder.mo
> +share/locale/hu/LC_MESSAGES/gpodder.mo
>  share/locale/id_ID/
>  share/locale/id_ID/LC_MESSAGES/
>  share/locale/id_ID/LC_MESSAGES/gpodder.mo
>