UPDATE: databases/py-redis-3.0.1

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

UPDATE: databases/py-redis-3.0.1

Edward Lopez-Acosta
Backwards incompatible changes in this, but checking sqlports I found
nothing that depends on this. I installed this package and ran a series
of tests on it using some of my old scripts and didn't hit issues.

$ sqlite3 /usr/local/share/sqlports "select * from depends where
dependspath like 'databases/py-redis' or dependspath like
'databases/py-redis,python3'" | wc -l
        0

Version bump, no new patches needed, MAINTAINER CC, builds and installs
fine on amd64.

diff generated with `git diff --relative .` in the port directory for
easy application with patch.

Test results for py3 below but are the same for py2. This is using Redis
4 which is currently in the tree.

============================= test session starts
==============================
platform openbsd6 -- Python 3.6.7, pytest-3.5.0, py-1.5.3, pluggy-0.6.0
rootdir: /usr/ports/pobj/py-redis-3.0.1-python3/redis-py-3.0.1, inifile:
collected 384 items

tests/test_commands.py ...sss...........................................
[ 12%]
........................................................................
[ 31%]
.....................ssss...............................................
[ 50%]
..........................s.........sssssssssssssssssss.......
[ 66%]
tests/test_connection_pool.py ..........................................
[ 77%]
.
[ 77%]
tests/test_encoding.py ......
[ 79%]
tests/test_lock.py .................
[ 83%]
tests/test_pipeline.py .................
[ 88%]
tests/test_pubsub.py ...........................
[ 95%]
tests/test_scripting.py .......
[ 96%]
tests/test_sentinel.py ............
[100%]

==================== 357 passed, 27 skipped in 9.77 seconds
====================

Thoughts?
--
Edward Lopez-Acosta

py-redis.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: databases/py-redis-3.0.1

Stuart Henderson
On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
> Backwards incompatible changes in this, but checking sqlports I found
> nothing that depends on this. I installed this package and ran a series of
> tests on it using some of my old scripts and didn't hit issues.
>
> $ sqlite3 /usr/local/share/sqlports "select * from depends where dependspath
> like 'databases/py-redis' or dependspath like 'databases/py-redis,python3'"
> | wc -l

btw you can do "where dependspath like 'databases/py-redis%'" to cover
both flavours.

Tests also require devel/py-mock:

===>  Regression tests for py-redis-3.0.1
running test
Searching for mock
Reading https://pypi.org/simple/mock/
Download error on https://pypi.org/simple/mock/: [Errno 65] No route to host -- Some packages may not be found!
Couldn't find index page for 'mock' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.org/simple/
Download error on https://pypi.org/simple/: [Errno 65] No route to host -- Some packages may not be found!
No local packages or working download links found for mock
error: Could not find suitable distribution for Requirement.parse('mock')

Otherwise looks good to me.

Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: databases/py-redis-3.0.1

Edward Lopez-Acosta
Hi Stuart,

It does look like the py-py requirement changed to mock as you noted. I didn't notice the warning initially, my mistake.

Would you like me to submit a new diff this evening with that change? I see the same number of tests pass and be skipped.

Thanks for the sqlite tip as well. I am going to update the application I wrote with that in mind, and add clarity to my output.

On December 6, 2018 10:26:07 AM UTC, Stuart Henderson <[hidden email]> wrote:

>On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
>> Backwards incompatible changes in this, but checking sqlports I found
>> nothing that depends on this. I installed this package and ran a
>series of
>> tests on it using some of my old scripts and didn't hit issues.
>>
>> $ sqlite3 /usr/local/share/sqlports "select * from depends where
>dependspath
>> like 'databases/py-redis' or dependspath like
>'databases/py-redis,python3'"
>> | wc -l
>
>btw you can do "where dependspath like 'databases/py-redis%'" to cover
>both flavours.
>
>Tests also require devel/py-mock:
>
>===>  Regression tests for py-redis-3.0.1
>running test
>Searching for mock
>Reading https://pypi.org/simple/mock/
>Download error on https://pypi.org/simple/mock/: [Errno 65] No route to
>host -- Some packages may not be found!
>Couldn't find index page for 'mock' (maybe misspelled?)
>Scanning index of all packages (this may take a while)
>Reading https://pypi.org/simple/
>Download error on https://pypi.org/simple/: [Errno 65] No route to host
>-- Some packages may not be found!
>No local packages or working download links found for mock
>error: Could not find suitable distribution for
>Requirement.parse('mock')
>
>Otherwise looks good to me.

Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: databases/py-redis-3.0.1

Edward Lopez-Acosta
In reply to this post by Stuart Henderson
Resubmitting the diff so its easier for commit.

I replaced the py-py test depend with py-mock like it should be. py-py
is pulled is as a dependency of mock.

Edward Lopez-Acosta

On 12/6/18 4:26 AM, Stuart Henderson wrote:

> On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
>> Backwards incompatible changes in this, but checking sqlports I found
>> nothing that depends on this. I installed this package and ran a series of
>> tests on it using some of my old scripts and didn't hit issues.
>>
>> $ sqlite3 /usr/local/share/sqlports "select * from depends where dependspath
>> like 'databases/py-redis' or dependspath like 'databases/py-redis,python3'"
>> | wc -l
>
> btw you can do "where dependspath like 'databases/py-redis%'" to cover
> both flavours.
>
> Tests also require devel/py-mock:
>
> ===>  Regression tests for py-redis-3.0.1
> running test
> Searching for mock
> Reading https://pypi.org/simple/mock/
> Download error on https://pypi.org/simple/mock/: [Errno 65] No route to host -- Some packages may not be found!
> Couldn't find index page for 'mock' (maybe misspelled?)
> Scanning index of all packages (this may take a while)
> Reading https://pypi.org/simple/
> Download error on https://pypi.org/simple/: [Errno 65] No route to host -- Some packages may not be found!
> No local packages or working download links found for mock
> error: Could not find suitable distribution for Requirement.parse('mock')
>
> Otherwise looks good to me.
>

py-redis.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: databases/py-redis-3.0.1

Edward Lopez-Acosta
ping?

Edward Lopez-Acosta

On 12/6/18 5:39 PM, Edward Lopez-Acosta wrote:

> Resubmitting the diff so its easier for commit.
>
> I replaced the py-py test depend with py-mock like it should be. py-py
> is pulled is as a dependency of mock.
>
> Edward Lopez-Acosta
>
> On 12/6/18 4:26 AM, Stuart Henderson wrote:
>> On 2018/12/05 18:47, Edward Lopez-Acosta wrote:
>>> Backwards incompatible changes in this, but checking sqlports I found
>>> nothing that depends on this. I installed this package and ran a
>>> series of
>>> tests on it using some of my old scripts and didn't hit issues.
>>>
>>> $ sqlite3 /usr/local/share/sqlports "select * from depends where
>>> dependspath
>>> like 'databases/py-redis' or dependspath like
>>> 'databases/py-redis,python3'"
>>> | wc -l
>>
>> btw you can do "where dependspath like 'databases/py-redis%'" to cover
>> both flavours.
>>
>> Tests also require devel/py-mock:
>>
>> ===>  Regression tests for py-redis-3.0.1
>> running test
>> Searching for mock
>> Reading https://pypi.org/simple/mock/
>> Download error on https://pypi.org/simple/mock/: [Errno 65] No route
>> to host -- Some packages may not be found!
>> Couldn't find index page for 'mock' (maybe misspelled?)
>> Scanning index of all packages (this may take a while)
>> Reading https://pypi.org/simple/
>> Download error on https://pypi.org/simple/: [Errno 65] No route to
>> host -- Some packages may not be found!
>> No local packages or working download links found for mock
>> error: Could not find suitable distribution for Requirement.parse('mock')
>>
>> Otherwise looks good to me.
>>