UPDATE: audio/p5-cddb

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

UPDATE: audio/p5-cddb

Jasper Lievisse Adriaanse
Hello,

this diff brings audio/p5-cddb up to date. Tested on i386.
Yes, it fails some regression tests, but the in-tree version does this too.

Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/p5-cddb/Makefile,v
retrieving revision 1.15
diff -u -r1.15 Makefile
--- Makefile 7 Feb 2005 19:01:48 -0000 1.15
+++ Makefile 26 Nov 2005 16:17:19 -0000
@@ -2,7 +2,7 @@
 
 COMMENT= "Perl5 module for CDDB"
 
-DISTNAME= CDDB-1.15
+DISTNAME= CDDB-1.16
 PKGNAME= p5-${DISTNAME}
 CATEGORIES= audio perl5
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/audio/p5-cddb/distinfo,v
retrieving revision 1.6
diff -u -r1.6 distinfo
--- distinfo 5 Jan 2005 15:47:08 -0000 1.6
+++ distinfo 26 Nov 2005 16:17:19 -0000
@@ -1,4 +1,4 @@
-MD5 (CDDB-1.15.tar.gz) = 978aaecd665af4988d33d8f3df392fb7
-RMD160 (CDDB-1.15.tar.gz) = 1c2f00c135b5019753870aa9336f2ce3d1b99858
-SHA1 (CDDB-1.15.tar.gz) = aca1b94d1fb4f046270ac2a3f8e15ac970f1f6d3
-SIZE (CDDB-1.15.tar.gz) = 22009
+MD5 (CDDB-1.16.tar.gz) = 4753c73ac7162ab18d1508ae02d40014
+RMD160 (CDDB-1.16.tar.gz) = 509a52aa11c034bb6bb629e9362ee57facc7715d
+SHA1 (CDDB-1.16.tar.gz) = 212f71d1c22a597cb72df85212ea6e9d0a2f3152
+SIZE (CDDB-1.16.tar.gz) = 22657


Cheers,
Jasper

--
"Security is decided by quality" -- Theo de Raadt

Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: audio/p5-cddb

steven mestdagh
On Sat, Nov 26, 2005 at 08:01:11PM +0100, Jasper Lievisse Adriaanse wrote:
> Hello,
>
> this diff brings audio/p5-cddb up to date. Tested on i386.
> Yes, it fails some regression tests, but the in-tree version does this too.

this patch should fix it (patch-t_cddb_t). apparently there are now two
matches for the cddb test disc ID.  do you want to maintain this port?

$OpenBSD$
--- t/cddb.t.orig Sat Nov 26 20:19:34 2005
+++ t/cddb.t Sat Nov 26 20:55:04 2005
@@ -134,13 +134,13 @@ else {
   print "not ok 12\n";
 }
 
-### test looking up discs (one match)
+### test looking up discs (two matches)
 
 my @discs = $cddb->get_discs($id, $track_offsets, $total_seconds);
 
-(@discs == 1) || print 'not '; print "ok 13\n";
+(@discs == 2) || print 'not '; print "ok 13\n";
 
-my ($genre, $cddb_id, $title) = @{$discs[0]};
+my ($genre, $cddb_id, $title) = @{$discs[1]};
 ($genre   eq 'misc')      || print 'not '; print "ok 14\n";
 ($cddb_id eq '03015501')  || print 'not '; print "ok 15\n";
 
@@ -153,7 +153,7 @@ $cddb->disconnect();
 my @other_discs = $cddb->get_discs_by_toc(@toc);
 
 if (@other_discs) {
-  (@other_discs == 1) || print 'not '; print "ok 17\n";
+  (@other_discs == 2) || print 'not '; print "ok 17\n";
   ($other_discs[0]->[0] eq $discs[0]->[0]) || print 'not '; print "ok 18\n";
   ($other_discs[0]->[1] eq $discs[0]->[1]) || print 'not '; print "ok 19\n";
   ($other_discs[0]->[2] eq $discs[0]->[2]) || print 'not '; print "ok 20\n";

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm