UPDATE: archivers/libzip 1.3.2 => 1.4.0

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

UPDATE: archivers/libzip 1.3.2 => 1.4.0

Brian Callahan-3
Hi ports --

Attached is an update to libzip. Notable changes are a minor lib bump,
the removal of autoconf in favor of cmake, and no longer building the
static libraries.

Passes the building its dependents test.

OK?

~Brian


libzip-140.diff (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: archivers/libzip 1.3.2 => 1.4.0

Brian Callahan-3

On 12/30/17 10:28, Brian Callahan wrote:

> Hi ports --
>
> Attached is an update to libzip. Notable changes are a minor lib bump,
> the removal of autoconf in favor of cmake, and no longer building the
> static libraries.
>
> Passes the building its dependents test.
>
> OK?
>
> ~Brian
>

Ping. All is good on amd64 and arm.

~Brian

Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: archivers/libzip 1.3.2 => 1.4.0

Rafael Sadowski
In reply to this post by Brian Callahan-3
On Sat Dec 30, 2017 at 10:28:25AM -0500, Brian Callahan wrote:

> Hi ports --
>
> Attached is an update to libzip. Notable changes are a
> minor lib bump, the removal of autoconf in favor of cmake,
> and no longer building the static libraries.
>
> Passes the building its dependents test.
>
> OK?
>
> ~Brian
>

Could you try the following option to disable Bzip2:

-DCMAKE_DISABLE_FIND_PACKAGE_BZip2:Bool=Yes

Cheers,

Rafael

Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: archivers/libzip 1.3.2 => 1.4.0

Stuart Henderson
On 2018/01/08 23:35, Rafael Sadowski wrote:

> On Sat Dec 30, 2017 at 10:28:25AM -0500, Brian Callahan wrote:
> > Hi ports --
> >
> > Attached is an update to libzip. Notable changes are a
> > minor lib bump, the removal of autoconf in favor of cmake,
> > and no longer building the static libraries.
> >
> > Passes the building its dependents test.
> >
> > OK?
> >
> > ~Brian
> >
>
> Could you try the following option to disable Bzip2:
>
> -DCMAKE_DISABLE_FIND_PACKAGE_BZip2:Bool=Yes
>
> Cheers,
>
> Rafael
>

Why does it need to disable bzip2 anyway?

Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: archivers/libzip 1.3.2 => 1.4.0

Brian Callahan-3

On 01/09/18 07:05, Stuart Henderson wrote:

> On 2018/01/08 23:35, Rafael Sadowski wrote:
>> On Sat Dec 30, 2017 at 10:28:25AM -0500, Brian Callahan wrote:
>>> Hi ports --
>>>
>>> Attached is an update to libzip. Notable changes are a
>>> minor lib bump, the removal of autoconf in favor of cmake,
>>> and no longer building the static libraries.
>>>
>>> Passes the building its dependents test.
>>>
>>> OK?
>>>
>>> ~Brian
>>>
>> Could you try the following option to disable Bzip2:
>>
>> -DCMAKE_DISABLE_FIND_PACKAGE_BZip2:Bool=Yes
>>
>> Cheers,
>>
>> Rafael
>>
> Why does it need to disable bzip2 anyway?
>
That's just how it was when I inherited it. Enabling bzip2 does make it
easier to maintain in this new CMake world.
Diff attached. All tests pass on amd64.

~Brian


libzip-140.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: UPDATE: archivers/libzip 1.3.2 => 1.4.0

Stuart Henderson
On 2018/01/09 17:13, Brian Callahan wrote:

>
> On 01/09/18 07:05, Stuart Henderson wrote:
> > On 2018/01/08 23:35, Rafael Sadowski wrote:
> > > On Sat Dec 30, 2017 at 10:28:25AM -0500, Brian Callahan wrote:
> > > > Hi ports --
> > > >
> > > > Attached is an update to libzip. Notable changes are a
> > > > minor lib bump, the removal of autoconf in favor of cmake,
> > > > and no longer building the static libraries.
> > > >
> > > > Passes the building its dependents test.
> > > >
> > > > OK?
> > > >
> > > > ~Brian
> > > >
> > > Could you try the following option to disable Bzip2:
> > >
> > > -DCMAKE_DISABLE_FIND_PACKAGE_BZip2:Bool=Yes
> > >
> > > Cheers,
> > >
> > > Rafael
> > >
> > Why does it need to disable bzip2 anyway?
> >
>
> That's just how it was when I inherited it. Enabling bzip2 does make it
> easier to maintain in this new CMake world.
> Diff attached. All tests pass on amd64.

OK with me.