[UPDATE] [WIP] x11/polybar 3.5.4

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[UPDATE] [WIP] x11/polybar 3.5.4

Guy Godfroy
Hello,

I'm not very skilled in ports maintenance.

I'm trying to update polybar port from 3.4.3 to 3.5.4 but I can't get
over a Sphinx error. I join the diff of what I made to the port.

When I try to complile, I have got this error:

[1/91] cd /usr/ports/pobj/polybar-3.5.4/build-amd64/doc &&
sphinx-build-3 -b html -c /usr/ports/pobj/polybar-3.5.4/build-amd64/doc
-d /usr/ports/pobj/polybar-3.5.4/build-amd64/doc/doctrees
/usr/ports/pobj/polybar-3.5.4/polybar-3.5.4/doc
/usr/ports/pobj/polybar-3.5.4/build-amd64/doc/html > builder-html.log
FAILED: doc/CMakeFiles/doc_html
cd /usr/ports/pobj/polybar-3.5.4/build-amd64/doc && sphinx-build-3 -b
html -c /usr/ports/pobj/polybar-3.5.4/build-amd64/doc -d
/usr/ports/pobj/polybar-3.5.4/build-amd64/doc/doctrees
/usr/ports/pobj/polybar-3.5.4/polybar-3.5.4/doc
/usr/ports/pobj/polybar-3.5.4/build-amd64/doc/html > builder-html.log

Exception occurred:
  File "conf.py", line 20, in <module>
    from sphinx.domains.changeset import VersionChange
ModuleNotFoundError: No module named 'sphinx.domains.changeset'


This wasn't occuring on the current port version.

What am I missing?

Thank you for your attention.

maildiff (13K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] [WIP] x11/polybar 3.5.4

Guy Godfroy
After some research, I found out that maybe sphinx version had something
to do with it (thanks solene).

I found out that OpenBSD version of py-sphinx (1.5.6) is almost 4 years
old. Current version is 3.5.1.

I am not skilled enough to take care of upgrading py-sphinx (simply
change some variables and updating checksums won't do) and the amount of
ports depending on py-sphinx and potentially breaking with an update
must be huge, I am clueless about how even to begin the work. I would
appreciate if somebody with more skills would take care of it.

Le 16/02/2021 à 16:23, Guy Godfroy a écrit :

> Hello,
>
> I'm not very skilled in ports maintenance.
>
> I'm trying to update polybar port from 3.4.3 to 3.5.4 but I can't get
> over a Sphinx error. I join the diff of what I made to the port.
>
> When I try to complile, I have got this error:
>
> [1/91] cd /usr/ports/pobj/polybar-3.5.4/build-amd64/doc &&
> sphinx-build-3 -b html -c /usr/ports/pobj/polybar-3.5.4/build-amd64/doc
> -d /usr/ports/pobj/polybar-3.5.4/build-amd64/doc/doctrees
> /usr/ports/pobj/polybar-3.5.4/polybar-3.5.4/doc
> /usr/ports/pobj/polybar-3.5.4/build-amd64/doc/html > builder-html.log
> FAILED: doc/CMakeFiles/doc_html
> cd /usr/ports/pobj/polybar-3.5.4/build-amd64/doc && sphinx-build-3 -b
> html -c /usr/ports/pobj/polybar-3.5.4/build-amd64/doc -d
> /usr/ports/pobj/polybar-3.5.4/build-amd64/doc/doctrees
> /usr/ports/pobj/polybar-3.5.4/polybar-3.5.4/doc
> /usr/ports/pobj/polybar-3.5.4/build-amd64/doc/html > builder-html.log
>
> Exception occurred:
>    File "conf.py", line 20, in <module>
>      from sphinx.domains.changeset import VersionChange
> ModuleNotFoundError: No module named 'sphinx.domains.changeset'
>
>
> This wasn't occuring on the current port version.
>
> What am I missing?
>
> Thank you for your attention.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] [WIP] x11/polybar 3.5.4

Stuart Henderson
On 2021/02/16 18:47, Guy Godfroy wrote:

> After some research, I found out that maybe sphinx version had
> something to do with it (thanks solene).
>
> I found out that OpenBSD version of py-sphinx (1.5.6) is almost
> 4 years old. Current version is 3.5.1.
>
> I am not skilled enough to take care of upgrading py-sphinx
> (simply change some variables and updating checksums won't do)
> and the amount of ports depending on py-sphinx and potentially
> breaking with an update must be huge, I am clueless about how
> even to begin the work. I would appreciate if somebody with more
> skills would take care of it.

We are working on it gradually, the current part of the process is to
remove Python 2 versions of ports that use Sphinx or disable Sphinx in
those ports where it doesn't really add anything important to them.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] [WIP] x11/polybar 3.5.4

Guy Godfroy
So what do you recommend to do other upgrades that depends on it (for
instance polybar) in the meantime?

Le 16/02/2021 à 21:36, Stuart Henderson a écrit :

> On 2021/02/16 18:47, Guy Godfroy wrote:
>> After some research, I found out that maybe sphinx version had
>> something to do with it (thanks solene).
>>
>> I found out that OpenBSD version of py-sphinx (1.5.6) is almost
>> 4 years old. Current version is 3.5.1.
>>
>> I am not skilled enough to take care of upgrading py-sphinx
>> (simply change some variables and updating checksums won't do)
>> and the amount of ports depending on py-sphinx and potentially
>> breaking with an update must be huge, I am clueless about how
>> even to begin the work. I would appreciate if somebody with more
>> skills would take care of it.
>
> We are working on it gradually, the current part of the process is to
> remove Python 2 versions of ports that use Sphinx or disable Sphinx in
> those ports where it doesn't really add anything important to them.
>

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] [WIP] x11/polybar 3.5.4

Stuart Henderson
Hold off on the update, or disable doc generation, or try to patch around it.

--
  Sent from a phone, apologies for poor formatting.
On 17 February 2021 07:27:55 Guy Godfroy <[hidden email]> wrote:

> So what do you recommend to do other upgrades that depends on it (for
> instance polybar) in the meantime?
>
> Le 16/02/2021 à 21:36, Stuart Henderson a écrit :
>> On 2021/02/16 18:47, Guy Godfroy wrote:
>>> After some research, I found out that maybe sphinx version had
>>> something to do with it (thanks solene).
>>>
>>> I found out that OpenBSD version of py-sphinx (1.5.6) is almost
>>> 4 years old. Current version is 3.5.1.
>>>
>>> I am not skilled enough to take care of upgrading py-sphinx
>>> (simply change some variables and updating checksums won't do)
>>> and the amount of ports depending on py-sphinx and potentially
>>> breaking with an update must be huge, I am clueless about how
>>> even to begin the work. I would appreciate if somebody with more
>>> skills would take care of it.
>>
>> We are working on it gradually, the current part of the process is to
>> remove Python 2 versions of ports that use Sphinx or disable Sphinx in
>> those ports where it doesn't really add anything important to them.
>>

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] x11/polybar 3.5.4

Guy Godfroy
Hello,

Thanks to recent py-sphinx update, here is the diff to update polybar.

On the old version of the port, i3 support was explicitly disabled,
don't know why. I re-enabled it and it works fine.

Works on amd64.

OK?

Le 17/02/2021 à 11:37, Stuart Henderson a écrit :
> Hold off on the update, or disable doc generation, or try to patch
> around it.
>

maildiff (17K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] x11/polybar 3.5.4

Stuart Henderson
On 2021/02/23 10:41, Guy Godfroy wrote:
> Hello,
>
> Thanks to recent py-sphinx update, here is the diff to update polybar.
>
> On the old version of the port, i3 support was explicitly disabled,
> don't know why. I re-enabled it and it works fine.

Diff doesn't apply directly against -current.

> MAINTAINER =   Jasper Lievisse Adriaanse <[hidden email]>

it's customary to CC the maintainer in case they aren't watching ports@.

> RCS file: patches/patch-src_modules_temperature_cpp
> diff -N patches/patch-src_modules_temperature_cpp
> --- patches/patch-src_modules_temperature_cpp 12 Dec 2019 17:09:47 -0000 1.2
> +++ /dev/null 1 Jan 1970 00:00:00 -0000
> @@ -1,91 +0,0 @@
> -$OpenBSD: patch-src_modules_temperature_cpp,v 1.2 2019/12/12 17:09:47 jasper Exp $
> -
> -Index: src/modules/temperature.cpp
> ---- src/modules/temperature.cpp.orig
> -+++ src/modules/temperature.cpp
> -@@ -8,6 +8,17 @@

This patch needs updating for the new version rather than deleting.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] x11/polybar 3.5.4

Guy Godfroy
Le 23/02/2021 à 13:14, Stuart Henderson a écrit :> Diff doesn't apply
directly against -current.

Here is the new diff, should work now.

> it's customary to CC the maintainer in case they aren't watching ports@.

Done.

> This patch needs updating for the new version rather than deleting.

You're right, I don't know how I ended up just deleting it. I fixed that.

maildiff (13K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] x11/polybar 3.5.4

Guy Godfroy
Friendly ping.

I wish that update to be approved before any other commit will break it.

Le 24/02/2021 à 10:52, Guy Godfroy a écrit :

> Le 23/02/2021 à 13:14, Stuart Henderson a écrit :> Diff doesn't apply
> directly against -current.
>
> Here is the new diff, should work now.
>
>> it's customary to CC the maintainer in case they aren't watching ports@.
>
> Done.
>
>> This patch needs updating for the new version rather than deleting.
>
> You're right, I don't know how I ended up just deleting it. I fixed that.
>

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] x11/polybar 3.5.4

Stuart Henderson
On 2021/02/25 11:05, Guy Godfroy wrote:

> Friendly ping.
>
> I wish that update to be approved before any other commit will break it.
>
> Le 24/02/2021 à 10:52, Guy Godfroy a écrit :
> > Le 23/02/2021 à 13:14, Stuart Henderson a écrit :> Diff doesn't apply
> > directly against -current.
> >
> > Here is the new diff, should work now.
> >
> >> it's customary to CC the maintainer in case they aren't watching ports@.
> >
> > Done.
> >
> >> This patch needs updating for the new version rather than deleting.
> >
> > You're right, I don't know how I ended up just deleting it. I fixed that.
> >
>

1 day is way too send to be prodding on ports submissions.

Reply | Threaded
Open this post in threaded view
|

Re: [UPDATE] x11/polybar 3.5.4

Stuart Henderson
On 2021/02/25 13:27, Stuart Henderson wrote:

> On 2021/02/25 11:05, Guy Godfroy wrote:
> > Friendly ping.
> >
> > I wish that update to be approved before any other commit will break it.
> >
> > Le 24/02/2021 à 10:52, Guy Godfroy a écrit :
> > > Le 23/02/2021 à 13:14, Stuart Henderson a écrit :> Diff doesn't apply
> > > directly against -current.
> > >
> > > Here is the new diff, should work now.
> > >
> > >> it's customary to CC the maintainer in case they aren't watching ports@.
> > >
> > > Done.
> > >
> > >> This patch needs updating for the new version rather than deleting.
> > >
> > > You're right, I don't know how I ended up just deleting it. I fixed that.
> > >
> >
>
> 1 day is way too send to be prodding on ports submissions.
>

typo: s/send/soon