Retry, rxvt: patch for underflow in rxvt_selection_adjust_kanji

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Retry, rxvt: patch for underflow in rxvt_selection_adjust_kanji

Gregory Steuck-2
Hello,

Could somebody please apply the attached patch? No reply from Jason thus
far. I previously sent this to the list too:
http://archives.neohapsis.com/archives/openbsd/2005-12/0646.html

Thanks
Greg

Hi Jason,

Could you apply this patch?

Attached is a patch for rxvt bug found by guarded malloc.

There is an underflow condition in rxvt_selection_adjust_kanji triggered
when one drags the mouse holding left button along the left side of the
window (c1 == 0). The added check prevents reading memory before the
allocated buffer. This seems to also be semantically correct as there is
no need to extend selection when there is nothing selected on the line.

I also uploaded this patch to rxvt bug database.
http://sourceforge.net/tracker/?func=add&group_id=221&atid=100221

Thanks
Greg

patch-rxvt-underflow-in-rxvt_selection_adjust_kanji (1K) Download Attachment