RUN_DEPENDS=${BUILD_DEPENDS}

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

RUN_DEPENDS=${BUILD_DEPENDS}

Matthias Kilian
Hi,

[cc'd maintainers so it doesn't get forgotten]

after this mention of facts:

<sthen> no port should use RUN_DEPENDS=${BUILD_DEPENDS}

i just ran a quick

make show=RUN_DEPENDS BUILD_DEPENDS=HURZ | grep -B2 HURZ

in /usr/ports, and found the following ports using
RUN_DEPENDS=${BUILD_DEPENDS}:

devel/angr/py-angr
devel/angr/py-pyvex
devel/qt-creator
devel/tortoisehg
sysutils/slant

Why is this bad? Because BUILD_DEPENDS may change *silently* (think
of changes to some port modules) and then RUN_DEPENDS would also
change silently, allthough a REVISION bump would be required.[1]

So better don't do this.

Ciao,
        Kili

[1] naddy@ just mentioned somthing like an added USE_GMAKE as another
example which would cause a silent change to BUILD_DEPENDS.

Reply | Threaded
Open this post in threaded view
|

Re: RUN_DEPENDS=${BUILD_DEPENDS}

Matthias Kilian
Hi,

On Tue, Feb 11, 2020 at 02:24:11PM +0100, Jasper Lievisse Adriaanse wrote:
> OK for this diff to correct this mis-pattern (angr has been fixed already)?

After just comparing BUILD_DEPENDS and RUN_DEPENDS before vs. after
appluying your diff: ok

Ciao,
        Kili

> Index: devel/tortoisehg/Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/tortoisehg/Makefile,v
> retrieving revision 1.40
> diff -u -p -r1.40 Makefile
> --- devel/tortoisehg/Makefile 25 Jul 2019 16:10:53 -0000 1.40
> +++ devel/tortoisehg/Makefile 11 Feb 2020 13:22:12 -0000
> @@ -4,7 +4,7 @@ COMMENT = series of applications for Me
>  
>  # Change also the mercurial version in *_depends
>  MODPY_EGG_VERSION = 5.0.2
> -REVISION = 0
> +REVISION = 1
>  DISTNAME = tortoisehg-${MODPY_EGG_VERSION}
>  
>  CATEGORIES = devel
> @@ -24,9 +24,11 @@ BUILD_DEPENDS = devel/mercurial>=5.0,<5
>   editors/qscintilla \
>   x11/py-qt4
>  
> -RUN_DEPENDS = ${BUILD_DEPENDS} \
> - devel/py-iniparse \
> - editors/py-qscintilla
> +RUN_DEPENDS = devel/py-iniparse \
> + devel/py-sip \
> + editors/py-qscintilla \
> + x11/py-qt4 \
> + devel/mercurial>=5.0,<5.1
>  
>  NO_TEST = Yes
>  
> Index: devel/qt-creator/Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/qt-creator/Makefile,v
> retrieving revision 1.53
> diff -u -p -r1.53 Makefile
> --- devel/qt-creator/Makefile 12 Jul 2019 20:45:57 -0000 1.53
> +++ devel/qt-creator/Makefile 11 Feb 2020 13:22:12 -0000
> @@ -7,7 +7,7 @@ COMMENT = cross-platform IDE for use wi
>  V = 4.8.2
>  DISTNAME = qt-creator-opensource-src-${V}
>  PKGNAME = qt-creator-${V}
> -REVISION = 3
> +REVISION = 4
>  
>  SHARED_LIBS += Aggregation               0.0 # 0.0
>  SHARED_LIBS += CPlusPlus                 2.0 # 0.0
> @@ -60,10 +60,12 @@ BUILD_DEPENDS = x11/qt5/qtquickcontrols
>   devel/qbs
>  
>  RUN_DEPENDS = ${MODGCC4_CPPDEP} \
> - ${BUILD_DEPENDS} \
>   devel/gdb \
>   devel/gmake \
> + devel/qbs \
> + lang/clazy>=1.5 \
>   x11/gtk+3,-guic \
> + x11/qt5/qtquickcontrols \
>   x11/qt5/qtquickcontrols \
>   x11/qt5/qtwebkit
>  
> Index: sysutils/slant/Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/slant/Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile
> --- sysutils/slant/Makefile 24 Nov 2019 14:40:30 -0000 1.4
> +++ sysutils/slant/Makefile 11 Feb 2020 13:22:12 -0000
> @@ -3,7 +3,7 @@
>  COMMENT = minimal remote system monitor
>  
>  DISTNAME = slant-0.0.21
> -REVISION = 1
> +REVISION = 2
>  
>  CATEGORIES = sysutils
>  
> @@ -17,9 +17,9 @@ PERMIT_PACKAGE = Yes
>  # uses pledge()
>  WANTLIB += c curses sqlite3 tls z
>  
> -BUILD_DEPENDS = databases/ksql \
> +BUILD_DEPENDS = ${RUN_DEPENDS}
> +RUN_DEPENDS = databases/ksql \
>   www/openradtool>=0.7.4
> -RUN_DEPENDS = ${BUILD_DEPENDS}
>  
>  LIB_DEPENDS = databases/sqlite3
>  
> --
> jasper

Reply | Threaded
Open this post in threaded view
|

Re: RUN_DEPENDS=${BUILD_DEPENDS}

Juan Francisco Cantero Hurtado-2
On Thu, 13 Feb 2020 21:06:11 +0100
Matthias Kilian <[hidden email]> wrote:

> Hi,
>
> On Tue, Feb 11, 2020 at 02:24:11PM +0100, Jasper Lievisse Adriaanse
> wrote:
> > OK for this diff to correct this mis-pattern (angr has been fixed
> > already)?  
>
> After just comparing BUILD_DEPENDS and RUN_DEPENDS before vs. after
> appluying your diff: ok

Thanks guys for taking care of this. I haven't had time this week.

>
> Ciao,
> Kili
>
> > Index: devel/tortoisehg/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/tortoisehg/Makefile,v
> > retrieving revision 1.40
> > diff -u -p -r1.40 Makefile
> > --- devel/tortoisehg/Makefile 25 Jul 2019 16:10:53
> > -0000 1.40 +++ devel/tortoisehg/Makefile 11 Feb 2020
> > 13:22:12 -0000 @@ -4,7 +4,7 @@ COMMENT = series of
> > applications for Me
> >  # Change also the mercurial version in *_depends
> >  MODPY_EGG_VERSION = 5.0.2
> > -REVISION = 0
> > +REVISION = 1
> >  DISTNAME = tortoisehg-${MODPY_EGG_VERSION}
> >  
> >  CATEGORIES = devel
> > @@ -24,9 +24,11 @@ BUILD_DEPENDS =
> > devel/mercurial>=5.0,<5 editors/qscintilla \
> >   x11/py-qt4
> >  
> > -RUN_DEPENDS = ${BUILD_DEPENDS} \
> > - devel/py-iniparse \
> > - editors/py-qscintilla
> > +RUN_DEPENDS = devel/py-iniparse \
> > + devel/py-sip \
> > + editors/py-qscintilla \
> > + x11/py-qt4 \
> > + devel/mercurial>=5.0,<5.1
> >  
> >  NO_TEST = Yes
> >  
> > Index: devel/qt-creator/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/qt-creator/Makefile,v
> > retrieving revision 1.53
> > diff -u -p -r1.53 Makefile
> > --- devel/qt-creator/Makefile 12 Jul 2019 20:45:57
> > -0000 1.53 +++ devel/qt-creator/Makefile 11 Feb 2020
> > 13:22:12 -0000 @@ -7,7 +7,7 @@ COMMENT =
> > cross-platform IDE for use wi V = 4.8.2
> >  DISTNAME = qt-creator-opensource-src-${V}
> >  PKGNAME = qt-creator-${V}
> > -REVISION = 3
> > +REVISION = 4
> >  
> >  SHARED_LIBS += Aggregation               0.0 # 0.0
> >  SHARED_LIBS += CPlusPlus                 2.0 # 0.0
> > @@ -60,10 +60,12 @@ BUILD_DEPENDS = x11/qt5/qtquickcontrols
> >   devel/qbs
> >  
> >  RUN_DEPENDS = ${MODGCC4_CPPDEP} \
> > - ${BUILD_DEPENDS} \
> >   devel/gdb \
> >   devel/gmake \
> > + devel/qbs \
> > + lang/clazy>=1.5 \
> >   x11/gtk+3,-guic \
> > + x11/qt5/qtquickcontrols \
> >   x11/qt5/qtquickcontrols \
> >   x11/qt5/qtwebkit
> >  
> > Index: sysutils/slant/Makefile
> > ===================================================================
> > RCS file: /cvs/ports/sysutils/slant/Makefile,v
> > retrieving revision 1.4
> > diff -u -p -r1.4 Makefile
> > --- sysutils/slant/Makefile 24 Nov 2019 14:40:30
> > -0000 1.4 +++ sysutils/slant/Makefile 11 Feb 2020
> > 13:22:12 -0000 @@ -3,7 +3,7 @@
> >  COMMENT = minimal remote system monitor
> >  
> >  DISTNAME = slant-0.0.21
> > -REVISION = 1
> > +REVISION = 2
> >  
> >  CATEGORIES = sysutils
> >  
> > @@ -17,9 +17,9 @@ PERMIT_PACKAGE = Yes
> >  # uses pledge()
> >  WANTLIB += c curses sqlite3 tls z
> >  
> > -BUILD_DEPENDS = databases/ksql \
> > +BUILD_DEPENDS = ${RUN_DEPENDS}
> > +RUN_DEPENDS = databases/ksql \  
> >   www/openradtool>=0.7.4  
> > -RUN_DEPENDS = ${BUILD_DEPENDS}
> >  
> >  LIB_DEPENDS = databases/sqlite3
> >  
> > --
> > jasper  



--
Juan Francisco Cantero Hurtado http://juanfra.info