Portcheck succeeds when no DESCR file

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

Portcheck succeeds when no DESCR file

Brian Callahan-6
Hi ports --

I was working on a new port, and ran portcheck -N before adding a DESCR
file (but after adding a PLIST file). To my surprise, portcheck passed.

Reading through portcheck, there appears to be a check for non-existent
DESCR/PFRAG/PLIST files. But it appears that the error message and the
logic don't sync: the error message leads me to believe the intent was
to catch when any of DESCR/PFRAG/PLIST are missing but the logic instead
catches the situation where all of DESCR/PFRAG/PLIST are missing--if you
have any one of those 3 files, the check passes.

This only seems to matter in the case where you have a PLIST but no
DESCR. If you have no PLIST, portcheck will later fail with this
pkg_create: can't read packing-list /full/path/to/port

The attached diff catches both the have PLIST but no DESCR and the have
DESCR but no PLIST cases. This is my first time looking at portcheck so
if there's a better way, by all means I'm all ears.



portcheck-descr.diff (1K) Download Attachment