Patch to add 2 words to share/dict/web2

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Patch to add 2 words to share/dict/web2

Kurt Mosiejczuk-7
It was annoying me that "aspirational" wasn't in common spellcheck
dictionaries and afresh@ suggested I submit a patch to at least get
the situation corrected for OpenBSD.

Before getting around to this, I noticed "supremacist" wasn't there
either so added that.

Index: share/dict/web2
===================================================================
RCS file: /cvs/src/share/dict/web2,v
retrieving revision 1.8
diff -u -p -r1.8 web2
--- share/dict/web2     16 Dec 2017 13:01:22 -0000      1.8
+++ share/dict/web2     5 Mar 2018 22:02:55 -0000
@@ -14387,6 +14387,7 @@ aspirant
 aspirata
 aspirate
 aspiration
+aspirational
 aspirator
 aspiratory
 aspire
@@ -195461,6 +195462,7 @@ supraventricular
 supraversion
 supravital
 supraworld
+supremacist
 supremacy
 suprematism
 supreme

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

Stuart Henderson
On 2018/03/05 17:14, Kurt Mosiejczuk wrote:
> It was annoying me that "aspirational" wasn't in common spellcheck
> dictionaries and afresh@ suggested I submit a patch to at least get
> the situation corrected for OpenBSD.
>
> Before getting around to this, I noticed "supremacist" wasn't there
> either so added that.

hmm, according to README, this file is supposed to be "Webster's Second
International Dictionary, all 234,936 words worth. The 1934 copyright
has lapsed" ... should additions go in some other file or should the
description be changed? It seems to have grown a bit already,

$ wc -l web2  
  235971 web2

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

STeve Andre'


On 03/05/18 19:16, Stuart Henderson wrote:

> On 2018/03/05 17:14, Kurt Mosiejczuk wrote:
>> It was annoying me that "aspirational" wasn't in common spellcheck
>> dictionaries and afresh@ suggested I submit a patch to at least get
>> the situation corrected for OpenBSD.
>>
>> Before getting around to this, I noticed "supremacist" wasn't there
>> either so added that.
>
> hmm, according to README, this file is supposed to be "Webster's Second
> International Dictionary, all 234,936 words worth. The 1934 copyright
> has lapsed" ... should additions go in some other file or should the
> description be changed? It seems to have grown a bit already,
>
> $ wc -l web2
>    235971 web2
>
>

Definitely it should just grow.  Having multiple files doesn't make
sense, to me.  English is a growing language.

--STeve Andre'

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

Theo de Raadt-2
In reply to this post by Stuart Henderson
> On 2018/03/05 17:14, Kurt Mosiejczuk wrote:
> > It was annoying me that "aspirational" wasn't in common spellcheck
> > dictionaries and afresh@ suggested I submit a patch to at least get
> > the situation corrected for OpenBSD.
> >
> > Before getting around to this, I noticed "supremacist" wasn't there
> > either so added that.
>
> hmm, according to README, this file is supposed to be "Webster's Second
> International Dictionary, all 234,936 words worth. The 1934 copyright
> has lapsed" ... should additions go in some other file or should the
> description be changed? It seems to have grown a bit already,
>
> $ wc -l web2  
>   235971 web2

If we added the complete english language, /usr would be full.

(Already a few people having trouble with multiple upgrades + the
new kernel/library link kits)

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

Kurt Mosiejczuk-7
On Mon, Mar 05, 2018 at 08:07:53PM -0700, Theo de Raadt wrote:

> If we added the complete english language, /usr would be full.

> (Already a few people having trouble with multiple upgrades + the
> new kernel/library link kits)

If we had definitions, I might agree with you that it might fill /usr.
The file is 2.4M though, and even if we got super-studious and doubled
its size, we'd be less than 5M.  It's also not like a library where we
keep the old version around.

That said, this isn't a hill to die on. It bothered me how much we (tech
industry in general) will spend so much space on stupid crap but we have
spellcheckers that only carry a subset of words in use.  I bitched about
it online and someone pointed out I could help do something about it.
So, (eventually) I did.

--Kurt

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

Theo de Raadt-2
In reply to this post by Kurt Mosiejczuk-7
>On Mon, Mar 05, 2018 at 08:07:53PM -0700, Theo de Raadt wrote:
>
>> If we added the complete english language, /usr would be full.
>
>> (Already a few people having trouble with multiple upgrades + the
>> new kernel/library link kits)
>
>If we had definitions, I might agree with you that it might fill /usr.
>The file is 2.4M though, and even if we got super-studious and doubled
>its size, we'd be less than 5M.  It's also not like a library where we
>keep the old version around.
>
>That said, this isn't a hill to die on. It bothered me how much we (tech
>industry in general) will spend so much space on stupid crap but we have
>spellcheckers that only carry a subset of words in use.  I bitched about
>it online and someone pointed out I could help do something about it.
>So, (eventually) I did.

The swahili dictionary is too sparse also.

Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

Chris Bennett-5
On Tue, Mar 06, 2018 at 03:49:49PM +0000, Theo de Raadt wrote:

> >On Mon, Mar 05, 2018 at 08:07:53PM -0700, Theo de Raadt wrote:
> >
> >> If we added the complete english language, /usr would be full.
> >
> >> (Already a few people having trouble with multiple upgrades + the
> >> new kernel/library link kits)
> >
> >If we had definitions, I might agree with you that it might fill /usr.
> >The file is 2.4M though, and even if we got super-studious and doubled
> >its size, we'd be less than 5M.  It's also not like a library where we
> >keep the old version around.
> >
> >That said, this isn't a hill to die on. It bothered me how much we (tech
> >industry in general) will spend so much space on stupid crap but we have
> >spellcheckers that only carry a subset of words in use.  I bitched about
> >it online and someone pointed out I could help do something about it.
> >So, (eventually) I did.
>
> The swahili dictionary is too sparse also.
>

I have to agree. vim-spell-es is missing a ton of common words.
I just ignore it.

Chris Bennett


Reply | Threaded
Open this post in threaded view
|

Re: Patch to add 2 words to share/dict/web2

lists-2
In reply to this post by Kurt Mosiejczuk-7
Tue, 6 Mar 2018 10:46:24 -0500 Kurt Mosiejczuk <[hidden email]>

> On Mon, Mar 05, 2018 at 08:07:53PM -0700, Theo de Raadt wrote:
>
> > If we added the complete english language, /usr would be full.  
>
> > (Already a few people having trouble with multiple upgrades + the
> > new kernel/library link kits)  
>
> [...]
>
> That said, this isn't a hill to die on.

Hi Kurt,

So.. you would not mind if your proposal was met with technical aspects.

> It bothered me how much we (tech
> industry in general) will spend so much space on stupid crap but we have
> spellcheckers that only carry a subset of words in use.

You have a spell checker topic, for dictionary people, also politicians.

> I bitched about
> it online and someone pointed out I could help do something about it.

The process you call bitching is not in the proper maintainer direction.

> So, (eventually) I did.
>
> --Kurt
>

What you propose is filling up the repository log with dictionary edits.

Kind regards,
Anton Lazarov