[Patch] Specify unit for 'every' in ifstated.conf.5

classic Classic list List threaded Threaded
15 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch] Specify unit for 'every' in ifstated.conf.5

Ross L Richardson

The number is in seconds, but that's currently not specified.

Wording which preserved "frequency" but made sense with "seconds"
eluded me, so I changed things to refer to "interval".


Ross
----


Index: ifstated.conf.5
===================================================================
RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
retrieving revision 1.13
diff -u -p -r1.13 ifstated.conf.5
--- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
+++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
@@ -90,7 +90,8 @@ interfaces this equals the init state.
 .Pp
 In contrast to link state tests, external tests must be run periodically to
 evaluate their status.
-The frequency at which an external test is run has to be set with the
+The interval in seconds between invocations of an external test has to
+be set with the
 .Ar every
 keyword.
 .Pp

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:

>
> The number is in seconds, but that's currently not specified.
>
> Wording which preserved "frequency" but made sense with "seconds"
> eluded me, so I changed things to refer to "interval".
>
>
> Ross
> ----
>
>
> Index: ifstated.conf.5
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> retrieving revision 1.13
> diff -u -p -r1.13 ifstated.conf.5
> --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> @@ -90,7 +90,8 @@ interfaces this equals the init state.
>  .Pp
>  In contrast to link state tests, external tests must be run periodically to
>  evaluate their status.
> -The frequency at which an external test is run has to be set with the
> +The interval in seconds between invocations of an external test has to
> +be set with the
>  .Ar every
>  keyword.
>  .Pp
>

hi.

what about like this:

Index: ifstated.conf.5
===================================================================
RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
retrieving revision 1.13
diff -u -r1.13 ifstated.conf.5
--- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
+++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
@@ -90,7 +90,7 @@
 .Pp
 In contrast to link state tests, external tests must be run periodically to
 evaluate their status.
-The frequency at which an external test is run has to be set with the
+The frequency at which an external test is run is set, in seconds, with the
 .Ar every
 keyword.
 .Pp

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Otto Moerbeek
On Thu, Dec 06, 2018 at 05:09:23PM +0000, Jason McIntyre wrote:

> On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> >
> > The number is in seconds, but that's currently not specified.
> >
> > Wording which preserved "frequency" but made sense with "seconds"
> > eluded me, so I changed things to refer to "interval".
> >
> >
> > Ross
> > ----
> >
> >
> > Index: ifstated.conf.5
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > retrieving revision 1.13
> > diff -u -p -r1.13 ifstated.conf.5
> > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> >  .Pp
> >  In contrast to link state tests, external tests must be run periodically to
> >  evaluate their status.
> > -The frequency at which an external test is run has to be set with the
> > +The interval in seconds between invocations of an external test has to
> > +be set with the
> >  .Ar every
> >  keyword.
> >  .Pp
> >
>
> hi.
>
> what about like this:
>
> Index: ifstated.conf.5
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> retrieving revision 1.13
> diff -u -r1.13 ifstated.conf.5
> --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> +++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
> @@ -90,7 +90,7 @@
>  .Pp
>  In contrast to link state tests, external tests must be run periodically to
>  evaluate their status.
> -The frequency at which an external test is run has to be set with the
> +The frequency at which an external test is run is set, in seconds, with the
>  .Ar every
>  keyword.
>  .Pp
>

That should be "period", right?

        -Otto

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote:

> On Thu, Dec 06, 2018 at 05:09:23PM +0000, Jason McIntyre wrote:
>
> > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > >
> > > The number is in seconds, but that's currently not specified.
> > >
> > > Wording which preserved "frequency" but made sense with "seconds"
> > > eluded me, so I changed things to refer to "interval".
> > >
> > >
> > > Ross
> > > ----
> > >
> > >
> > > Index: ifstated.conf.5
> > > ===================================================================
> > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > retrieving revision 1.13
> > > diff -u -p -r1.13 ifstated.conf.5
> > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > >  .Pp
> > >  In contrast to link state tests, external tests must be run periodically to
> > >  evaluate their status.
> > > -The frequency at which an external test is run has to be set with the
> > > +The interval in seconds between invocations of an external test has to
> > > +be set with the
> > >  .Ar every
> > >  keyword.
> > >  .Pp
> > >
> >
> > hi.
> >
> > what about like this:
> >
> > Index: ifstated.conf.5
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > retrieving revision 1.13
> > diff -u -r1.13 ifstated.conf.5
> > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > +++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
> > @@ -90,7 +90,7 @@
> >  .Pp
> >  In contrast to link state tests, external tests must be run periodically to
> >  evaluate their status.
> > -The frequency at which an external test is run has to be set with the
> > +The frequency at which an external test is run is set, in seconds, with the
> >  .Ar every
> >  keyword.
> >  .Pp
> >
>
> That should be "period", right?
>
> -Otto
>

hi otto. i don;t understand the question. what should be "period"?
jmc

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Otto Moerbeek
On Thu, Dec 06, 2018 at 05:22:36PM +0000, Jason McIntyre wrote:

> On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote:
> > On Thu, Dec 06, 2018 at 05:09:23PM +0000, Jason McIntyre wrote:
> >
> > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > > >
> > > > The number is in seconds, but that's currently not specified.
> > > >
> > > > Wording which preserved "frequency" but made sense with "seconds"
> > > > eluded me, so I changed things to refer to "interval".
> > > >
> > > >
> > > > Ross
> > > > ----
> > > >
> > > >
> > > > Index: ifstated.conf.5
> > > > ===================================================================
> > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > retrieving revision 1.13
> > > > diff -u -p -r1.13 ifstated.conf.5
> > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > > >  .Pp
> > > >  In contrast to link state tests, external tests must be run periodically to
> > > >  evaluate their status.
> > > > -The frequency at which an external test is run has to be set with the
> > > > +The interval in seconds between invocations of an external test has to
> > > > +be set with the
> > > >  .Ar every
> > > >  keyword.
> > > >  .Pp
> > > >
> > >
> > > hi.
> > >
> > > what about like this:
> > >
> > > Index: ifstated.conf.5
> > > ===================================================================
> > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > retrieving revision 1.13
> > > diff -u -r1.13 ifstated.conf.5
> > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > +++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
> > > @@ -90,7 +90,7 @@
> > >  .Pp
> > >  In contrast to link state tests, external tests must be run periodically to
> > >  evaluate their status.
> > > -The frequency at which an external test is run has to be set with the
> > > +The frequency at which an external test is run is set, in seconds, with the
> > >  .Ar every
> > >  keyword.
> > >  .Pp
> > >
> >
> > That should be "period", right?
> >
> > -Otto
> >
>
> hi otto. i don;t understand the question. what should be "period"?
> jmc
>

frequency is a word used for occurences per time unit.
period is the time beteen repeating events.

If you talk about the time beteen runs, you're talking about a period.

        -Otto

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
On Thu, Dec 06, 2018 at 06:26:36PM +0100, Otto Moerbeek wrote:

> On Thu, Dec 06, 2018 at 05:22:36PM +0000, Jason McIntyre wrote:
>
> > On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote:
> > > On Thu, Dec 06, 2018 at 05:09:23PM +0000, Jason McIntyre wrote:
> > >
> > > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > > > >
> > > > > The number is in seconds, but that's currently not specified.
> > > > >
> > > > > Wording which preserved "frequency" but made sense with "seconds"
> > > > > eluded me, so I changed things to refer to "interval".
> > > > >
> > > > >
> > > > > Ross
> > > > > ----
> > > > >
> > > > >
> > > > > Index: ifstated.conf.5
> > > > > ===================================================================
> > > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > > retrieving revision 1.13
> > > > > diff -u -p -r1.13 ifstated.conf.5
> > > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > > > >  .Pp
> > > > >  In contrast to link state tests, external tests must be run periodically to
> > > > >  evaluate their status.
> > > > > -The frequency at which an external test is run has to be set with the
> > > > > +The interval in seconds between invocations of an external test has to
> > > > > +be set with the
> > > > >  .Ar every
> > > > >  keyword.
> > > > >  .Pp
> > > > >
> > > >
> > > > hi.
> > > >
> > > > what about like this:
> > > >
> > > > Index: ifstated.conf.5
> > > > ===================================================================
> > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > retrieving revision 1.13
> > > > diff -u -r1.13 ifstated.conf.5
> > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > +++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
> > > > @@ -90,7 +90,7 @@
> > > >  .Pp
> > > >  In contrast to link state tests, external tests must be run periodically to
> > > >  evaluate their status.
> > > > -The frequency at which an external test is run has to be set with the
> > > > +The frequency at which an external test is run is set, in seconds, with the
> > > >  .Ar every
> > > >  keyword.
> > > >  .Pp
> > > >
> > >
> > > That should be "period", right?
> > >
> > > -Otto
> > >
> >
> > hi otto. i don;t understand the question. what should be "period"?
> > jmc
> >
>
> frequency is a word used for occurences per time unit.
> period is the time beteen repeating events.
>
> If you talk about the time beteen runs, you're talking about a period.
>
> -Otto
>

oh.

from a technical (mathematical) point of view, i'm not totally sure.
however substituting "frequency" for "period" in the sentence above will
read very poorly. "frequency" was clear, but maybe that is because i'm
less aware of these differences.

the frequency at which something happens sounds ok to me in this sense.
i was really trying to preserve the original words - ross had complained
of being unable to come up with something that did so.

rereading your words, i feel i don;t really grasp this. can you give an
example?

thanks,
jmc

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Otto Moerbeek
On Thu, Dec 06, 2018 at 05:33:21PM +0000, Jason McIntyre wrote:

> On Thu, Dec 06, 2018 at 06:26:36PM +0100, Otto Moerbeek wrote:
> > On Thu, Dec 06, 2018 at 05:22:36PM +0000, Jason McIntyre wrote:
> >
> > > On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote:
> > > > On Thu, Dec 06, 2018 at 05:09:23PM +0000, Jason McIntyre wrote:
> > > >
> > > > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > > > > >
> > > > > > The number is in seconds, but that's currently not specified.
> > > > > >
> > > > > > Wording which preserved "frequency" but made sense with "seconds"
> > > > > > eluded me, so I changed things to refer to "interval".
> > > > > >
> > > > > >
> > > > > > Ross
> > > > > > ----
> > > > > >
> > > > > >
> > > > > > Index: ifstated.conf.5
> > > > > > ===================================================================
> > > > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > > > retrieving revision 1.13
> > > > > > diff -u -p -r1.13 ifstated.conf.5
> > > > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > > > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > > > > >  .Pp
> > > > > >  In contrast to link state tests, external tests must be run periodically to
> > > > > >  evaluate their status.
> > > > > > -The frequency at which an external test is run has to be set with the
> > > > > > +The interval in seconds between invocations of an external test has to
> > > > > > +be set with the
> > > > > >  .Ar every
> > > > > >  keyword.
> > > > > >  .Pp
> > > > > >
> > > > >
> > > > > hi.
> > > > >
> > > > > what about like this:
> > > > >
> > > > > Index: ifstated.conf.5
> > > > > ===================================================================
> > > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > > retrieving revision 1.13
> > > > > diff -u -r1.13 ifstated.conf.5
> > > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > > +++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
> > > > > @@ -90,7 +90,7 @@
> > > > >  .Pp
> > > > >  In contrast to link state tests, external tests must be run periodically to
> > > > >  evaluate their status.
> > > > > -The frequency at which an external test is run has to be set with the
> > > > > +The frequency at which an external test is run is set, in seconds, with the
> > > > >  .Ar every
> > > > >  keyword.
> > > > >  .Pp
> > > > >
> > > >
> > > > That should be "period", right?
> > > >
> > > > -Otto
> > > >
> > >
> > > hi otto. i don;t understand the question. what should be "period"?
> > > jmc
> > >
> >
> > frequency is a word used for occurences per time unit.
> > period is the time beteen repeating events.
> >
> > If you talk about the time beteen runs, you're talking about a period.
> >
> > -Otto
> >
>
> oh.
>
> from a technical (mathematical) point of view, i'm not totally sure.
> however substituting "frequency" for "period" in the sentence above will
> read very poorly. "frequency" was clear, but maybe that is because i'm
> less aware of these differences.
>
> the frequency at which something happens sounds ok to me in this sense.
> i was really trying to preserve the original words - ross had complained
> of being unable to come up with something that did so.
>
> rereading your words, i feel i don;t really grasp this. can you give an
> example?
>
> thanks,
> jmc
>

The frequency of clock ticks is 60 per minute.
The period of clock ticks is 1 sec.

Whats wrong with

"The period at which an external test is run has to be set, in
seconds, with the every keyword."

But maybe I'm too strict. People often used the term freqency when
they mean period.

        -Otto

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Ted Unangst-6
In reply to this post by Jason McIntyre-2
Jason McIntyre wrote:

> On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> >
> > The number is in seconds, but that's currently not specified.
> >
> > Wording which preserved "frequency" but made sense with "seconds"
> > eluded me, so I changed things to refer to "interval".
> >
> >
> > Ross
> > ----
> >
> >
> > Index: ifstated.conf.5
> > ===================================================================
> > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > retrieving revision 1.13
> > diff -u -p -r1.13 ifstated.conf.5
> > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> >  .Pp
> >  In contrast to link state tests, external tests must be run periodically to
> >  evaluate their status.
> > -The frequency at which an external test is run has to be set with the
> > +The interval in seconds between invocations of an external test has to
> > +be set with the
> >  .Ar every

The interval in seconds between test runs is specified by the required keyword
every.

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
In reply to this post by Otto Moerbeek
On Thu, Dec 06, 2018 at 06:40:28PM +0100, Otto Moerbeek wrote:

> On Thu, Dec 06, 2018 at 05:33:21PM +0000, Jason McIntyre wrote:
>
> > On Thu, Dec 06, 2018 at 06:26:36PM +0100, Otto Moerbeek wrote:
> > > On Thu, Dec 06, 2018 at 05:22:36PM +0000, Jason McIntyre wrote:
> > >
> > > > On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote:
> > > > > On Thu, Dec 06, 2018 at 05:09:23PM +0000, Jason McIntyre wrote:
> > > > >
> > > > > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > > > > > >
> > > > > > > The number is in seconds, but that's currently not specified.
> > > > > > >
> > > > > > > Wording which preserved "frequency" but made sense with "seconds"
> > > > > > > eluded me, so I changed things to refer to "interval".
> > > > > > >
> > > > > > >
> > > > > > > Ross
> > > > > > > ----
> > > > > > >
> > > > > > >
> > > > > > > Index: ifstated.conf.5
> > > > > > > ===================================================================
> > > > > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > > > > retrieving revision 1.13
> > > > > > > diff -u -p -r1.13 ifstated.conf.5
> > > > > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > > > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > > > > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > > > > > >  .Pp
> > > > > > >  In contrast to link state tests, external tests must be run periodically to
> > > > > > >  evaluate their status.
> > > > > > > -The frequency at which an external test is run has to be set with the
> > > > > > > +The interval in seconds between invocations of an external test has to
> > > > > > > +be set with the
> > > > > > >  .Ar every
> > > > > > >  keyword.
> > > > > > >  .Pp
> > > > > > >
> > > > > >
> > > > > > hi.
> > > > > >
> > > > > > what about like this:
> > > > > >
> > > > > > Index: ifstated.conf.5
> > > > > > ===================================================================
> > > > > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > > > > retrieving revision 1.13
> > > > > > diff -u -r1.13 ifstated.conf.5
> > > > > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > > > > +++ ifstated.conf.5 6 Dec 2018 17:08:25 -0000
> > > > > > @@ -90,7 +90,7 @@
> > > > > >  .Pp
> > > > > >  In contrast to link state tests, external tests must be run periodically to
> > > > > >  evaluate their status.
> > > > > > -The frequency at which an external test is run has to be set with the
> > > > > > +The frequency at which an external test is run is set, in seconds, with the
> > > > > >  .Ar every
> > > > > >  keyword.
> > > > > >  .Pp
> > > > > >
> > > > >
> > > > > That should be "period", right?
> > > > >
> > > > > -Otto
> > > > >
> > > >
> > > > hi otto. i don;t understand the question. what should be "period"?
> > > > jmc
> > > >
> > >
> > > frequency is a word used for occurences per time unit.
> > > period is the time beteen repeating events.
> > >
> > > If you talk about the time beteen runs, you're talking about a period.
> > >
> > > -Otto
> > >
> >
> > oh.
> >
> > from a technical (mathematical) point of view, i'm not totally sure.
> > however substituting "frequency" for "period" in the sentence above will
> > read very poorly. "frequency" was clear, but maybe that is because i'm
> > less aware of these differences.
> >
> > the frequency at which something happens sounds ok to me in this sense.
> > i was really trying to preserve the original words - ross had complained
> > of being unable to come up with something that did so.
> >
> > rereading your words, i feel i don;t really grasp this. can you give an
> > example?
> >
> > thanks,
> > jmc
> >
>
> The frequency of clock ticks is 60 per minute.
> The period of clock ticks is 1 sec.
>

thanks, that's what i wanted.

of those two sentences, i'm fine with the first. the second sounds
much odder though. normally you have a period of time, or a long
period, or somesuch. saying simply "period" here is weird, because it's
followed by "of clock ticks", which sounds like it's trying to quantify
the period (a period of ten seconds).

i know US english uses "period" differently in some ways. perhaps that's
more common there. but i would not write it like that.

> Whats wrong with
>
> "The period at which an external test is run has to be set, in
> seconds, with the every keyword."
>

that does sound ok. i don;t hugely like it, but that's probably my bias.
i think in the original text the inference was that there was a
frequency: once, every "every" seconds. hence it read fine.

i would not change what was there like this though.

jmc

> But maybe I'm too strict. People often used the term freqency when
> they mean period.
>
> -Otto
>

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
In reply to this post by Ted Unangst-6
On Thu, Dec 06, 2018 at 01:01:49PM -0500, Ted Unangst wrote:

> Jason McIntyre wrote:
> > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > >
> > > The number is in seconds, but that's currently not specified.
> > >
> > > Wording which preserved "frequency" but made sense with "seconds"
> > > eluded me, so I changed things to refer to "interval".
> > >
> > >
> > > Ross
> > > ----
> > >
> > >
> > > Index: ifstated.conf.5
> > > ===================================================================
> > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > retrieving revision 1.13
> > > diff -u -p -r1.13 ifstated.conf.5
> > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > >  .Pp
> > >  In contrast to link state tests, external tests must be run periodically to
> > >  evaluate their status.
> > > -The frequency at which an external test is run has to be set with the
> > > +The interval in seconds between invocations of an external test has to
> > > +be set with the
> > >  .Ar every
>
> The interval in seconds between test runs is specified by the required keyword
> every.
>

that would be fine too but a) why change frequency, it's not wrong and
b) a "test run" is, well, a test run. but not the same as an external
test.

i honestly think the author's original sentence was fine. it was just
missing the detail of measurement - seconds. the trick is to put that
back into the sentence with as little fuss as possible.

jmc

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Stuart Henderson
In reply to this post by Ted Unangst-6
On 2018/12/06 13:01, Ted Unangst wrote:

> Jason McIntyre wrote:
> > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote:
> > >
> > > The number is in seconds, but that's currently not specified.
> > >
> > > Wording which preserved "frequency" but made sense with "seconds"
> > > eluded me, so I changed things to refer to "interval".
> > >
> > >
> > > Ross
> > > ----
> > >
> > >
> > > Index: ifstated.conf.5
> > > ===================================================================
> > > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> > > retrieving revision 1.13
> > > diff -u -p -r1.13 ifstated.conf.5
> > > --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> > > +++ ifstated.conf.5 6 Dec 2018 11:12:44 -0000
> > > @@ -90,7 +90,8 @@ interfaces this equals the init state.
> > >  .Pp
> > >  In contrast to link state tests, external tests must be run periodically to
> > >  evaluate their status.
> > > -The frequency at which an external test is run has to be set with the
> > > +The interval in seconds between invocations of an external test has to
> > > +be set with the
> > >  .Ar every
>
> The interval in seconds between test runs is specified by the required keyword
> every.
>

That implies "test 2 starts X seconds after the *end* of test 1",
but actually it's "test 2 starts X seconds after the *start* of test 1"
which is what I think the original use of "frequency" was trying to
imply.

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Ross L Richardson

Whilst I agree with Otto (and others), how about making it really simple
by avoiding technical terms?

Ross
----

Index: ifstated.conf.5
===================================================================
RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
retrieving revision 1.13
diff -u -p -r1.13 ifstated.conf.5
--- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
+++ ifstated.conf.5 7 Dec 2018 02:59:43 -0000
@@ -90,7 +90,8 @@ interfaces this equals the init state.
 .Pp
 In contrast to link state tests, external tests must be run periodically to
 evaluate their status.
-The frequency at which an external test is run has to be set with the
+The interval in seconds between (starts of) runs of an external test is set
+with the
 .Ar every
 keyword.
 .Pp

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
On Fri, Dec 07, 2018 at 02:56:03PM +1100, Ross L Richardson wrote:

>
> Whilst I agree with Otto (and others), how about making it really simple
> by avoiding technical terms?
>
> Ross
> ----
>
> Index: ifstated.conf.5
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v
> retrieving revision 1.13
> diff -u -p -r1.13 ifstated.conf.5
> --- ifstated.conf.5 18 Jun 2018 06:04:25 -0000 1.13
> +++ ifstated.conf.5 7 Dec 2018 02:59:43 -0000
> @@ -90,7 +90,8 @@ interfaces this equals the init state.
>  .Pp
>  In contrast to link state tests, external tests must be run periodically to
>  evaluate their status.
> -The frequency at which an external test is run has to be set with the
> +The interval in seconds between (starts of) runs of an external test is set
> +with the
>  .Ar every
>  keyword.
>  .Pp
>

morning.

i'm afraid i think this reads quite poorly - it is hard to actually
understand what is meant.

here's the thing - someone has already written the text. if we want to
change the author's text, i think we need to demonstrate that their text
is wrong, inaccurate, or somehow misleading.

so far, i don;t believe anyone has done this. so i am reluctant to
change the author's words.

in the case of your original submission - the detail about seconds - i
am happy to change things. because there was relevant information
missing.

i think we are wasting time fixing nothing. can't we just add "in
seconds" and get on with it?

jmc

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Ross L Richardson

On Fri, Dec 07, 2018 at 06:42:51AM +0000, Jason McIntyre wrote:

>[...]
>
> morning.
>
> i'm afraid i think this reads quite poorly - it is hard to actually
> understand what is meant.
>
> here's the thing - someone has already written the text. if we want to
> change the author's text, i think we need to demonstrate that their text
> is wrong, inaccurate, or somehow misleading.
>
> so far, i don;t believe anyone has done this. so i am reluctant to
> change the author's words.
>[...]

Fair enough.

The reason I couldn't make it work with "frequency" is that, as Otto
indicated, the second is not a unit of measurement for a frequency.

"tests / second" would be an appropriate unit for a frequency, but that
is _not_ what we are specifying when using "every".  Rather, we are
specifying a "period" - the interval between occurrences of tests.


I'm not trying to complicate this, just trying to explain why "frequency"
is an incorrect term.

Having stated my case, I'm happy to leave the wording to others (if that's
what's preferred).

Thanks,
        Ross

Reply | Threaded
Open this post in threaded view
|

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

Jason McIntyre-2
On Fri, Dec 07, 2018 at 07:48:39PM +1100, Ross L Richardson wrote:

>
> On Fri, Dec 07, 2018 at 06:42:51AM +0000, Jason McIntyre wrote:
> >[...]
> >
> > morning.
> >
> > i'm afraid i think this reads quite poorly - it is hard to actually
> > understand what is meant.
> >
> > here's the thing - someone has already written the text. if we want to
> > change the author's text, i think we need to demonstrate that their text
> > is wrong, inaccurate, or somehow misleading.
> >
> > so far, i don;t believe anyone has done this. so i am reluctant to
> > change the author's words.
> >[...]
>
> Fair enough.
>
> The reason I couldn't make it work with "frequency" is that, as Otto
> indicated, the second is not a unit of measurement for a frequency.
>

the frequency is once, every "every" seconds.
jmc

> "tests / second" would be an appropriate unit for a frequency, but that
> is _not_ what we are specifying when using "every".  Rather, we are
> specifying a "period" - the interval between occurrences of tests.
>
>
> I'm not trying to complicate this, just trying to explain why "frequency"
> is an incorrect term.
>
> Having stated my case, I'm happy to leave the wording to others (if that's
> what's preferred).
>
> Thanks,
> Ross
>