NEW: x11/wmii (version 3)

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

NEW: x11/wmii (version 3)

Tobias Ulmer
Hi,

here's a small port of my favourite window manager. It's a bit like the
well known ion.

Tested on i386 only.

More info and screenshots is available on http://www.wmii.de

Tobias

ps: wmii-3 is not an update for x11/wmi - it's another 'generation' and
works very different.

wmii.tar.gz (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

Will Maier
On Sat, May 27, 2006 at 09:27:20PM +0200, Tobias Ulmer wrote:
> here's a small port of my favourite window manager. It's a bit like the
> well known ion.
>
> Tested on i386 only.

Tested here also on i386-current; packaging and the program itself
work great.

Not quite ready to replace my ion3, though... ;)

--

o--------------------------{ Will Maier }--------------------------o
| jabber:..[hidden email] | [hidden email] |
| freenode:..............lt_kije | freenode:........#madlug,#wilug |
*------------------[ BSD Unix: Live Free or Die ]------------------*

Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

viq .
In reply to this post by Tobias Ulmer
On Saturday 27 May 2006 21:27, Tobias Ulmer wrote:
> Hi,
>
> here's a small port of my favourite window manager. It's a bit like the
> well known ion.
>
> Tested on i386 only.

(i386) It works. I just have to figure out how ;)

> More info and screenshots is available on http://www.wmii.de
>
> Tobias
>
> ps: wmii-3 is not an update for x11/wmi - it's another 'generation' and
> works very different.

--
viq

Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

Jasper Lievisse Adriaanse
In reply to this post by Tobias Ulmer
On Sat, May 27, 2006 at 09:27:20PM +0200, Tobias Ulmer wrote:

> Hi,
>
> here's a small port of my favourite window manager. It's a bit like the
> well known ion.
>
> Tested on i386 only.
>
> More info and screenshots is available on http://www.wmii.de
>
> Tobias
>
> ps: wmii-3 is not an update for x11/wmi - it's another 'generation' and
> works very different.
It works ok here on alpha, powerpc, sgi and sparc64. Though I would
suggest the following diff to:
- format pkg/DESCR to 72 chars wide.
- NO_REGRESS, since there are no regression tests.
- and some more little things, like honoring CFLAGS.

diff -urN wmii.orig/Makefile wmii/Makefile
--- wmii.orig/Makefile Sat May 27 20:25:11 2006
+++ wmii/Makefile Sun May 28 11:58:40 2006
@@ -1,3 +1,5 @@
+# $OpenBSD$
+
 COMMENT= "dynamic window manager"
 
 DISTNAME= wmii-3
@@ -12,14 +14,16 @@
 PERMIT_PACKAGE_FTP= Yes
 PERMIT_DISTFILES_CDROM= Yes
 PERMIT_DISTFILES_FTP= Yes
-WANTLIB= c m X11
+WANTLIB= X11 c m
 
 MASTER_SITES= http://wmii.de/download/
 
 USE_X11= Yes
 
+NO_REGRESS= Yes
+
 post-install:
- mkdir -p ${PREFIX}/share/examples
+ ${INSTALL_DATA_DIR} ${PREFIX}/share/examples
  mv ${WRKINST}/etc/${DISTNAME} ${PREFIX}/share/examples
 
 .include <bsd.port.mk>
diff -urN wmii.orig/patches/patch-config_mk wmii/patches/patch-config_mk
--- wmii.orig/patches/patch-config_mk Sat May 27 19:48:46 2006
+++ wmii/patches/patch-config_mk Sun May 28 11:47:00 2006
@@ -1,5 +1,5 @@
---- config.mk.orig Sat May 27 19:46:49 2006
-+++ config.mk Sat May 27 19:48:03 2006
+--- config.mk.orig Fri May 19 13:20:53 2006
++++ config.mk Sun May 28 11:46:41 2006
 @@ -2,8 +2,8 @@
 
  # paths
@@ -16,7 +16,7 @@
 
  # Linux/BSD
 -CFLAGS = -O2 -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
-+CFLAGS = -Wall -O2 -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
++CFLAGS = -Wall -O2 -pipe -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
  -DVERSION=\"${VERSION}\"
  LDFLAGS = ${LIBS}
 
diff -urN wmii.orig/pkg/DESCR wmii/pkg/DESCR
--- wmii.orig/pkg/DESCR Sat May 27 20:53:12 2006
+++ wmii/pkg/DESCR Sun May 28 11:45:02 2006
@@ -1,4 +1,4 @@
 wmii is a dynamic window manager for X11. It supports classic and
-dynamic window management with extended keyboard, mouse, and
-filesystem based remote control. It replaces the workspace paradigm
-with a new tagging approach.
+dynamic window management with extended keyboard, mouse, and filesystem
+based remote control. It replaces the workspace paradigm with a new
+tagging approach.

Cheers,
Jasper

--
Humppa is a serious thing!

Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

steven mestdagh
Jasper Lievisse Adriaanse [2006-05-28, 12:07:41]:
> - and some more little things, like honoring CFLAGS.
[...]
>  -CFLAGS = -O2 -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
> -+CFLAGS = -Wall -O2 -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
> ++CFLAGS = -Wall -O2 -pipe -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \

This doesn't make sense to me. You are just hardcoding it this way.
CFLAGS should be propagated through the environment or via make(1).
I haven't looked at it, but probably you could put those -I flags in
CPPFLAGS, and skip the definition of CFLAGS here. Then add CPPFLAGS to
the compile command.

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

Tobias Ulmer
In reply to this post by Jasper Lievisse Adriaanse
On Sun, May 28, 2006 at 12:07:41PM +0200, Jasper Lievisse Adriaanse wrote:

> On Sat, May 27, 2006 at 09:27:20PM +0200, Tobias Ulmer wrote:
> > Hi,
> >
> > here's a small port of my favourite window manager. It's a bit like the
> > well known ion.
> >
> > Tested on i386 only.
> >
> > More info and screenshots is available on http://www.wmii.de
> >
> > Tobias
> >
> > ps: wmii-3 is not an update for x11/wmi - it's another 'generation' and
> > works very different.
> It works ok here on alpha, powerpc, sgi and sparc64. Though I would
> suggest the following diff to:
> - format pkg/DESCR to 72 chars wide.
I did, if it wasn't, then there is a bug in fmt ;) I think removing the
name of the application in pkg/DESCR is a matter of taste, most ports i've
checked include it.

> - NO_REGRESS, since there are no regression tests.
:)

> - and some more little things, like honoring CFLAGS.
Doesn't work like steven pointed out, fixed it in another way. Plus
some other small things like forgeting $OpenBSD$...

> [...]
>
> Cheers,
> Jasper
>
> --
> Humppa is a serious thing!
>
>

Thanks for testing jasper.

Here is the new diff, the complete thingie is attached.

diff -ur wmii.orig/Makefile wmii/Makefile
--- wmii.orig/Makefile Sat May 27 20:25:11 2006
+++ wmii/Makefile Sun May 28 13:28:36 2006
@@ -1,3 +1,5 @@
+# $OpenBSD$
+
 COMMENT= "dynamic window manager"
 
 DISTNAME= wmii-3
@@ -18,8 +20,10 @@
 
 USE_X11= Yes
 
+NO_REGRESS= Yes
+
 post-install:
- mkdir -p ${PREFIX}/share/examples
- mv ${WRKINST}/etc/${DISTNAME} ${PREFIX}/share/examples
+ ${INSTALL_DATA_DIR} ${PREFIX}/share/examples
+ mv ${WRKINST}${SYSCONFDIR}/${DISTNAME} ${PREFIX}/share/examples
 
 .include <bsd.port.mk>
diff -ur wmii.orig/patches/patch-config_mk wmii/patches/patch-config_mk
--- wmii.orig/patches/patch-config_mk Sat May 27 19:48:46 2006
+++ wmii/patches/patch-config_mk Sun May 28 13:25:35 2006
@@ -1,5 +1,5 @@
---- config.mk.orig Sat May 27 19:46:49 2006
-+++ config.mk Sat May 27 19:48:03 2006
+--- config.mk.orig Fri May 19 13:20:53 2006
++++ config.mk Sun May 28 13:25:02 2006
 @@ -2,8 +2,8 @@
 
  # paths
@@ -16,7 +16,7 @@
 
  # Linux/BSD
 -CFLAGS = -O2 -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
-+CFLAGS = -Wall -O2 -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
++CFLAGS+= -I. -I${PREFIX}/include -I/usr/include -I${X11INC} \
  -DVERSION=\"${VERSION}\"
  LDFLAGS = ${LIBS}
 

Tobias

wmii.tar.gz (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

steven mestdagh
Tobias Ulmer [2006-05-28, 13:51:18]:
>  post-install:
> - mkdir -p ${PREFIX}/share/examples
> - mv ${WRKINST}/etc/${DISTNAME} ${PREFIX}/share/examples
> + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples
> + mv ${WRKINST}${SYSCONFDIR}/${DISTNAME} ${PREFIX}/share/examples

these look like scripts, so use ${INSTALL_SCRIPT}.

you could also substitute something like !!SYSCONFDIR!! in your patch
instead of hardcoding /etc there.

CC strlcat.c
CC strlcpy.c
CC strtonum.c

these functions are in libc. i think you can also replace their estrdup
with our strdup(3).

seems to work on sparc64.

steven

Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm

Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

Tobias Ulmer
On Mon, May 29, 2006 at 12:11:14AM +0200, steven mestdagh wrote:
> Tobias Ulmer [2006-05-28, 13:51:18]:
> >  post-install:
> > - mkdir -p ${PREFIX}/share/examples
> > - mv ${WRKINST}/etc/${DISTNAME} ${PREFIX}/share/examples
> > + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples
> > + mv ${WRKINST}${SYSCONFDIR}/${DISTNAME} ${PREFIX}/share/examples
>
> these look like scripts, so use ${INSTALL_SCRIPT}.

They are installed with correct mode, but in the wrong location. I
therefore considered mv a better choice than 4 ${INSTALL_SCRIPT} lines and
1 to delete the files (to silence update-plist).

@mode 755  in PLIST is needed because @sample ignores the mode. Maybe
that's unexpected behaviour?

>
> you could also substitute something like !!SYSCONFDIR!! in your patch
> instead of hardcoding /etc there.

SYSCONFIG is not defined for the install target. I've worked around it
by using FAKE_FLAGS. Not very nice but it works.

>
> CC strlcat.c
> CC strlcpy.c
> CC strtonum.c

done

>
> these functions are in libc. i think you can also replace their estrdup
> with our strdup(3).
>

the estrdup includes error-checking (by using emallocz), so no

> seems to work on sparc64.
>
> steven
>
> Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm
>
>

thx for testing

Tobias

wmii.tar.gz (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: x11/wmii (version 3)

Tobias Ulmer
On Mon, May 29, 2006 at 03:44:16AM +0200, Tobias Ulmer wrote:

> On Mon, May 29, 2006 at 12:11:14AM +0200, steven mestdagh wrote:
> > Tobias Ulmer [2006-05-28, 13:51:18]:
> > >  post-install:
> > > - mkdir -p ${PREFIX}/share/examples
> > > - mv ${WRKINST}/etc/${DISTNAME} ${PREFIX}/share/examples
> > > + ${INSTALL_DATA_DIR} ${PREFIX}/share/examples
> > > + mv ${WRKINST}${SYSCONFDIR}/${DISTNAME} ${PREFIX}/share/examples
> >
> > these look like scripts, so use ${INSTALL_SCRIPT}.
>
> They are installed with correct mode, but in the wrong location. I
> therefore considered mv a better choice than 4 ${INSTALL_SCRIPT} lines and
> 1 to delete the files (to silence update-plist).
>
> @mode 755  in PLIST is needed because @sample ignores the mode. Maybe
> that's unexpected behaviour?
>
> >
> > you could also substitute something like !!SYSCONFDIR!! in your patch
> > instead of hardcoding /etc there.
>
> SYSCONFIG is not defined for the install target. I've worked around it
> by using FAKE_FLAGS. Not very nice but it works.
>
> >
> > CC strlcat.c
> > CC strlcpy.c
> > CC strtonum.c
>
> done
>
> >
> > these functions are in libc. i think you can also replace their estrdup
> > with our strdup(3).
> >
>
> the estrdup includes error-checking (by using emallocz), so no
>
> > seems to work on sparc64.
> >
> > steven
> >
> > Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm
> >
> >
>
> thx for testing
>
> Tobias

Anyone going to import this port? I just got a mail about why this
isn't in the ports tree yet ;)

Tobias