[NEW] mail/aerc 0.4.0

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[NEW] mail/aerc 0.4.0

Raymond E. Pasco
With the arrival of the new Go ports tools, I wanted to try mail/aerc
again. Here's my attempt. Notes:

- Because upstream uses git tags like 0.4.0 instead of v0.4.0,
  proxy.golang.org relegates him to v0.0.0-longsuffix hell instead of
  letting him use real versions. I have no opinion on this important
  bikeshed, but the MODGO_VERSION you see here is in fact 0.4.0.

- portgen go based its module list on go.mod from the only version it
  was able to fetch, the latest commit, but I changed the modules back
  to what they were in 0.4.0.

- The previous time around, with a vendor directory, I was able to patch
  the go-libvterm module to link against devel/libvterm instead of
  bringing along its own libvterm. I am no longer quite sure how to do
  this with the newer Go ports tools because patches apply to WRKDIST,
  which doesn't resolve to a directory that actually exists at any point
  during the build; if I come up with a fix I'll email it here.

aerc-0.4.0.tar.gz (11K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [NEW] mail/aerc 0.4.0

Raymond E. Pasco
On Thu Jul 30, 2020 at 12:35 AM EDT, Raymond E. Pasco wrote:
> - The previous time around, with a vendor directory, I was able to patch
> the go-libvterm module to link against devel/libvterm instead of
> bringing along its own libvterm. I am no longer quite sure how to do
> this with the newer Go ports tools because patches apply to WRKDIST,
> which doesn't resolve to a directory that actually exists at any point
> during the build; if I come up with a fix I'll email it here.

Oh, and the way the build works, it doesn't actually "download" the
modules from /usr/ports/distfiles until after patch anyway. If we had
patching capability on the main distribution, maybe we could patch its
go.mod to use an alternate module that properly uses cgo pkg-config.

This ecosystem is a real headache. :)

Reply | Threaded
Open this post in threaded view
|

Re: [NEW] mail/aerc 0.4.0

Raymond E. Pasco
This diff should fix WRKDIST and enable go ports to be patched again.

diff --git a/lang/go/go.port.mk b/lang/go/go.port.mk
index 0d254934f32..32a367a29bb 100644
--- a/lang/go/go.port.mk
+++ b/lang/go/go.port.mk
@@ -107,6 +107,7 @@ MODGO_SETUP_WORKSPACE = mkdir -p ${WRKSRC:H}; mv ${MODGO_SUBDIR} ${WRKSRC};
 WRKSRC ?= ${WRKDIR}/${MODGO_MODNAME}@${MODGO_VERSION}
 MODGO_SETUP_WORKSPACE = ln -sf ${WRKSRC} ${WRKDIR}/${MODGO_MODNAME}
 .endif
+WRKDIST = ${WRKSRC}
 
 INSTALL_STRIP =
 .if ${MODGO_TYPE:L:Mbin}
--
2.27.0

Reply | Threaded
Open this post in threaded view
|

Re: [NEW] mail/aerc 0.4.0

Raymond E. Pasco
On Fri Jul 31, 2020 at 7:28 AM EDT, Raymond E. Pasco wrote:
> This diff should fix WRKDIST and enable go ports to be patched again.

And, dependent on that diff, the attached port replaces go-libvterm with
a properly dynamic-linking go-libvterm, and depends on devel/libvterm
from ports.

aerc-0.4.0.tar.gz (12K) Download Attachment