NEW: devel/p5-Module-Build

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

NEW: devel/p5-Module-Build

Stuart Henderson-6
Module::Build currently triggers warnings unless installed from CPAN,
and will be removed from a future version of Perl. I'd like to prepare
by (re)importing devel/p5-Module-Build and switching to using it.

tgz attached, diff below makes use of it. Quirks and Module::Install
clues came from nigel@ (there are some other things to handle at some
point with Module::Install, but that's separate to this work).

This has successfully been through a bulk build.

OK to import/switch?


Index: infrastructure/mk/perl.port.mk
===================================================================
RCS file: /cvs/ports/infrastructure/mk/perl.port.mk,v
retrieving revision 1.24
diff -u -p -r1.24 perl.port.mk
--- infrastructure/mk/perl.port.mk 10 Aug 2014 08:59:48 -0000 1.24
+++ infrastructure/mk/perl.port.mk 13 Apr 2015 16:45:31 -0000
@@ -21,6 +21,7 @@ MODPERL_pre-configure = for f in ${MODPE
 .endif
 
 .if ${CONFIGURE_STYLE:L:Mmodbuild}
+BUILD_DEPENDS += devel/p5-Module-Build
 MODPERL_configure = \
  arch=`perl -e 'use Config; print $$Config{archname}, "\n";'`; \
     cd ${WRKSRC}; ${_SYSTRACE_CMD} ${SETENV} ${CONFIGURE_ENV} \
Index: devel/quirks/Makefile
===================================================================
RCS file: /cvs/ports/devel/quirks/Makefile,v
retrieving revision 1.218
diff -u -p -r1.218 Makefile
--- devel/quirks/Makefile 6 Apr 2015 15:13:01 -0000 1.218
+++ devel/quirks/Makefile 13 Apr 2015 16:45:31 -0000
@@ -5,7 +5,7 @@ CATEGORIES = devel databases
 DISTFILES =
 
 # API.rev
-PKGNAME = quirks-2.64
+PKGNAME = quirks-2.65
 PKG_ARCH = *
 MAINTAINER = Marc Espie <[hidden email]>
 
Index: devel/quirks/files/Quirks.pm
===================================================================
RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v
retrieving revision 1.227
diff -u -p -r1.227 Quirks.pm
--- devel/quirks/files/Quirks.pm 6 Apr 2015 15:40:31 -0000 1.227
+++ devel/quirks/files/Quirks.pm 13 Apr 2015 16:45:31 -0000
@@ -73,7 +73,6 @@ my $base_exceptions = {
  'p5-ExtUtils-CBuilder' => "$p5/ExtUtils/CBuilder.pm",
  'p5-ExtUtils-ParseXS' => "$p5/ExtUtils/ParseXS.pm",
  'p5-Locale-Maketext-Simple' => "$p5/Locale/Maketext/Simple.pm",
- 'p5-Module-Build' =>  "$p5/Module/Build.pm",
  'p5-Module-CoreList' => "$p5/Module/CoreList.pm",
  'p5-Module-Load' => "$p5/Module/Load.pm",
  'p5-Module-Loaded' => "$p5/Module/Loaded.pm",

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Module-Install/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile 5 Apr 2014 11:56:10 -0000 1.21
+++ Makefile 13 Apr 2015 16:49:14 -0000
@@ -4,7 +4,7 @@ COMMENT=        standalone extensible Pe
 
 MODULES= cpan
 DISTNAME= Module-Install-1.08
-REVISION= 0
+REVISION= 1
 CATEGORIES=     devel
 
 MAINTAINER= Simon Bertrang <[hidden email]>
@@ -12,7 +12,8 @@ MAINTAINER= Simon Bertrang <simon@openbs
 # perl
 PERMIT_PACKAGE_CDROM=   Yes
 
-RUN_DEPENDS= devel/p5-Module-ScanDeps>=1.13 \
+RUN_DEPENDS= devel/p5-Module-Build \
+ devel/p5-Module-ScanDeps>=1.13 \
  devel/p5-File-Remove \
  devel/p5-PAR-Dist \
  devel/p5-YAML-Tiny>=1.38 \
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/p5-Module-Install/pkg/PLIST,v
retrieving revision 1.4
diff -u -p -r1.4 PLIST
--- pkg/PLIST 7 Apr 2012 20:57:18 -0000 1.4
+++ pkg/PLIST 13 Apr 2015 16:49:14 -0000
@@ -38,7 +38,6 @@ ${P5SITE}/Module/Install/Share.pm
 ${P5SITE}/Module/Install/Win32.pm
 ${P5SITE}/Module/Install/With.pm
 ${P5SITE}/Module/Install/WriteAll.pm
-${P5SITE}/inc/
 ${P5SITE}/inc/Module/
 ${P5SITE}/inc/Module/Install/
 ${P5SITE}/inc/Module/Install.pm

modbuild.tgz (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/p5-Module-Build

Nigel J Taylor
On 04/13/15 17:52, Stuart Henderson wrote:

> Module::Build currently triggers warnings unless installed from
> CPAN, and will be removed from a future version of Perl. I'd like
> to prepare by (re)importing devel/p5-Module-Build and switching to
> using it.
>
> tgz attached, diff below makes use of it. Quirks and
> Module::Install clues came from nigel@ (there are some other things
> to handle at some point with Module::Install, but that's separate
> to this work).
>
> This has successfully been through a bulk build.
>
> OK to import/switch?

p5-Module-Install needs to be >= 1.10 for later things, current
version is 1.14 which I use. Remove the Maintainer.


My p5-Module-Build Makefile...

# $OpenBSD: Makefile.template,v 1.71 2014/07/10 12:33:17 sthen Exp $

COMMENT =               Module build

DISTNAME =              Module-Build-0.4208
PKGNAME =               p5-Module-Build-0.42.08
CATEGORIES =            devel

# Perl
PERMIT_PACKAGE_CDROM =  Yes

MODULES =               cpan

TEST_DEPENDS +=         devel/p5-PAR-Dist>=0.17

# TODO this works but messy...
do-install:
        cd ${WRKSRC} && \
        ./Build --preifx ${TRUEPREFIX} --destdir=${WRKINST} \
        --config installarchlib=${P5SITE}/amd64-openbsd \
        --config installsitearch=${P5SITE}/amd64-openbsd \
        install

.include <bsd.port.mk>

I thought mine was messy, looks Simpler, I used d.dd.dd version
follows their past releases numbering, else hit EPOCH issues. or could
pad out with trailing zeros if required if using d.dddd.



>
>
> Index: infrastructure/mk/perl.port.mk
> ===================================================================
>
>
RCS file: /cvs/ports/infrastructure/mk/perl.port.mk,v

> retrieving revision 1.24 diff -u -p -r1.24 perl.port.mk ---
> infrastructure/mk/perl.port.mk 10 Aug 2014 08:59:48 -0000 1.24 +++
> infrastructure/mk/perl.port.mk 13 Apr 2015 16:45:31 -0000 @@ -21,6
> +21,7 @@ MODPERL_pre-configure = for f in ${MODPE .endif
>
> .if ${CONFIGURE_STYLE:L:Mmodbuild} +BUILD_DEPENDS +=
> devel/p5-Module-Build MODPERL_configure = \ arch=`perl -e 'use
> Config; print $$Config{archname}, "\n";'`; \ cd ${WRKSRC};
> ${_SYSTRACE_CMD} ${SETENV} ${CONFIGURE_ENV} \ Index:
> devel/quirks/Makefile
> ===================================================================
>
>
RCS file: /cvs/ports/devel/quirks/Makefile,v

> retrieving revision 1.218 diff -u -p -r1.218 Makefile ---
> devel/quirks/Makefile 6 Apr 2015 15:13:01 -0000 1.218 +++
> devel/quirks/Makefile 13 Apr 2015 16:45:31 -0000 @@ -5,7 +5,7 @@
> CATEGORIES = devel databases DISTFILES =
>
> # API.rev -PKGNAME = quirks-2.64 +PKGNAME = quirks-2.65 PKG_ARCH =
> * MAINTAINER = Marc Espie <[hidden email]>
>
> Index: devel/quirks/files/Quirks.pm
> ===================================================================
>
>
RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v

> retrieving revision 1.227 diff -u -p -r1.227 Quirks.pm ---
> devel/quirks/files/Quirks.pm 6 Apr 2015 15:40:31 -0000 1.227 +++
> devel/quirks/files/Quirks.pm 13 Apr 2015 16:45:31 -0000 @@ -73,7
> +73,6 @@ my $base_exceptions = { 'p5-ExtUtils-CBuilder' =>
> "$p5/ExtUtils/CBuilder.pm", 'p5-ExtUtils-ParseXS' =>
> "$p5/ExtUtils/ParseXS.pm", 'p5-Locale-Maketext-Simple' =>
> "$p5/Locale/Maketext/Simple.pm", - 'p5-Module-Build' =>
> "$p5/Module/Build.pm", 'p5-Module-CoreList' =>
> "$p5/Module/CoreList.pm", 'p5-Module-Load' =>
> "$p5/Module/Load.pm", 'p5-Module-Loaded' =>
> "$p5/Module/Loaded.pm",
>
> Index: Makefile
> ===================================================================
>
>
RCS file: /cvs/ports/devel/p5-Module-Install/Makefile,v

> retrieving revision 1.21 diff -u -p -r1.21 Makefile --- Makefile 5
> Apr 2014 11:56:10 -0000 1.21 +++ Makefile 13 Apr 2015 16:49:14
> -0000 @@ -4,7 +4,7 @@ COMMENT=        standalone extensible Pe
>
> MODULES= cpan DISTNAME= Module-Install-1.08 -REVISION= 0 +REVISION=
> 1 CATEGORIES=     devel
>
> MAINTAINER= Simon Bertrang <[hidden email]> @@ -12,7 +12,8 @@
> MAINTAINER= Simon Bertrang <simon@openbs # perl
> PERMIT_PACKAGE_CDROM=   Yes
>
> -RUN_DEPENDS= devel/p5-Module-ScanDeps>=1.13 \ +RUN_DEPENDS=
> devel/p5-Module-Build \ + devel/p5-Module-ScanDeps>=1.13 \
> devel/p5-File-Remove \ devel/p5-PAR-Dist \ devel/p5-YAML-Tiny>=1.38
> \ Index: pkg/PLIST
> ===================================================================
>
>
RCS file: /cvs/ports/devel/p5-Module-Install/pkg/PLIST,v
> retrieving revision 1.4 diff -u -p -r1.4 PLIST --- pkg/PLIST 7 Apr
> 2012 20:57:18 -0000 1.4 +++ pkg/PLIST 13 Apr 2015 16:49:14 -0000 @@
> -38,7 +38,6 @@ ${P5SITE}/Module/Install/Share.pm
> ${P5SITE}/Module/Install/Win32.pm ${P5SITE}/Module/Install/With.pm
> ${P5SITE}/Module/Install/WriteAll.pm -${P5SITE}/inc/
> ${P5SITE}/inc/Module/ ${P5SITE}/inc/Module/Install/
> ${P5SITE}/inc/Module/Install.pm
>

Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/p5-Module-Build

Stuart Henderson-10
On 2015/04/13 18:40, Nigel J Taylor wrote:
> p5-Module-Install needs to be >= 1.10 for later things, current
> version is 1.14 which I use. Remove the Maintainer.

At this stage, p5-Module-Install is just a distraction.

> I thought mine was messy, looks Simpler

Mine uses the same stanza that's in perl.port.mk for CONFIGURE_STYLE=modbuild.
I should probably add a comment to that effect (both in perl.port.mk and in
p5-Module-Build's Makefile).

> I used d.dd.dd version
> follows their past releases numbering, else hit EPOCH issues. or could
> pad out with trailing zeros if required if using d.dddd.

We can just keep bumping EPOCH, it's not a problem.

Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/p5-Module-Build

Stuart Henderson-6
On 2015/04/13 19:25, Stuart Henderson wrote:
> Mine uses the same stanza that's in perl.port.mk for CONFIGURE_STYLE=modbuild.
> I should probably add a comment to that effect (both in perl.port.mk and in
> p5-Module-Build's Makefile).

Updated with this in.

Any OKs to import?


modbuild.tgz (1K) Download Attachment