NEW: devel/catch2

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

NEW: devel/catch2

Rafael Sadowski
Please find attached catch2.

https://github.com/catchorg/Catch2

$ pkg/DESCR
Catch2 stands for C++ Automated Test Cases in a Header and is a multi-paradigm
test framework for C++. which also supports Objective-C (and maybe C). It is
primarily distributed as a single header file, although certain extensions may
require additional headers.

Test results:

Test project /usr/ports/pobj/catch2-2.0.1/build-amd64
    Start 1: RunTests
1/4 Test #1: RunTests .........................   Passed    0.02 sec
    Start 2: ListTests
2/4 Test #2: ListTests ........................   Passed    0.01 sec
    Start 3: ListTags
3/4 Test #3: ListTags .........................   Passed    0.00 sec
    Start 4: ApprovalTests
4/4 Test #4: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.55 sec

75% tests passed, 1 tests failed out of 4


Ok to import?

catch2.tar.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/catch2

Rafael Sadowski
On Tue Jan 02, 2018 at 10:22:19PM +0100, Rafael Sadowski wrote:

> Please find attached catch2.
>
> https://github.com/catchorg/Catch2
>
> $ pkg/DESCR
> Catch2 stands for C++ Automated Test Cases in a Header and is a multi-paradigm
> test framework for C++. which also supports Objective-C (and maybe C). It is
> primarily distributed as a single header file, although certain extensions may
> require additional headers.
>
> Test results:
>
> Test project /usr/ports/pobj/catch2-2.0.1/build-amd64
>     Start 1: RunTests
> 1/4 Test #1: RunTests .........................   Passed    0.02 sec
>     Start 2: ListTests
> 2/4 Test #2: ListTests ........................   Passed    0.01 sec
>     Start 3: ListTags
> 3/4 Test #3: ListTags .........................   Passed    0.00 sec
>     Start 4: ApprovalTests
> 4/4 Test #4: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.55 sec
>
> 75% tests passed, 1 tests failed out of 4
>
>
> Ok to import?
New version 2.1.0 attached as a tarball.

Test project /usr/ports/pobj/catch2-2.1.0/build-amd64
    Start 1: RunTests
1/6 Test #1: RunTests .........................   Passed    0.02 sec
    Start 2: ListTests
2/6 Test #2: ListTests ........................   Passed    0.01 sec
    Start 3: ListTags
3/6 Test #3: ListTags .........................   Passed    0.01 sec
    Start 4: ListReporters
4/6 Test #4: ListReporters ....................   Passed    0.00 sec
    Start 5: ListTestNamesOnly
5/6 Test #5: ListTestNamesOnly ................   Passed    0.01 sec
    Start 6: ApprovalTests
6/6 Test #6: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.68 sec

83% tests passed, 1 tests failed out of 6

Any objections to import?

Rafael

catch2.tar.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/catch2

Rafael Sadowski
ping, anyone?

On Thu Jan 11, 2018 at 10:32:23PM +0100, Rafael Sadowski wrote:

> On Tue Jan 02, 2018 at 10:22:19PM +0100, Rafael Sadowski wrote:
> > Please find attached catch2.
> >
> > https://github.com/catchorg/Catch2
> >
> > $ pkg/DESCR
> > Catch2 stands for C++ Automated Test Cases in a Header and is a multi-paradigm
> > test framework for C++. which also supports Objective-C (and maybe C). It is
> > primarily distributed as a single header file, although certain extensions may
> > require additional headers.
> >
> > Test results:
> >
> > Test project /usr/ports/pobj/catch2-2.0.1/build-amd64
> >     Start 1: RunTests
> > 1/4 Test #1: RunTests .........................   Passed    0.02 sec
> >     Start 2: ListTests
> > 2/4 Test #2: ListTests ........................   Passed    0.01 sec
> >     Start 3: ListTags
> > 3/4 Test #3: ListTags .........................   Passed    0.00 sec
> >     Start 4: ApprovalTests
> > 4/4 Test #4: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.55 sec
> >
> > 75% tests passed, 1 tests failed out of 4
> >
> >
> > Ok to import?
>
> New version 2.1.0 attached as a tarball.
>
> Test project /usr/ports/pobj/catch2-2.1.0/build-amd64
>     Start 1: RunTests
> 1/6 Test #1: RunTests .........................   Passed    0.02 sec
>     Start 2: ListTests
> 2/6 Test #2: ListTests ........................   Passed    0.01 sec
>     Start 3: ListTags
> 3/6 Test #3: ListTags .........................   Passed    0.01 sec
>     Start 4: ListReporters
> 4/6 Test #4: ListReporters ....................   Passed    0.00 sec
>     Start 5: ListTestNamesOnly
> 5/6 Test #5: ListTestNamesOnly ................   Passed    0.01 sec
>     Start 6: ApprovalTests
> 6/6 Test #6: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.68 sec
>
> 83% tests passed, 1 tests failed out of 6
>
> Any objections to import?
>
> Rafael


Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/catch2

Klemens Nanni
In reply to this post by Rafael Sadowski
On Thu, Jan 11, 2018 at 10:32:23PM +0100, Rafael Sadowski wrote:

> On Tue Jan 02, 2018 at 10:22:19PM +0100, Rafael Sadowski wrote:
> > Please find attached catch2.
> >
> > https://github.com/catchorg/Catch2
> >
> > $ pkg/DESCR
> > Catch2 stands for C++ Automated Test Cases in a Header and is a multi-paradigm
> > test framework for C++. which also supports Objective-C (and maybe C). It is
> > primarily distributed as a single header file, although certain extensions may
> > require additional headers.

> New version 2.1.0 attached as a tarball.
>
> Test project /usr/ports/pobj/catch2-2.1.0/build-amd64
>     Start 1: RunTests
> 1/6 Test #1: RunTests .........................   Passed    0.02 sec
>     Start 2: ListTests
> 2/6 Test #2: ListTests ........................   Passed    0.01 sec
>     Start 3: ListTags
> 3/6 Test #3: ListTags .........................   Passed    0.01 sec
>     Start 4: ListReporters
> 4/6 Test #4: ListReporters ....................   Passed    0.00 sec
>     Start 5: ListTestNamesOnly
> 5/6 Test #5: ListTestNamesOnly ................   Passed    0.01 sec
>     Start 6: ApprovalTests
> 6/6 Test #6: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.68 sec
>
> 83% tests passed, 1 tests failed out of 6
>
> Any objections to import?
Same test results here. I don't use Catch2 but here's an updated port
with the following fixes:

Drop DISTNAME as it's autogenerated by GH_* and stick to "Catch2" (with
capital C) as that's the project's proper name.

Add missing license version (see http://www.boost.org/users/history/).

Fixing hardcoded `python' invocations with sed in pre-configure always
seems dirty to me, we have patches and SUBST_CMD for that. But since
all scripts use `#!/usr/bin/env python' as shebang just symlink
MODPY_BIN into PORTPATH here.

Python 3 works fine so use that (afaik the policy is to not import
further Python 2 ports). As Python is used for tests only, drop it from
BDEP and RDEP as well.

Looks good to me otherwise.

Catch2.tgz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/catch2

Brian Callahan-3


On 1/23/2018 6:31 PM, Klemens Nanni wrote:

> On Thu, Jan 11, 2018 at 10:32:23PM +0100, Rafael Sadowski wrote:
>> On Tue Jan 02, 2018 at 10:22:19PM +0100, Rafael Sadowski wrote:
>>> Please find attached catch2.
>>>
>>> https://github.com/catchorg/Catch2
>>>
>>> $ pkg/DESCR
>>> Catch2 stands for C++ Automated Test Cases in a Header and is a multi-paradigm
>>> test framework for C++. which also supports Objective-C (and maybe C). It is
>>> primarily distributed as a single header file, although certain extensions may
>>> require additional headers.
>> New version 2.1.0 attached as a tarball.
>>
>> Test project /usr/ports/pobj/catch2-2.1.0/build-amd64
>>     Start 1: RunTests
>> 1/6 Test #1: RunTests .........................   Passed    0.02 sec
>>     Start 2: ListTests
>> 2/6 Test #2: ListTests ........................   Passed    0.01 sec
>>     Start 3: ListTags
>> 3/6 Test #3: ListTags .........................   Passed    0.01 sec
>>     Start 4: ListReporters
>> 4/6 Test #4: ListReporters ....................   Passed    0.00 sec
>>     Start 5: ListTestNamesOnly
>> 5/6 Test #5: ListTestNamesOnly ................   Passed    0.01 sec
>>     Start 6: ApprovalTests
>> 6/6 Test #6: ApprovalTests ....................***Failed  Error regular expression found in output. Regex=[Results differed]  0.68 sec
>>
>> 83% tests passed, 1 tests failed out of 6
>>
>> Any objections to import?
> Same test results here. I don't use Catch2 but here's an updated port
> with the following fixes:
>
> Drop DISTNAME as it's autogenerated by GH_* and stick to "Catch2" (with
> capital C) as that's the project's proper name.

Why capitalize this, outside of GH_PROJECT? Just to take one random
example, Python's proper name is Python and yet it's lowercase in
ports/packages. The same is true for thousands of ports, so I don't see
why this one needs to be special. There are also no capital letters in
pkg/PLIST (catch.hpp and catch.pc, for example).

~Brian

> Add missing license version (see http://www.boost.org/users/history/).
>
> Fixing hardcoded `python' invocations with sed in pre-configure always
> seems dirty to me, we have patches and SUBST_CMD for that. But since
> all scripts use `#!/usr/bin/env python' as shebang just symlink
> MODPY_BIN into PORTPATH here.
>
> Python 3 works fine so use that (afaik the policy is to not import
> further Python 2 ports). As Python is used for tests only, drop it from
> BDEP and RDEP as well.
>
> Looks good to me otherwise.

Reply | Threaded
Open this post in threaded view
|

Re: NEW: devel/catch2

Klemens Nanni
On Tue, Jan 23, 2018 at 06:39:12PM -0500, Brian Callahan wrote:
> On 1/23/2018 6:31 PM, Klemens Nanni wrote:
> > Drop DISTNAME as it's autogenerated by GH_* and stick to "Catch2" (with
> > capital C) as that's the project's proper name.
>
> Why capitalize this, outside of GH_PROJECT? Just to take one random
> example, Python's proper name is Python and yet it's lowercase in
> ports/packages. The same is true for thousands of ports, so I don't see
> why this one needs to be special. There are also no capital letters in
> pkg/PLIST (catch.hpp and catch.pc, for example).
Not renaming the port's name seems cleaner to me unless really necessary
or desired, such as for highly popular ports like Python. It's a
personal preference in the end, I left it as is to keep the port simple.