Fix for vitetris desktop file

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix for vitetris desktop file

Micah Muer-2
The desktop file that ships with vitetris
(/usr/local/share/applications/vitetris.desktop) has the line
`Exec=tetris -w 80`.

Not only is tetris the wrong binary, but it doesn't work anyway since
/usr/games/tetris doesn't have the -w option.

The solution is to use `Exec=vitetris -w 80`, which I have attempted to
create a patch for.

Many thanks,
Micah

Index: patches/patch-vitetris_desktop
===================================================================
RCS file: patches/patch-vitetris_desktop
diff -N patches/patch-vitetris_desktop
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-vitetris_desktop 25 July 2018 17:07:38 -0000
@@ -0,0 +1,14 @@
+$OpenBSD$
+
+Index: vitetris.desktop
+--- vitetris.desktop.orig
++++ vitetris.desktop
+@@ -3,7 +3,7 @@ Type=Application
+ Encoding=UTF-8
+ Name=vitetris
+ GenericName=Text-mode Tetris
+-Exec=tetris -w 80
++Exec=vitetris -w 80
+ Icon=vitetris
+ Categories=Game;BlocksGame;
+ Terminal=true

Reply | Threaded
Open this post in threaded view
|

Re: Fix for vitetris desktop file

Ryan Freeman
On Thu, Aug 02, 2018 at 02:53:17PM -0800, Micah Muer wrote:
> The desktop file that ships with vitetris
> (/usr/local/share/applications/vitetris.desktop) has the line
> `Exec=tetris -w 80`.
>
> Not only is tetris the wrong binary, but it doesn't work anyway since
> /usr/games/tetris doesn't have the -w option.
>
> The solution is to use `Exec=vitetris -w 80`, which I have attempted to
> create a patch for.

Nice catch!  I am unable to verify this at this time but the patch
reads okay to me, and okay from me if someone wants to confirm it
patches cleanly + can commit.

Alternatively we might want to just do an in-place 'sed -i' of that
line instead of introducing a patch to the port.

something like:
 @sed -i 's,Exec=tetris,Exec=vitetris,' $WRKSRC/vitetris.desktop

in a post-extract or so?

Thanks for finding this.
-Ryan

>
> Many thanks,
> Micah
>
> Index: patches/patch-vitetris_desktop
> ===================================================================
> RCS file: patches/patch-vitetris_desktop
> diff -N patches/patch-vitetris_desktop
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-vitetris_desktop 25 July 2018 17:07:38 -0000
> @@ -0,0 +1,14 @@
> +$OpenBSD$
> +
> +Index: vitetris.desktop
> +--- vitetris.desktop.orig
> ++++ vitetris.desktop
> +@@ -3,7 +3,7 @@ Type=Application
> + Encoding=UTF-8
> + Name=vitetris
> + GenericName=Text-mode Tetris
> +-Exec=tetris -w 80
> ++Exec=vitetris -w 80
> + Icon=vitetris
> + Categories=Game;BlocksGame;
> + Terminal=true
>