[FIX] editors/ghostwriter 1.5p2 spellchecking fix

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[FIX] editors/ghostwriter 1.5p2 spellchecking fix

Adam Wolk-2
Hi ports@,

On OpenBSD we expect hunspell using apps to look for dictionaries in
/usr/local/share/mozilla-dicts yet ghostwriter hardcodes a list of directories
to check that doesn't include the one above - resulting in a non functional
spellchecker on our platform.

I sent a trivial pull request upstream, that adds this folder:
  https://github.com/wereturtle/ghostwriter/pull/285

however, the current CONTRIBUTING policy upstream states:

> Pull requests are presently only accepted for translations into different
> languages. I will be closing all other pull requests.
source:
https://github.com/wereturtle/ghostwriter/blob/master/CONTRIBUTING.md#pull-requests

which means, that likely this change might not get accepted soon and could take
some time until a release gets cut with this.

Hence, I would like to add that patch to our ports tree to enable spellchecking
with the version we have.

Feedback? OK's?

Regards,
Adam

Index: Makefile
===================================================================
RCS file: /cvs/ports/editors/ghostwriter/Makefile,v
retrieving revision 1.5
diff -u -p -r1.5 Makefile
--- Makefile 30 Jul 2017 14:54:28 -0000 1.5
+++ Makefile 28 Jan 2018 15:27:18 -0000
@@ -8,7 +8,7 @@ COMMENT = distraction-free Markdown edit
 GH_ACCOUNT = wereturtle
 GH_PROJECT = ghostwriter
 GH_TAGNAME = v1.5.0
-REVISION = 1
+REVISION = 2
 
 CATEGORIES = editors
 
Index: patches/patch-src_spelling_dictionary_provider_hunspell_cpp
===================================================================
RCS file: patches/patch-src_spelling_dictionary_provider_hunspell_cpp
diff -N patches/patch-src_spelling_dictionary_provider_hunspell_cpp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_spelling_dictionary_provider_hunspell_cpp 28 Jan 2018 15:27:18 -0000
@@ -0,0 +1,14 @@
+$OpenBSD$
+
+Index: src/spelling/dictionary_provider_hunspell.cpp
+--- src/spelling/dictionary_provider_hunspell.cpp.orig
++++ src/spelling/dictionary_provider_hunspell.cpp
+@@ -301,7 +301,7 @@ DictionaryProviderHunspell::DictionaryProviderHunspell
+ xdg.append("/usr/local/share");
+ xdg.append("/usr/share");
+ }
+- QStringList subdirs = QStringList() << "/hunspell" << "/myspell/dicts" << "/myspell";
++ QStringList subdirs = QStringList() << "/hunspell" << "/myspell/dicts" << "/myspell" << "/mozilla-dicts";
+ foreach (const QString& subdir, subdirs) {
+ foreach (const QString& dir, xdg) {
+ QString path = dir + subdir;
Reply | Threaded
Open this post in threaded view
|

Re: [FIX] editors/ghostwriter 1.5p2 spellchecking fix

Landry Breuil-5
On Sun, Jan 28, 2018 at 04:48:13PM +0100, Adam Wolk wrote:

> Hi ports@,
>
> On OpenBSD we expect hunspell using apps to look for dictionaries in
> /usr/local/share/mozilla-dicts yet ghostwriter hardcodes a list of directories
> to check that doesn't include the one above - resulting in a non functional
> spellchecker on our platform.
>
> I sent a trivial pull request upstream, that adds this folder:
>   https://github.com/wereturtle/ghostwriter/pull/285
>
> however, the current CONTRIBUTING policy upstream states:
>
> > Pull requests are presently only accepted for translations into different
> > languages. I will be closing all other pull requests.
> source:
> https://github.com/wereturtle/ghostwriter/blob/master/CONTRIBUTING.md#pull-requests
>
> which means, that likely this change might not get accepted soon and could take
> some time until a release gets cut with this.
>
> Hence, I would like to add that patch to our ports tree to enable spellchecking
> with the version we have.
>
> Feedback? OK's?

Sure, okay. It's fun that it's now advertised as a markdown editor, it
wasnt the case at all when i imported it :)

Reply | Threaded
Open this post in threaded view
|

Re: [FIX] editors/ghostwriter 1.5p2 spellchecking fix

Landry Breuil-5
On Sun, Jan 28, 2018 at 05:20:38PM +0100, Landry Breuil wrote:

> On Sun, Jan 28, 2018 at 04:48:13PM +0100, Adam Wolk wrote:
> > Hi ports@,
> >
> > On OpenBSD we expect hunspell using apps to look for dictionaries in
> > /usr/local/share/mozilla-dicts yet ghostwriter hardcodes a list of directories
> > to check that doesn't include the one above - resulting in a non functional
> > spellchecker on our platform.
> >
> > I sent a trivial pull request upstream, that adds this folder:
> >   https://github.com/wereturtle/ghostwriter/pull/285
> >
> > however, the current CONTRIBUTING policy upstream states:
> >
> > > Pull requests are presently only accepted for translations into different
> > > languages. I will be closing all other pull requests.
> > source:
> > https://github.com/wereturtle/ghostwriter/blob/master/CONTRIBUTING.md#pull-requests
> >
> > which means, that likely this change might not get accepted soon and could take
> > some time until a release gets cut with this.
> >
> > Hence, I would like to add that patch to our ports tree to enable spellchecking
> > with the version we have.
> >
> > Feedback? OK's?
>
> Sure, okay. It's fun that it's now advertised as a markdown editor, it
> wasnt the case at all when i imported it :)

Dammit i'm mixing things with *focus*writer, disregard this comment :)

Reply | Threaded
Open this post in threaded view
|

Re: [FIX] editors/ghostwriter 1.5p2 spellchecking fix

Adam Wolk-2
On Sun, Jan 28, 2018 at 05:33:26PM +0100, Landry Breuil wrote:

> On Sun, Jan 28, 2018 at 05:20:38PM +0100, Landry Breuil wrote:
> > On Sun, Jan 28, 2018 at 04:48:13PM +0100, Adam Wolk wrote:
> > > Hi ports@,
> > >
> > > On OpenBSD we expect hunspell using apps to look for dictionaries in
> > > /usr/local/share/mozilla-dicts yet ghostwriter hardcodes a list of directories
> > > to check that doesn't include the one above - resulting in a non functional
> > > spellchecker on our platform.
> > >
> > > I sent a trivial pull request upstream, that adds this folder:
> > >   https://github.com/wereturtle/ghostwriter/pull/285
> > >
> > > however, the current CONTRIBUTING policy upstream states:
> > >
> > > > Pull requests are presently only accepted for translations into different
> > > > languages. I will be closing all other pull requests.
> > > source:
> > > https://github.com/wereturtle/ghostwriter/blob/master/CONTRIBUTING.md#pull-requests
> > >
> > > which means, that likely this change might not get accepted soon and could take
> > > some time until a release gets cut with this.
> > >
> > > Hence, I would like to add that patch to our ports tree to enable spellchecking
> > > with the version we have.
> > >
> > > Feedback? OK's?
> >
> > Sure, okay. It's fun that it's now advertised as a markdown editor, it
> > wasnt the case at all when i imported it :)
>
> Dammit i'm mixing things with *focus*writer, disregard this comment :)
>

but still OK landry@ to commit the patch? ;)

Reply | Threaded
Open this post in threaded view
|

Re: [FIX] editors/ghostwriter 1.5p2 spellchecking fix

Landry Breuil-5
On Sun, Jan 28, 2018 at 05:47:21PM +0100, Adam Wolk wrote:

> On Sun, Jan 28, 2018 at 05:33:26PM +0100, Landry Breuil wrote:
> > On Sun, Jan 28, 2018 at 05:20:38PM +0100, Landry Breuil wrote:
> > > On Sun, Jan 28, 2018 at 04:48:13PM +0100, Adam Wolk wrote:
> > > > Hi ports@,
> > > >
> > > > On OpenBSD we expect hunspell using apps to look for dictionaries in
> > > > /usr/local/share/mozilla-dicts yet ghostwriter hardcodes a list of directories
> > > > to check that doesn't include the one above - resulting in a non functional
> > > > spellchecker on our platform.
> > > >
> > > > I sent a trivial pull request upstream, that adds this folder:
> > > >   https://github.com/wereturtle/ghostwriter/pull/285
> > > >
> > > > however, the current CONTRIBUTING policy upstream states:
> > > >
> > > > > Pull requests are presently only accepted for translations into different
> > > > > languages. I will be closing all other pull requests.
> > > > source:
> > > > https://github.com/wereturtle/ghostwriter/blob/master/CONTRIBUTING.md#pull-requests
> > > >
> > > > which means, that likely this change might not get accepted soon and could take
> > > > some time until a release gets cut with this.
> > > >
> > > > Hence, I would like to add that patch to our ports tree to enable spellchecking
> > > > with the version we have.
> > > >
> > > > Feedback? OK's?
> > >
> > > Sure, okay. It's fun that it's now advertised as a markdown editor, it
> > > wasnt the case at all when i imported it :)
> >
> > Dammit i'm mixing things with *focus*writer, disregard this comment :)
> >
>
> but still OK landry@ to commit the patch? ;)

sure, always makes sense to fix bugs..

Reply | Threaded
Open this post in threaded view
|

Re: [FIX] editors/ghostwriter 1.5p2 spellchecking fix

Adam Wolk-2
On Sun, Jan 28, 2018 at 05:50:15PM +0100, Landry Breuil wrote:

> On Sun, Jan 28, 2018 at 05:47:21PM +0100, Adam Wolk wrote:
> > On Sun, Jan 28, 2018 at 05:33:26PM +0100, Landry Breuil wrote:
> > > On Sun, Jan 28, 2018 at 05:20:38PM +0100, Landry Breuil wrote:
> > > > On Sun, Jan 28, 2018 at 04:48:13PM +0100, Adam Wolk wrote:
> > > > > Hi ports@,
> > > > >
> > > > > On OpenBSD we expect hunspell using apps to look for dictionaries in
> > > > > /usr/local/share/mozilla-dicts yet ghostwriter hardcodes a list of directories
> > > > > to check that doesn't include the one above - resulting in a non functional
> > > > > spellchecker on our platform.
> > > > >
> > > > > I sent a trivial pull request upstream, that adds this folder:
> > > > >   https://github.com/wereturtle/ghostwriter/pull/285
> > > > >
> > > > > however, the current CONTRIBUTING policy upstream states:
> > > > >
> > > > > > Pull requests are presently only accepted for translations into different
> > > > > > languages. I will be closing all other pull requests.
> > > > > source:
> > > > > https://github.com/wereturtle/ghostwriter/blob/master/CONTRIBUTING.md#pull-requests
> > > > >
> > > > > which means, that likely this change might not get accepted soon and could take
> > > > > some time until a release gets cut with this.
> > > > >
> > > > > Hence, I would like to add that patch to our ports tree to enable spellchecking
> > > > > with the version we have.
> > > > >
> > > > > Feedback? OK's?
> > > >
> > > > Sure, okay. It's fun that it's now advertised as a markdown editor, it
> > > > wasnt the case at all when i imported it :)
> > >
> > > Dammit i'm mixing things with *focus*writer, disregard this comment :)
> > >
> >
> > but still OK landry@ to commit the patch? ;)
>
> sure, always makes sense to fix bugs..
>

committed, thanks!

Regards,
Adam