Enable system cairo for mozilla-firefox and mozilla-thunderbird

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Enable system cairo for mozilla-firefox and mozilla-thunderbird

David Coppa
I'm resending this one after the unlock.

The attached patch (re-)enable system cairo support for
mozilla-firefox and mozilla-thunderbird (the only ports in our tree
that are based on mozilla 1.9.2 branch).

cairo-1.10.2 has solved most of the problems that forced us to switch
to internal cairo. The only remaining one is with animated gifs, which
is solved by this patch cherrypicked from gentoo.

I'm using this since a lot of time and it seems stable to me. I've
also tested it with firefox 3.6.15 since this morning...

Ciao,
David

mozilla_anim_gif.patch (20K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Enable system cairo for mozilla-firefox and mozilla-thunderbird

Landry Breuil-5
On Tue, Mar 08, 2011 at 03:09:26PM +0100, David Coppa wrote:
> I'm resending this one after the unlock.
>
> The attached patch (re-)enable system cairo support for
> mozilla-firefox and mozilla-thunderbird (the only ports in our tree
> that are based on mozilla 1.9.2 branch).
>
> cairo-1.10.2 has solved most of the problems that forced us to switch
> to internal cairo. The only remaining one is with animated gifs, which
> is solved by this patch cherrypicked from gentoo.

I'll look at that soonish.. can you add links to gentoo bug report/patch
source/mozilla bug report in the patches ?

Landry

Reply | Threaded
Open this post in threaded view
|

Re: Enable system cairo for mozilla-firefox and mozilla-thunderbird

David Coppa
On Tue, Mar 8, 2011 at 4:28 PM, Landry Breuil <[hidden email]> wrote:

> On Tue, Mar 08, 2011 at 03:09:26PM +0100, David Coppa wrote:
>> I'm resending this one after the unlock.
>>
>> The attached patch (re-)enable system cairo support for
>> mozilla-firefox and mozilla-thunderbird (the only ports in our tree
>> that are based on mozilla 1.9.2 branch).
>>
>> cairo-1.10.2 has solved most of the problems that forced us to switch
>> to internal cairo. The only remaining one is with animated gifs, which
>> is solved by this patch cherrypicked from gentoo.
>
> I'll look at that soonish.. can you add links to gentoo bug report/patch
> source/mozilla bug report in the patches ?

Ok, I will.

This is the url: http://bugs.gentoo.org/show_bug.cgi?id=337813

Basically, it's a backport from ffox4 code (the patch has been done by
Rafal Muzylo)

ciao
david

Reply | Threaded
Open this post in threaded view
|

Re: Enable system cairo for mozilla-firefox and mozilla-thunderbird

Landry Breuil-5
On Tue, Mar 08, 2011 at 04:40:20PM +0100, David Coppa wrote:

> On Tue, Mar 8, 2011 at 4:28 PM, Landry Breuil <[hidden email]> wrote:
> > On Tue, Mar 08, 2011 at 03:09:26PM +0100, David Coppa wrote:
> >> I'm resending this one after the unlock.
> >>
> >> The attached patch (re-)enable system cairo support for
> >> mozilla-firefox and mozilla-thunderbird (the only ports in our tree
> >> that are based on mozilla 1.9.2 branch).
> >>
> >> cairo-1.10.2 has solved most of the problems that forced us to switch
> >> to internal cairo. The only remaining one is with animated gifs, which
> >> is solved by this patch cherrypicked from gentoo.
> >
> > I'll look at that soonish.. can you add links to gentoo bug report/patch
> > source/mozilla bug report in the patches ?
>
> Ok, I will.
>
> This is the url: http://bugs.gentoo.org/show_bug.cgi?id=337813
>
> Basically, it's a backport from ffox4 code (the patch has been done by
> Rafal Muzylo)

I did some digging.. it looks like the whole patch is
http://hg.mozilla.org/releases/mozilla-2.0/rev/7c7debeec5a2 and
http://hg.mozilla.org/releases/mozilla-2.0/rev/f70db887a173 , right ?

I can't find the patch in gentoo cvs,
Is http://bugs.gentoo.org/attachment.cgi?id=256003&action=diff the only
source ?

Landry

Reply | Threaded
Open this post in threaded view
|

Re: Enable system cairo for mozilla-firefox and mozilla-thunderbird

Landry Breuil-5
On Tue, Mar 08, 2011 at 09:54:08PM +0100, Landry Breuil wrote:

> On Tue, Mar 08, 2011 at 04:40:20PM +0100, David Coppa wrote:
> > On Tue, Mar 8, 2011 at 4:28 PM, Landry Breuil <[hidden email]> wrote:
> > > On Tue, Mar 08, 2011 at 03:09:26PM +0100, David Coppa wrote:
> > >> I'm resending this one after the unlock.
> > >>
> > >> The attached patch (re-)enable system cairo support for
> > >> mozilla-firefox and mozilla-thunderbird (the only ports in our tree
> > >> that are based on mozilla 1.9.2 branch).
> > >>
> > >> cairo-1.10.2 has solved most of the problems that forced us to switch
> > >> to internal cairo. The only remaining one is with animated gifs, which
> > >> is solved by this patch cherrypicked from gentoo.
> > >
> > > I'll look at that soonish.. can you add links to gentoo bug report/patch
> > > source/mozilla bug report in the patches ?
> >
> > Ok, I will.
> >
> > This is the url: http://bugs.gentoo.org/show_bug.cgi?id=337813
> >
> > Basically, it's a backport from ffox4 code (the patch has been done by
> > Rafal Muzylo)
>
> I did some digging.. it looks like the whole patch is
> http://hg.mozilla.org/releases/mozilla-2.0/rev/7c7debeec5a2 and
> http://hg.mozilla.org/releases/mozilla-2.0/rev/f70db887a173 , right ?
>
> I can't find the patch in gentoo cvs,
> Is http://bugs.gentoo.org/attachment.cgi?id=256003&action=diff the only
> source ?

Ok, found more sources/references, the main bug report being :
https://bugzilla.mozilla.org/show_bug.cgi?id=597174
last comment points to three other bug reports, which states the
corresponding patches are pending approval for 1.9.2.x branch (which
 would be next ffx 3.6)
If those patches are the same than gentoo's patches and you put the
relevant bz/commit links in the patches, then it's ok for me.

Oh, and check WANTLIB of course..

Landry