Quantcast

Enable getaddrinfo() in libxcb

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Enable getaddrinfo() in libxcb

Christian Weisgerber
Enable the use of getaddrinfo() in libxcb.  This allows X11 clients
to talk to a remote server over IPv6.

This is not a new feature, but somehow we lost it along the way and
nobody noticed.

Tested on alpha, amd64, sparc64.

Index: lib/libxcb/src/config.h
===================================================================
RCS file: /cvs/xenocara/lib/libxcb/src/config.h,v
retrieving revision 1.2
diff -u -p -r1.2 config.h
--- lib/libxcb/src/config.h 5 Oct 2011 18:05:48 -0000 1.2
+++ lib/libxcb/src/config.h 30 Mar 2013 22:38:59 -0000
@@ -13,6 +13,9 @@
 /* Define to 1 if you have the <dlfcn.h> header file. */
 #define HAVE_DLFCN_H 1
 
+/* getaddrinfo() function is available */
+#define HAVE_GETADDRINFO 1
+
 /* Define to 1 if you have the <inttypes.h> header file. */
 #define HAVE_INTTYPES_H 1
 
--
Christian "naddy" Weisgerber                          [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Enable getaddrinfo() in libxcb

Matthieu Herrb
On Sun, Mar 31, 2013 at 12:19:38AM +0100, Christian Weisgerber wrote:

> Enable the use of getaddrinfo() in libxcb.  This allows X11 clients
> to talk to a remote server over IPv6.
>
> This is not a new feature, but somehow we lost it along the way and
> nobody noticed.
>
> Tested on alpha, amd64, sparc64.
>
> Index: lib/libxcb/src/config.h
> ===================================================================
> RCS file: /cvs/xenocara/lib/libxcb/src/config.h,v
> retrieving revision 1.2
> diff -u -p -r1.2 config.h
> --- lib/libxcb/src/config.h 5 Oct 2011 18:05:48 -0000 1.2
> +++ lib/libxcb/src/config.h 30 Mar 2013 22:38:59 -0000
> @@ -13,6 +13,9 @@
>  /* Define to 1 if you have the <dlfcn.h> header file. */
>  #define HAVE_DLFCN_H 1
>  
> +/* getaddrinfo() function is available */
> +#define HAVE_GETADDRINFO 1
> +
>  /* Define to 1 if you have the <inttypes.h> header file. */
>  #define HAVE_INTTYPES_H 1
>  
> --
> Christian "naddy" Weisgerber                          [hidden email]
>

Ok matthieu@.

It also fixes the other weird behaviour I had seen and never
bothered to figure out what was happening.

I'd just use the same comment as the one that would have been
generated by autoheader from the configure.ac script if we'd
regenerated config.h:

+/* Define to 1 if getaddrinfo() function is available */

--
Matthieu Herrb

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Enable getaddrinfo() in libxcb

Christian Weisgerber
Matthieu Herrb:

> > +/* getaddrinfo() function is available */
> > +#define HAVE_GETADDRINFO 1
> > +
>
> I'd just use the same comment as the one that would have been
> generated by autoheader from the configure.ac script if we'd
> regenerated config.h:

I did!

> +/* Define to 1 if getaddrinfo() function is available */

AC_DEFINE() copies the comment verbatim and does not prepend any
text.

--
Christian "naddy" Weisgerber                          [hidden email]

Loading...