DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3
Hi ports --

In my careful review for devel/openmp, I stumbled upon two different
ports of the same software, Lua BitOp, which can be found in both
devel/lua-bitop and devel/luabitop. They are of the same version, and
their distinfos perfectly match.

devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is not used
by anything (at least, as far as `make search key=lua-bitop` suggests).
devel/luabitop also appears to be the more comprehensive port.

OK to remove devel/lua-bitop?

~Brian

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Edd Barrett-3
Hi,

On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is not used by
> anything (at least, as far as `make search key=lua-bitop` suggests).
> devel/luabitop also appears to be the more comprehensive port.
>
> OK to remove devel/lua-bitop?

Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
becuase it wasn't prefixed 'lua-'. Somehow I then managed to depend on
the existing luabitop.

I've checked using sqlports that there are no other dependents, so your
plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
anyone else chimes in.

Thanks

--
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Kirill Bychkov
On Sun, November 12, 2017 20:12, Edd Barrett wrote:

> Hi,
>
> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is not used by
>> anything (at least, as far as `make search key=lua-bitop` suggests).
>> devel/luabitop also appears to be the more comprehensive port.
>>
>> OK to remove devel/lua-bitop?
>
> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
> becuase it wasn't prefixed 'lua-'. Somehow I then managed to depend on
> the existing luabitop.
>
> I've checked using sqlports that there are no other dependents, so your
> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
> anyone else chimes in.
>
> Thanks
>
Hi!
lua- prefix is a standard. IMHO you should remove luabitop and add lua-bitop
as a dependency to neovim.
Just my 2 cents.

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3

On 11/12/17 14:08, Kirill Bychkov wrote:

> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>> Hi,
>>
>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is not used by
>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>> devel/luabitop also appears to be the more comprehensive port.
>>>
>>> OK to remove devel/lua-bitop?
>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to depend on
>> the existing luabitop.
>>
>> I've checked using sqlports that there are no other dependents, so your
>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>> anyone else chimes in.
>>
>> Thanks
>>
> Hi!
> lua- prefix is a standard. IMHO you should remove luabitop and add lua-bitop
> as a dependency to neovim.
> Just my 2 cents.
>

Or should luabitop be moved to lua-bitop?

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Kirill Bychkov
On Sun, November 12, 2017 22:27, Brian Callahan wrote:

>
> On 11/12/17 14:08, Kirill Bychkov wrote:
>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>> Hi,
>>>
>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is not used by
>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>
>>>> OK to remove devel/lua-bitop?
>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to depend on
>>> the existing luabitop.
>>>
>>> I've checked using sqlports that there are no other dependents, so your
>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>> anyone else chimes in.
>>>
>>> Thanks
>>>
>> Hi!
>> lua- prefix is a standard. IMHO you should remove luabitop and add lua-bitop
>> as a dependency to neovim.
>> Just my 2 cents.
>>
>
> Or should luabitop be moved to lua-bitop?
>
I think you need to merge all the tweaks from both ports in lua-bitop and
remove luabitop directory with all quirks and @pkgpath dance.

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3

On 11/13/17 10:36, Kirill Bychkov wrote:

> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>> Hi,
>>>>
>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is not used by
>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>
>>>>> OK to remove devel/lua-bitop?
>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to depend on
>>>> the existing luabitop.
>>>>
>>>> I've checked using sqlports that there are no other dependents, so your
>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>> anyone else chimes in.
>>>>
>>>> Thanks
>>>>
>>> Hi!
>>> lua- prefix is a standard. IMHO you should remove luabitop and add lua-bitop
>>> as a dependency to neovim.
>>> Just my 2 cents.
>>>
>> Or should luabitop be moved to lua-bitop?
>>
> I think you need to merge all the tweaks from both ports in lua-bitop and
> remove luabitop directory with all quirks and @pkgpath dance.
>

Right. That's what I was thinking.

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3
Now looking for oks.

On 11/13/17 11:05, Brian Callahan wrote:

>
> On 11/13/17 10:36, Kirill Bychkov wrote:
>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>> Hi,
>>>>>
>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>> not used by
>>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>
>>>>>> OK to remove devel/lua-bitop?
>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>> depend on
>>>>> the existing luabitop.
>>>>>
>>>>> I've checked using sqlports that there are no other dependents, so
>>>>> your
>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>>> anyone else chimes in.
>>>>>
>>>>> Thanks
>>>>>
>>>> Hi!
>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>> lua-bitop
>>>> as a dependency to neovim.
>>>> Just my 2 cents.
>>>>
>>> Or should luabitop be moved to lua-bitop?
>>>
>> I think you need to merge all the tweaks from both ports in lua-bitop
>> and
>> remove luabitop directory with all quirks and @pkgpath dance.
>>
>
> Right. That's what I was thinking.
>
Merging diff attached. Missing from this diff is the bump and depends
switch in editors/neovim, but that comes after.

~Brian


new-lua-bitop.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3
Now with a REVISION bump in devel/lua-bitop

On 11/13/17 11:49, Brian Callahan wrote:

> Now looking for oks.
>
> On 11/13/17 11:05, Brian Callahan wrote:
>>
>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>> not used by
>>>>>>> anything (at least, as far as `make search key=lua-bitop`
>>>>>>> suggests).
>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>
>>>>>>> OK to remove devel/lua-bitop?
>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing
>>>>>> luabitop
>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>> depend on
>>>>>> the existing luabitop.
>>>>>>
>>>>>> I've checked using sqlports that there are no other dependents,
>>>>>> so your
>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and
>>>>>> see if
>>>>>> anyone else chimes in.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>> Hi!
>>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>>> lua-bitop
>>>>> as a dependency to neovim.
>>>>> Just my 2 cents.
>>>>>
>>>> Or should luabitop be moved to lua-bitop?
>>>>
>>> I think you need to merge all the tweaks from both ports in
>>> lua-bitop and
>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>
>>
>> Right. That's what I was thinking.
>>
>
> Merging diff attached. Missing from this diff is the bump and depends
> switch in editors/neovim, but that comes after.
>
> ~Brian
>


new-lua-bitop.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Kirill Bychkov
In reply to this post by Brian Callahan-3
On Mon, November 13, 2017 19:49, Brian Callahan wrote:

> Now looking for oks.
>
> On 11/13/17 11:05, Brian Callahan wrote:
>>
>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>> not used by
>>>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>
>>>>>>> OK to remove devel/lua-bitop?
>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>> depend on
>>>>>> the existing luabitop.
>>>>>>
>>>>>> I've checked using sqlports that there are no other dependents, so
>>>>>> your
>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>>>> anyone else chimes in.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>> Hi!
>>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>>> lua-bitop
>>>>> as a dependency to neovim.
>>>>> Just my 2 cents.
>>>>>
>>>> Or should luabitop be moved to lua-bitop?
>>>>
>>> I think you need to merge all the tweaks from both ports in lua-bitop
>>> and
>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>
>>
>> Right. That's what I was thinking.
>>
>
> Merging diff attached. Missing from this diff is the bump and depends
> switch in editors/neovim, but that comes after.
>
> ~Brian
>
>
Some comments:
 - you're missing REVISION bump after changing PLIST and COMMENT
 - you need @conflict marker for luabitop because you're shipping docs now
 - and you can switch to https while here.

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3

On 11/13/2017 12:26 PM, Kirill Bychkov wrote:

> On Mon, November 13, 2017 19:49, Brian Callahan wrote:
>> Now looking for oks.
>>
>> On 11/13/17 11:05, Brian Callahan wrote:
>>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>>> not used by
>>>>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>>
>>>>>>>> OK to remove devel/lua-bitop?
>>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>>> depend on
>>>>>>> the existing luabitop.
>>>>>>>
>>>>>>> I've checked using sqlports that there are no other dependents, so
>>>>>>> your
>>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>>>>> anyone else chimes in.
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>> Hi!
>>>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>>>> lua-bitop
>>>>>> as a dependency to neovim.
>>>>>> Just my 2 cents.
>>>>>>
>>>>> Or should luabitop be moved to lua-bitop?
>>>>>
>>>> I think you need to merge all the tweaks from both ports in lua-bitop
>>>> and
>>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>>
>>> Right. That's what I was thinking.
>>>
>> Merging diff attached. Missing from this diff is the bump and depends
>> switch in editors/neovim, but that comes after.
>>
>> ~Brian
>>
>>
> Some comments:
>   - you're missing REVISION bump after changing PLIST and COMMENT

Yup, I sent a new diff with the bump.

>   - you need @conflict marker for luabitop because you're shipping docs now

I'm going to remove luabitop before changing lua-bitop.

>   - and you can switch to https while here.
>

Sure.

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Kirill Bychkov
On Mon, November 13, 2017 20:28, Brian Callahan wrote:

>
> On 11/13/2017 12:26 PM, Kirill Bychkov wrote:
>> On Mon, November 13, 2017 19:49, Brian Callahan wrote:
>>> Now looking for oks.
>>>
>>> On 11/13/17 11:05, Brian Callahan wrote:
>>>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>>>> not used by
>>>>>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>>>
>>>>>>>>> OK to remove devel/lua-bitop?
>>>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>>>> depend on
>>>>>>>> the existing luabitop.
>>>>>>>>
>>>>>>>> I've checked using sqlports that there are no other dependents, so
>>>>>>>> your
>>>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>>>>>> anyone else chimes in.
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>> Hi!
>>>>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>>>>> lua-bitop
>>>>>>> as a dependency to neovim.
>>>>>>> Just my 2 cents.
>>>>>>>
>>>>>> Or should luabitop be moved to lua-bitop?
>>>>>>
>>>>> I think you need to merge all the tweaks from both ports in lua-bitop
>>>>> and
>>>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>>>
>>>> Right. That's what I was thinking.
>>>>
>>> Merging diff attached. Missing from this diff is the bump and depends
>>> switch in editors/neovim, but that comes after.
>>>
>>> ~Brian
>>>
>>>
>> Some comments:
>>   - you're missing REVISION bump after changing PLIST and COMMENT
>
> Yup, I sent a new diff with the bump.
>
>>   - you need @conflict marker for luabitop because you're shipping docs now
>
> I'm going to remove luabitop before changing lua-bitop.

It doesn't matter for already installed packages.

>
>>   - and you can switch to https while here.
>>
>
> Sure.
>


Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3


On 11/13/2017 12:30 PM, Kirill Bychkov wrote:

> On Mon, November 13, 2017 20:28, Brian Callahan wrote:
>> On 11/13/2017 12:26 PM, Kirill Bychkov wrote:
>>> On Mon, November 13, 2017 19:49, Brian Callahan wrote:
>>>> Now looking for oks.
>>>>
>>>> On 11/13/17 11:05, Brian Callahan wrote:
>>>>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>>>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>>>>> not used by
>>>>>>>>>> anything (at least, as far as `make search key=lua-bitop` suggests).
>>>>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>>>>
>>>>>>>>>> OK to remove devel/lua-bitop?
>>>>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing luabitop
>>>>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>>>>> depend on
>>>>>>>>> the existing luabitop.
>>>>>>>>>
>>>>>>>>> I've checked using sqlports that there are no other dependents, so
>>>>>>>>> your
>>>>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit and see if
>>>>>>>>> anyone else chimes in.
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>> Hi!
>>>>>>>> lua- prefix is a standard. IMHO you should remove luabitop and add
>>>>>>>> lua-bitop
>>>>>>>> as a dependency to neovim.
>>>>>>>> Just my 2 cents.
>>>>>>>>
>>>>>>> Or should luabitop be moved to lua-bitop?
>>>>>>>
>>>>>> I think you need to merge all the tweaks from both ports in lua-bitop
>>>>>> and
>>>>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>>>>
>>>>> Right. That's what I was thinking.
>>>>>
>>>> Merging diff attached. Missing from this diff is the bump and depends
>>>> switch in editors/neovim, but that comes after.
>>>>
>>>> ~Brian
>>>>
>>>>
>>> Some comments:
>>>    - you're missing REVISION bump after changing PLIST and COMMENT
>> Yup, I sent a new diff with the bump.
>>
>>>    - you need @conflict marker for luabitop because you're shipping docs now
>> I'm going to remove luabitop before changing lua-bitop.
> It doesn't matter for already installed packages.

Nevermind, I misread what you said. Yes, it needs a @conflict marker.

>>>    - and you can switch to https while here.
>>>
>> Sure.
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Brian Callahan-3

On 11/13/17 13:16, Brian Callahan wrote:

>
>
> On 11/13/2017 12:30 PM, Kirill Bychkov wrote:
>> On Mon, November 13, 2017 20:28, Brian Callahan wrote:
>>> On 11/13/2017 12:26 PM, Kirill Bychkov wrote:
>>>> On Mon, November 13, 2017 19:49, Brian Callahan wrote:
>>>>> Now looking for oks.
>>>>>
>>>>> On 11/13/17 11:05, Brian Callahan wrote:
>>>>>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>>>>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>>>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>>>>>> Hi,
>>>>>>>>>>
>>>>>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>>>>>> not used by
>>>>>>>>>>> anything (at least, as far as `make search key=lua-bitop`
>>>>>>>>>>> suggests).
>>>>>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>>>>>
>>>>>>>>>>> OK to remove devel/lua-bitop?
>>>>>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing
>>>>>>>>>> luabitop
>>>>>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>>>>>> depend on
>>>>>>>>>> the existing luabitop.
>>>>>>>>>>
>>>>>>>>>> I've checked using sqlports that there are no other
>>>>>>>>>> dependents, so
>>>>>>>>>> your
>>>>>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit
>>>>>>>>>> and see if
>>>>>>>>>> anyone else chimes in.
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>>
>>>>>>>>> Hi!
>>>>>>>>> lua- prefix is a standard. IMHO you should remove luabitop and
>>>>>>>>> add
>>>>>>>>> lua-bitop
>>>>>>>>> as a dependency to neovim.
>>>>>>>>> Just my 2 cents.
>>>>>>>>>
>>>>>>>> Or should luabitop be moved to lua-bitop?
>>>>>>>>
>>>>>>> I think you need to merge all the tweaks from both ports in
>>>>>>> lua-bitop
>>>>>>> and
>>>>>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>>>>>
>>>>>> Right. That's what I was thinking.
>>>>>>
>>>>> Merging diff attached. Missing from this diff is the bump and depends
>>>>> switch in editors/neovim, but that comes after.
>>>>>
>>>>> ~Brian
>>>>>
>>>>>
>>>> Some comments:
>>>>    - you're missing REVISION bump after changing PLIST and COMMENT
>>> Yup, I sent a new diff with the bump.
>>>
>>>>    - you need @conflict marker for luabitop because you're shipping
>>>> docs now
>>> I'm going to remove luabitop before changing lua-bitop.
>> It doesn't matter for already installed packages.
>
> Nevermind, I misread what you said. Yes, it needs a @conflict marker.
>
>>>>    - and you can switch to https while here.
>>>>
>>> Sure.
>>>
>>
>
Updated diff just for lua-bitop.
Tell me if this makes sense to you as a plan of action:
1. update lua-bitop
2. switch neovim to lua-bitop
3. unlink & remove luabitop
4. register luabitop removal with quirks

~Brian


lua-bitop.diff (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: DUPLICATE PORTS: devel/lua-bitop && devel/luabitop

Kirill Bychkov
On Tue, November 14, 2017 04:59, Brian Callahan wrote:

>
> On 11/13/17 13:16, Brian Callahan wrote:
>>
>>
>> On 11/13/2017 12:30 PM, Kirill Bychkov wrote:
>>> On Mon, November 13, 2017 20:28, Brian Callahan wrote:
>>>> On 11/13/2017 12:26 PM, Kirill Bychkov wrote:
>>>>> On Mon, November 13, 2017 19:49, Brian Callahan wrote:
>>>>>> Now looking for oks.
>>>>>>
>>>>>> On 11/13/17 11:05, Brian Callahan wrote:
>>>>>>> On 11/13/17 10:36, Kirill Bychkov wrote:
>>>>>>>> On Sun, November 12, 2017 22:27, Brian Callahan wrote:
>>>>>>>>> On 11/12/17 14:08, Kirill Bychkov wrote:
>>>>>>>>>> On Sun, November 12, 2017 20:12, Edd Barrett wrote:
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> On Sun, Nov 12, 2017 at 11:49:20AM -0500, Brian Callahan wrote:
>>>>>>>>>>>> devel/luabitop is a BDEP of editors/neovim. devel/lua-bitop is
>>>>>>>>>>>> not used by
>>>>>>>>>>>> anything (at least, as far as `make search key=lua-bitop`
>>>>>>>>>>>> suggests).
>>>>>>>>>>>> devel/luabitop also appears to be the more comprehensive port.
>>>>>>>>>>>>
>>>>>>>>>>>> OK to remove devel/lua-bitop?
>>>>>>>>>>> Ugh. IIRC, I imported lua-bitop for neovim, probably missing
>>>>>>>>>>> luabitop
>>>>>>>>>>> becuase it wasn't prefixed 'lua-'. Somehow I then managed to
>>>>>>>>>>> depend on
>>>>>>>>>>> the existing luabitop.
>>>>>>>>>>>
>>>>>>>>>>> I've checked using sqlports that there are no other
>>>>>>>>>>> dependents, so
>>>>>>>>>>> your
>>>>>>>>>>> plan seems sensible to me. OK edd@, but perhaps wait a bit
>>>>>>>>>>> and see if
>>>>>>>>>>> anyone else chimes in.
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>>
>>>>>>>>>> Hi!
>>>>>>>>>> lua- prefix is a standard. IMHO you should remove luabitop and
>>>>>>>>>> add
>>>>>>>>>> lua-bitop
>>>>>>>>>> as a dependency to neovim.
>>>>>>>>>> Just my 2 cents.
>>>>>>>>>>
>>>>>>>>> Or should luabitop be moved to lua-bitop?
>>>>>>>>>
>>>>>>>> I think you need to merge all the tweaks from both ports in
>>>>>>>> lua-bitop
>>>>>>>> and
>>>>>>>> remove luabitop directory with all quirks and @pkgpath dance.
>>>>>>>>
>>>>>>> Right. That's what I was thinking.
>>>>>>>
>>>>>> Merging diff attached. Missing from this diff is the bump and depends
>>>>>> switch in editors/neovim, but that comes after.
>>>>>>
>>>>>> ~Brian
>>>>>>
>>>>>>
>>>>> Some comments:
>>>>>    - you're missing REVISION bump after changing PLIST and COMMENT
>>>> Yup, I sent a new diff with the bump.
>>>>
>>>>>    - you need @conflict marker for luabitop because you're shipping
>>>>> docs now
>>>> I'm going to remove luabitop before changing lua-bitop.
>>> It doesn't matter for already installed packages.
>>
>> Nevermind, I misread what you said. Yes, it needs a @conflict marker.
>>
>>>>>    - and you can switch to https while here.
>>>>>
>>>> Sure.
>>>>
>>>
>>
>
> Updated diff just for lua-bitop.
> Tell me if this makes sense to you as a plan of action:
> 1. update lua-bitop
> 2. switch neovim to lua-bitop
> 3. unlink & remove luabitop
> 4. register luabitop removal with quirks
>
> ~Brian
>
>
OK for the whole plan.