Comment fix: No mcontext

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Comment fix: No mcontext

Benjamin Baier
Hi,

there is no mcontext, and since V1.2 of process_machdep.c struct reg
and struct trapframe don't have to be closely synced.
process_machdep.c no longer memcpy's one to the other.

Greetings Ben

Thu Jul 11 23:45:14 CEST 2019
/home/cvsgit/hellfish/src/sys/arch/amd64/include
Index: reg.h
===================================================================
RCS file: /cvs/src/sys/arch/amd64/include/reg.h,v
retrieving revision 1.6
diff -u -p -r1.6 reg.h
--- reg.h 23 Mar 2011 16:54:34 -0000 1.6
+++ reg.h 11 Jul 2019 21:45:11 -0000
@@ -75,8 +75,6 @@
 
 /*
  * Registers accessible to ptrace(2) syscall for debugger use.
- * Same as mcontext.__gregs and struct trapframe, they must
- * remain synced (XXX should use common structure).
  */
 struct reg {
  int64_t r_rdi;

Reply | Threaded
Open this post in threaded view
|

Re: Comment fix: No mcontext

Philip Guenther-2
On Thu, Jul 11, 2019 at 10:12 PM Benjamin Baier <[hidden email]>
wrote:

> there is no mcontext, and since V1.2 of process_machdep.c struct reg
> and struct trapframe don't have to be closely synced.
> process_machdep.c no longer memcpy's one to the other.
>

Yep.  Committed.  Thanks!


Philip Guenther