[BE_ARCHS] don't build emulators/nono

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[BE_ARCHS] don't build emulators/nono

Charlene Wendling
Hi,

> http://build-failures.rhaalovely.net/powerpc/2020-07-15/emulators/nono.log
> http://build-failures.rhaalovely.net/mips64/2020-07-11/emulators/nono.log
(it fails on sparc64 because ports-gcc is not used)

$WRKSRC/vm/bitmap.h includes $WRKSRC/lib/device.h, where HLB and HLW
are only defined on little endian archs. $WRKSRC/vm/bitmap.cpp
expect them and has no fallback code.

As such, big endian support is not complete, so i'm proposing to
mark it NOT_FOR_ARCHS.

Comments/feedback are welcome,

Charlène.


Index: Makefile
===================================================================
RCS file: /cvs/ports/emulators/nono/Makefile,v
retrieving revision 1.3
diff -u -p -u -p -r1.3 Makefile
--- Makefile 22 Jul 2020 14:53:59 -0000 1.3
+++ Makefile 31 Jul 2020 20:04:14 -0000
@@ -1,5 +1,8 @@
 # $OpenBSD: Makefile,v 1.3 2020/07/22 14:53:59 gonzalo Exp $
 
+# Big endian support is not complete as of 0.1.0
+NOT_FOR_ARCHS= ${BE_ARCHS}
+
 COMMENT= LUNA-I emulator
 
 DISTNAME= nono-0.1.0




Reply | Threaded
Open this post in threaded view
|

Re: [BE_ARCHS] don't build emulators/nono

kmos
On Fri, Jul 31, 2020 at 10:19:14PM +0200, Charlene Wendling wrote:
> Hi,

> > http://build-failures.rhaalovely.net/powerpc/2020-07-15/emulators/nono.log
> > http://build-failures.rhaalovely.net/mips64/2020-07-11/emulators/nono.log
> (it fails on sparc64 because ports-gcc is not used)

For the record, ports-gcc doesn't fix it. I tried that. :)

> $WRKSRC/vm/bitmap.h includes $WRKSRC/lib/device.h, where HLB and HLW
> are only defined on little endian archs. $WRKSRC/vm/bitmap.cpp
> expect them and has no fallback code.

> As such, big endian support is not complete, so i'm proposing to
> mark it NOT_FOR_ARCHS.

> Comments/feedback are welcome,
> Charlène.

ok kmos

--Kurt

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/emulators/nono/Makefile,v
> retrieving revision 1.3
> diff -u -p -u -p -r1.3 Makefile
> --- Makefile 22 Jul 2020 14:53:59 -0000 1.3
> +++ Makefile 31 Jul 2020 20:04:14 -0000
> @@ -1,5 +1,8 @@
>  # $OpenBSD: Makefile,v 1.3 2020/07/22 14:53:59 gonzalo Exp $
>  
> +# Big endian support is not complete as of 0.1.0
> +NOT_FOR_ARCHS= ${BE_ARCHS}
> +
>  COMMENT= LUNA-I emulator
>  
>  DISTNAME= nono-0.1.0
>
>
>
>