Amend history & authors info in bin/expr/expr.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Amend history & authors info in bin/expr/expr.1

Sevan Janiyan-3
Hello,
Attached patch makes some changes to the history and authors section of
expr(1) as follows:

1) State the first rewrite was a public domain version
2) The majority of the rewrite work was for NetBSD 1.0 [1]
3) It was largely rewritten by John T. Conklin in 1993 [1]


Sevan
[1]
http://cvsweb.netbsd.org/bsdweb.cgi/src/bin/expr/expr.y?rev=1.11&content-type=text/x-cvsweb-markup&only_with_tag=MAIN

patch-openbsd-expr1.txt (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Amend history & authors info in bin/expr/expr.1

Ingo Schwarze
Hi Sevan,

Sevan Janiyan Solaris wrote on Wed, Aug 24, 2016 at 01:35:38AM +0100:

> Index: bin/expr/expr.1
> ===================================================================
> RCS file: /cvs/src/bin/expr/expr.1,v
> retrieving revision 1.23
> diff -u -p -u -r1.23 expr.1
> --- bin/expr/expr.1 16 Jan 2015 15:30:10 -0000 1.23
> +++ bin/expr/expr.1 24 Aug 2016 00:29:29 -0000
> @@ -142,15 +142,15 @@ The
>  utility first appeared in the Programmer's Workbench (PWB/UNIX)
>  and has supported regular expressions since
>  .At v7 .
> -It was rewritten from scratch for
> +A public domain version was rewritten from scratch for
>  .Bx 386 0.1

We don't usually explain the history of licensing unless it is
exceptionally important or unusual.  It goes without saying that
something that appeared in PWB was usually proprietary, while stuff
that made it into 4.4BSD-Lite2 and/or NetBSD was almost certainly
free software.  The distinction of BSD vs. PD doesn't matter enough
to encumber HISTORY with it.

> -and again for
> -.Nx 1.1 .
> +and largely again for
> +.Nx 1.0 .

While both are true, i don't think it is important enough to mention
the earlier one of these two rewrites in OpenBSD given that it lived
less than a year before being superseded again.

>  .Sh AUTHORS
>  .An -nosplit
> -The first free version was written by
> +The public domain version was written by
>  .An Pace Willisson
>  in 1992.

Again, not important enough to change it.

> -This version was written by
> +It was largely rewritten by
>  .An John T. Conklin
> -in 1994.
> +in 1993.

That's outright misleading.  OpenBSD uses Conklin's NetBSD 1.1
version (written in C in 1994).  NetBSD uses jdolecek@'s NetBSD 1.6
version (written in yacc(1) in 2000).  Neither uses Conklin's NetBSD
1.0 version (written in yacc(1) in 1993).

  http://cvsweb.netbsd.org/bsdweb.cgi/src/bin/expr/Attic/expr.c

Yours,
  Ingo

Reply | Threaded
Open this post in threaded view
|

Re: Amend history & authors info in bin/expr/expr.1

Sevan Janiyan-3
Hi Ingo,

On 27/08/2016 14:40, Ingo Schwarze wrote:

>> -This version was written by
>> +It was largely rewritten by
>>  .An John T. Conklin
>> -in 1994.
>> +in 1993.
>
> That's outright misleading.  OpenBSD uses Conklin's NetBSD 1.1
> version (written in C in 1994).  NetBSD uses jdolecek@'s NetBSD 1.6
> version (written in yacc(1) in 2000).  Neither uses Conklin's NetBSD
> 1.0 version (written in yacc(1) in 1993).
>
>   http://cvsweb.netbsd.org/bsdweb.cgi/src/bin/expr/Attic/expr.c


As with real life, if you're looking for something, don't forget to
check the attic!
You're right, in the context of OpenBSD's history it does not make
sense. My findings was on the basis of the history of expr.y which
doesn't apply to OpenBSD. The difference in file extension would've been
another clue that there are further differences to investigate but it
did not click at the time.


Sevan