Adding New Commands to BGP Looking Glass?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Adding New Commands to BGP Looking Glass?

MonsieurFugu
Hi OpenBSD forum,

I've recently set up a BGPLG and I've been trying to add "mtrace" to the
drop down command list, but I've been having a bit of trouble getting it to
work and was wondering if anyone could point me in the right direction to
get it working.

I've configured the "bgplg.c" to define and add mtrace, I've gone into the
"bgplg.h" file to add mtrace as a command to the menu, and I've made sure to
copy the mtrace source files into the "/usr/src/usr.bin/bgplg" directory, as
well as the executable (I think its the executable anyway) into the
"/var/www/bin" directory. However even after rebooting and restarting
everything I can't get the mtrace command to appear in the drop down menu.

I tried my best to follow this walk through process of adding traceroute6
and ping6 to the bgplg
(http://openbsd-archive.7691.n7.nabble.com/Added-commands-for-bgplg-td155767.html),
which is the only source I've found that relates to adding new commands to
the BGPLG menu, but something still isn't working for me.

If you need specifics I can certainly supply screenshots or code snippets.
It's probably something obvious that I'm just not seeing, but any help would
be greatly appreciated.

Cheers.



--
Sent from: http://openbsd-archive.7691.n7.nabble.com/openbsd-user-misc-f3.html

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

Denis Fondras-3
> If you need specifics I can certainly supply screenshots or code snippets.
> It's probably something obvious that I'm just not seeing, but any help would
> be greatly appreciated.
>

Can you show some diff and detailed steps please ?

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

MonsieurFugu
Thanks for the reply,

So my first step was getting the "mtrace" source files and copying them into
the "/usr/src/usr.bin/bgplg/" directory, as that is the location of all the
other commands like ping and traceroute. I also added a copy of the
executable into "/var/www/bin/", as the other commands did likewise.
<http://openbsd-archive.7691.n7.nabble.com/file/t29577/mtrace_files_added.png>

Next I configured the "/usr/src/usr.bin/bgplg/bgplg.c" file to add and
define mtrace as a command. The rest of the .c file didn't seem to require
configuring so I left it as is.
<http://openbsd-archive.7691.n7.nabble.com/file/t29577/define_mtrace_dotc.png>

I finally edited the "/usr/src/usr.bin/bgplg/bgplg.h" file, adding the
mtrace command. I made the mtrace command to be a copy of the ping command
because I wasn't sure what the correct definition of the mtrace command was,
but that shouldn't have stopped the command appearing in the drop down menu
should it?
<http://openbsd-archive.7691.n7.nabble.com/file/t29577/define_mtrace_command_doth.png>

And after doing that it doesn't appear in my bgplg after rebooting and
restarting.
<http://openbsd-archive.7691.n7.nabble.com/file/t29577/Screenshot_%282%29.png>

Do you see where I might've gone wrong? I know that my definition in the .h
file is wrong, but I'm trying to get this working in baby steps, and perhaps
I was mistaken but I thought that having a duplicated function would still
make it appear in the bgplg menu. Is there anything obvious that leaps out
at you that I'm not seeing?

Thank you for the help.



--
Sent from: http://openbsd-archive.7691.n7.nabble.com/openbsd-user-misc-f3.html

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

Denis Fondras-3
> Do you see where I might've gone wrong? I know that my definition in the .h
> file is wrong, but I'm trying to get this working in baby steps, and perhaps
> I was mistaken but I thought that having a duplicated function would still
> make it appear in the bgplg menu. Is there anything obvious that leaps out
> at you that I'm not seeing?
>

It is not clear whether you rebuilt ebuilt bgplg or not.
Also mtrace binary needs to be built statically.

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

MonsieurFugu
> It is not clear whether you rebuilt bgplg or not.
> Also mtrace binary needs to be built statically.

I restarted the console and used the following commands;
# /etc/rc.d/httpd start
# /etc/rc.d/bgpd start
But I don't think that "rebuilt" the BGPLG. How do I do that?

Okay yeah I definitely didn't static build mtrace. I'll look online and see
how to do that.




--
Sent from: http://openbsd-archive.7691.n7.nabble.com/openbsd-user-misc-f3.html

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

Sebastian Benoit
MonsieurFugu([hidden email]) on 2018.07.24 03:48:11 -0700:

> > It is not clear whether you rebuilt bgplg or not.
> > Also mtrace binary needs to be built statically.
>
> I restarted the console and used the following commands;
> # /etc/rc.d/httpd start
> # /etc/rc.d/bgpd start
> But I don't think that "rebuilt" the BGPLG. How do I do that?
>
> Okay yeah I definitely didn't static build mtrace. I'll look online and see
> how to do that.

when you changed /usr/src/usr.bin/bgplg/bgplg.c
you need to

 cd /usr/src/usr.bin/bgplg/
 make obj
 make
 doas make install

after that, set the permissions in /var/www/bin/
as described in bgplg(8)
 

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

MonsieurFugu
Thank you for the reply,

Okay that's good to know- I'm getting a couple errors but I can probably
iron them out. So do I need to do that set of commands every time I add
something new to the "bgplg.c" file? Should those commands detect "mtrace"
automatically or do I need to do something else?

Thank you for the help man, you're a lifesaver; cheers!



--
Sent from: http://openbsd-archive.7691.n7.nabble.com/openbsd-user-misc-f3.html

Reply | Threaded
Open this post in threaded view
|

Re: Adding New Commands to BGP Looking Glass?

MonsieurFugu
In reply to this post by Sebastian Benoit
Sorry for the replies in quick succession, I just wanted to thank you- yup,
those commands got "mtrace" to appear! :D

Now all I have to do is configure the bgplg.h file to make the mtrace
command work properly, should be easy peasy

Thanks again dude!



--
Sent from: http://openbsd-archive.7691.n7.nabble.com/openbsd-user-misc-f3.html