Add missing RUN_DEPENDS to editors/py-neovim

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Add missing RUN_DEPENDS to editors/py-neovim

Kurt Mosiejczuk-9
I was testing the proposed net/py-msgpack update and found that
editors/py-neovim doesn't have a RUN_DEPENDS on editors/neovim.

While here, I changed to PERMIT_PACKAGE and removed the bespoke do-test
target in favor of just using MODPY_PYTEST. Also set PORTHOME so that
all tests pass.

cc maintainer

--Kurt

Index: Makefile
===================================================================
RCS file: /cvs/ports/editors/py-neovim/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- Makefile 15 May 2019 12:04:38 -0000 1.6
+++ Makefile 7 Jul 2019 17:35:00 -0000
@@ -5,30 +5,31 @@ COMMENT = Python plugin support for Neov
 MODPY_EGG_VERSION = 0.3.2
 DISTNAME = pynvim-${MODPY_EGG_VERSION}
 PKGNAME = py-neovim-${MODPY_EGG_VERSION}
-REVISION = 0
+REVISION = 1
 
 CATEGORIES = editors devel
 HOMEPAGE = https://github.com/neovim/python-client
 MAINTAINER = Edd Barrett <[hidden email]>
 
 # Apache-2.0
-PERMIT_PACKAGE_CDROM = Yes
+PERMIT_PACKAGE = Yes
 
 MODULES = lang/python
 MODPY_SETUPTOOLS = Yes
 MODPY_PI = Yes
+MODPY_PYTEST = Yes
 
 FLAVORS = python3
 FLAVOR ?=
 
+PORTHOME = ${WRKDIR}
+
 RUN_DEPENDS = net/py-msgpack${MODPY_FLAVOR} \
  devel/py-uv${MODPY_FLAVOR} \
- devel/py-greenlet${MODPY_FLAVOR}
+ devel/py-greenlet${MODPY_FLAVOR} \
+ editors/neovim
+# You may need to increase the file descriptor ulimits to run tests
 TEST_DEPENDS = devel/py-test${MODPY_FLAVOR} \
  ${BASE_PKGPATH}=${MODPY_EGG_VERSION}
-
-# You may need to increase the file descriptor ulimits to run tests.
-do-test:
- cd ${WRKSRC} && ${LOCALBASE}/bin/py.test${MODPY_BIN_SUFFIX}
 
 .include <bsd.port.mk>

Reply | Threaded
Open this post in threaded view
|

Re: Add missing RUN_DEPENDS to editors/py-neovim

Edd Barrett-3
On Sun, Jul 07, 2019 at 01:35:29PM -0400, Kurt Mosiejczuk wrote:
> I was testing the proposed net/py-msgpack update and found that
> editors/py-neovim doesn't have a RUN_DEPENDS on editors/neovim.

I think the reason I didn't add this dep is that you can connect to
remote neovim instances via the Python binding. See for example:

https://github.com/neovim/pynvim/blob/58ff62f42a708713eab2b6dcf388f805df4d1938/pynvim/__init__.py#L80

---8<---
nvim = attach('tcp', address=<address>, port=<port>)
--->8---

Thus you don't strictly need neovim locally (I think).

> While here, I changed to PERMIT_PACKAGE and removed the bespoke do-test
> target in favor of just using MODPY_PYTEST. Also set PORTHOME so that
> all tests pass.

Happy to make these changes though.

--
Best Regards
Edd Barrett

http://www.theunixzoo.co.uk

Reply | Threaded
Open this post in threaded view
|

Re: Add missing RUN_DEPENDS to editors/py-neovim

Kurt Mosiejczuk-9
On Sun, Jul 07, 2019 at 06:59:23PM +0100, Edd Barrett wrote:
> On Sun, Jul 07, 2019 at 01:35:29PM -0400, Kurt Mosiejczuk wrote:
> > I was testing the proposed net/py-msgpack update and found that
> > editors/py-neovim doesn't have a RUN_DEPENDS on editors/neovim.

> I think the reason I didn't add this dep is that you can connect to
> remote neovim instances via the Python binding. See for example:

> https://github.com/neovim/pynvim/blob/58ff62f42a708713eab2b6dcf388f805df4d1938/pynvim/__init__.py#L80

> ---8<---
> nvim = attach('tcp', address=<address>, port=<port>)
> --->8---

> Thus you don't strictly need neovim locally (I think).

OK, I suspect then it should be a TEST_DEPENDS instead. I went to run the
tests and it was all "What is nvim?". The *tests* don't do the remote
instance thing. :)

> > While here, I changed to PERMIT_PACKAGE and removed the bespoke do-test
> > target in favor of just using MODPY_PYTEST. Also set PORTHOME so that
> > all tests pass.

> Happy to make these changes though.

--Kurt